From: Nikita Gillmann <nikita@n0.is>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Nikita Gillmann <nikita@n0.is>, 41411@debbugs.gnu.org
Subject: [bug#41411] gnu: gnurl: Update to 7.70.0
Date: Wed, 20 May 2020 11:05:08 +0200 [thread overview]
Message-ID: <20200520090508.wc5rac3islnxy6se@hex> (raw)
In-Reply-To: <87a723fmtd.fsf@elephly.net>
Ricardo Wurmus transcribed 0.6K bytes:
>
> > runtests.pl:
> > In the environment of guix, $USER is unset.
> >
> > # get the name of the current user
> > my $USER = $ENV{USER}; # Linux
> > if (!$USER) {
> > $USER = $ENV{USERNAME}; # Windows
> > if (!$USER) {
> > $USER = $ENV{LOGNAME}; # Some Unix (I think)
> > }
> > }
> >
> >
> > leads to $USER being uninitialized at some point (around line 3600 or
> > something further below, grep for it). The tests loudly complain to the
> > log but it's not fatal.
>
> What is the USER variable used for? If it’s not needed why set it at all?
I did some reading in runtests.pl and then sshserver.pl. My perl knowledge
isn't that good but from what I can gather the main reason it exists is so
that sshserver.pl can check if the arguments passed to it and the env do not
result in user root starting an ssh server.
Most tests run with predefined user, and runtests.pl seems to do some
substition with $USER when it's in the environment. Since gnurl does not build
with ssh enabled I assume the ssh tests are unnecessary anyway (if they are
run at all), so a fallback to 'Anonymous' (like most tests which set this user)
should be free of unexpected side-effects.
> --
> Ricardo
next prev parent reply other threads:[~2020-05-20 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 22:17 [bug#41411] gnu: gnurl: Update to 7.70.0 Nikita Gillmann
2020-05-20 0:54 ` Ricardo Wurmus
2020-05-20 9:05 ` Nikita Gillmann [this message]
2020-06-17 10:01 ` bug#41411: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520090508.wc5rac3islnxy6se@hex \
--to=nikita@n0.is \
--cc=41411@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).