From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qP64GCGYw15VWwAA0tVLHw (envelope-from ) for ; Tue, 19 May 2020 08:26:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SGdaFCGYw14VWgAAB5/wlQ (envelope-from ) for ; Tue, 19 May 2020 08:26:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B342694017B for ; Tue, 19 May 2020 08:26:08 +0000 (UTC) Received: from localhost ([::1]:34390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaxZe-0000t8-JU for larch@yhetil.org; Tue, 19 May 2020 04:26:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaxZa-0000t0-Kj for guix-patches@gnu.org; Tue, 19 May 2020 04:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaxZa-0007Di-BS for guix-patches@gnu.org; Tue, 19 May 2020 04:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jaxZa-0005Ri-8e for guix-patches@gnu.org; Tue, 19 May 2020 04:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41247] [PATCH 0/5] Fix and update udisks Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 May 2020 08:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41247 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 41247@debbugs.gnu.org Received: via spool by 41247-submit@debbugs.gnu.org id=B41247.158987673620904 (code B ref 41247); Tue, 19 May 2020 08:26:02 +0000 Received: (at 41247) by debbugs.gnu.org; 19 May 2020 08:25:36 +0000 Received: from localhost ([127.0.0.1]:49127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaxZ9-0005R6-Q2 for submit@debbugs.gnu.org; Tue, 19 May 2020 04:25:36 -0400 Received: from flashner.co.il ([178.62.234.194]:37100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaxZ8-0005Qq-EU for 41247@debbugs.gnu.org; Tue, 19 May 2020 04:25:35 -0400 Received: from localhost (unknown [188.120.128.132]) by flashner.co.il (Postfix) with ESMTPSA id A463E401C7; Tue, 19 May 2020 08:25:27 +0000 (UTC) Date: Tue, 19 May 2020 11:24:51 +0300 From: Efraim Flashner Message-ID: <20200519082451.GK18220@E5400> References: <20200513222409.28811-1-brice@waegenei.re> <20200514082511.GO918@E5400> <0b6fad5ea8de541c864fe882d246d3ff@waegenei.re> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="++alDQ2ROsODg1x+" Content-Disposition: inline In-Reply-To: <0b6fad5ea8de541c864fe882d246d3ff@waegenei.re> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.69 X-TUID: SXC8XjWWK7Jy --++alDQ2ROsODg1x+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 14, 2020 at 01:50:50PM +0000, Brice Waegeneire wrote: > Hello Efraim, >=20 > On 2020-05-14 08:25, Efraim Flashner wrote: > > $ guix gc --references > > /gnu/store/g6pv8jfhi3m6a2wnvlwjcx4i3hjihnra-libblockdev-2.23 | grep xfs > >=20 > > it doesn't look like it actually links in xfs support. I see from the > > configure output that the FS plugin is built and installed in %out/lib. > > Does it work on xfs formatted partitions without linking to xfsprogs? >=20 > Listing all the references, 'btrfs-progs', 'dosfstools' and 'mdam' are al= so > not linked but are present as inputs. >=20 > --8<---------------cut here---------------start------------->8--- > /gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7.5.0-lib > /gnu/store/33y7wsvfh3i6mq9h7812pwagj8p2lrfd-libyaml-0.2.4 > /gnu/store/35afkywncrr5xsb4cxcljf6rpjcb7f61-gmp-6.2.0 > /gnu/store/5jf395qa3v4amdi60850rz2a15zlsrza-mpfr-4.0.2 > /gnu/store/5ydgg6rd9vqw0hf4a7ji65y4yw3ja665-lvm2-2.03.09 > /gnu/store/7ykddq56ssyqm1win3jlxm3ran94kq3q-libbytesize-2.2 > /gnu/store/9g1nq7qf5mkhbyjcyc0d7g9j02x3sdl2-argon2-20190702 > /gnu/store/9rk1sdzb9lqsi38knfi2pq5gqxfxi8d0-libgpg-error-1.37 > /gnu/store/9rvf68qxkq14sxajdp4gf8qqa026bjj2-kmod-26 > /gnu/store/a45p39mgqvfd8kjwibyr0q42k1mw7gmf-util-linux-2.35.1-lib > /gnu/store/bjp2vcbdsmckv2b4f69bci1z9n0i43b6-eudev-3.2.9 > /gnu/store/cbrx0nl7qwrz1j3r19ylahrgilyr1n83-json-c-0.13.1 > /gnu/store/dh5klm7h2nh930lj3kgiaqkqd8vpvjaa-parted-3.3 > /gnu/store/dp0q63a7ykqwsfwn1c1wx81ak51l0vp3-ndctl-68 > /gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31 > /gnu/store/g6pv8jfhi3m6a2wnvlwjcx4i3hjihnra-libblockdev-2.23 > /gnu/store/gfpgqvwrixhf3sf1bnzsfxzvld0nd8b7-nss-3.50 > /gnu/store/j9agmxk8iyjba4wvvam056s4n3phlg6h-gpgme-1.13.1 > /gnu/store/n2r0q34y5bjj3vd65p6nb64dghbgka01-volume-key-0.3.12 > /gnu/store/p2hkmh8rfw9qaspxlf0yd4qp1hzj0bc8-cryptsetup-2.2.2 > /gnu/store/q7hba8fqpix98qwcpf64izsf4wqhv1ij-libassuan-2.5.3 > /gnu/store/qc3k3kd458pgrqsc7ih641160q81npwq-libgcrypt-1.8.5 > /gnu/store/qvahafxrr2mcl4anjxdkkprrvd4k0xjj-pcre2-10.34 > /gnu/store/r7k859hmcnkazf492fasqvk25jflnfk6-xz-5.2.4 > /gnu/store/rmbxm1fg47b347kv1h5fb2w04nxqbsj6-glib-2.62.6 > /gnu/store/rykm237xkmq7rl1p0nwass01p090p88x-zlib-1.2.11 > /gnu/store/sdh81ijcxqlkns1c48lsdripfj34fmwq-dmraid-1.0.0.rc16-3 > /gnu/store/vqajm09by8dxxfl1fd7n45blfhzyg1gm-nspr-4.25 > --8<---------------cut here---------------end--------------->8--- >=20 > libblockdev seems to use the commands provided by those packages[0]. > They, including 'xfs', should be in the propagated-inputs field, right? >=20 > [0]: https://github.com/storaged-project/libblockdev/blob/master/src/plug= ins/fs/xfs.c#L45-L51 >=20 > - Brice So to summarize some of our conversation yesterday on IRC, we don't need to have some of the filesystem utilities as build inputs while building libblockdev. Libblockdev shells out to the different utilities to make use of their programs while interacting with the file systems. We'd rather not propagate all the file system utilities. We could patch the code itself in libblockdev so that when it shells out we give it the a path to the store where that program lives. We could add a note to libblockdev or udisks in the description telling people to install other programs if they need more functionality. Another option is to wrap udisks in the various filesystem programs so that they're available for use by libblockdev. I don't like the magic of "it works with udisks but not when I try it manually", but I do like it when packages just work. I don't like the idea of adding the note to libblockdev's description. I know I wouldn't look there if udisks didn't work the way I expected. If udisks didn't work the way I expected I don't know I'd check the description of the package. Currently udisks is the only package that uses libblockdev so functionally there's not a lot of difference between wrapping udisks or patching libblockdev, but that would change if other programs started using libbockdev. I'm concerned about the maintenance cost of patching libblockdev and making sure that the substitutions would need to be re-checked on each update, but it seems like the best method for making sure everything will just work. I think our best option is to patch libblockdev to provide absolute paths to the different binaries so that any program using libblockdev will just work. What do you think about that change? --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --++alDQ2ROsODg1x+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl7Dl9AACgkQQarn3Mo9 g1FRRw/+J50XdhVayxj2hpk/HQIBaFs3FpUC3yzPJW7NiM5M+cvepLicPCe5lVI9 walb+1MuKJSGeQD1JXWj5/pJecvYbg7UFXFB9mfusoI9+x6kGdR+mK0St8MPy1bb HMTKjCLaxCnEDHDd2wgbcwBYLR2bKXKYLf/bsGxVPhPoxc43+q0TdpcIyHJesQpS WBK04PqfihANN51Gui326NPBZumiuTBYjIJeGqcunt568yIJr/uuwn4d+6mrmTmy Ctesit6NL8ym4KN+cJ6EKesKL70KiVfy3p1l5WnZJ/S8dI+w8YDk6VT4XljOHM6t 3uWt9C/gYwEl3oPcOvHMBYuPPvBCCOd3s88L1bWe1njW2c7CtxSzKAsWLzsRLyw3 bTvQiyyBLJJLlf4BgnwaccWdH2Su/i5Po9Vf7zhx3PrcmhcOrEDcS9fpt1vvfLnK 64uyZav5fzO7cwSoOWc6VkYFMq2pocbDWI85WdjHQB5npkx+NSn/Nk5x60QjNIPH IGPos74LZiLtqYWqaOv8HC9pxVzU7WSCz/kJeNivZI6h6qQ9OtS00xpnnENsnRM0 TKZmP11VnJrSKDnh0bhsZv76lH8FKB7qN3nF1wErXiTGa85gcCpXA6sjNa2Pkntj f5eFn6rJ/OMUi40/YNW4meFYeVdGMrZYREyYqXvDS9pTBKXH6U4= =/qQz -----END PGP SIGNATURE----- --++alDQ2ROsODg1x+--