From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp0 ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms11 with LMTPS
	id YY+UHvRCvF5peQAA0tVLHw
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 13 May 2020 18:56:52 +0000
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp0 with LMTPS
	id iEBCEwNDvF6wHwAA1q6Kng
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Wed, 13 May 2020 18:57:07 +0000
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id A5193940BFF
	for <larch@yhetil.org>; Wed, 13 May 2020 18:57:04 +0000 (UTC)
Received: from localhost ([::1]:35410 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	id 1jYwYz-0001zg-LX
	for larch@yhetil.org; Wed, 13 May 2020 14:57:05 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:42252)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jYwYw-0001yq-4x
 for guix-patches@gnu.org; Wed, 13 May 2020 14:57:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:48000)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jYwYv-0002Xz-SE
 for guix-patches@gnu.org; Wed, 13 May 2020 14:57:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jYwYv-0004vY-Rl
 for guix-patches@gnu.org; Wed, 13 May 2020 14:57:01 -0400
X-Loop: help-debbugs@gnu.org
Subject: [bug#41226] gnu: Add bombadillo.
Resent-From: Efraim Flashner <efraim@flashner.co.il>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Wed, 13 May 2020 18:57:01 +0000
Resent-Message-ID: <handler.41226.B41226.158939620918921@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 41226
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: 
To: elaexuotee@wilsonb.com
Cc: 41226@debbugs.gnu.org
Received: via spool by 41226-submit@debbugs.gnu.org id=B41226.158939620918921
 (code B ref 41226); Wed, 13 May 2020 18:57:01 +0000
Received: (at 41226) by debbugs.gnu.org; 13 May 2020 18:56:49 +0000
Received: from localhost ([127.0.0.1]:59546 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1jYwYd-0004v0-0O
 for submit@debbugs.gnu.org; Wed, 13 May 2020 14:56:49 -0400
Received: from flashner.co.il ([178.62.234.194]:51348)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <efraim@flashner.co.il>) id 1jYwYb-0004um-Fc
 for 41226@debbugs.gnu.org; Wed, 13 May 2020 14:56:41 -0400
Received: from localhost (unknown [188.120.128.132])
 by flashner.co.il (Postfix) with ESMTPSA id 5279340212;
 Wed, 13 May 2020 18:56:35 +0000 (UTC)
Date: Wed, 13 May 2020 21:56:02 +0300
From: Efraim Flashner <efraim@flashner.co.il>
Message-ID: <20200513185602.GG918@E5400>
References: <31A6UJLD6OH4K.216PBSDR1OKVC@wilsonb.com>
 <38L6JFGGT7FFA.2BDMELJ0UOT4P@wilsonb.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="jaoouwwPWoQSJZYp"
Content-Disposition: inline
In-Reply-To: <38L6JFGGT7FFA.2BDMELJ0UOT4P@wilsonb.com>
X-PGP-Key-ID: 0x41AAE7DCCA3D8351
X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc
X-PGP-Fingerprint: A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
X-Spam-Score: 2.0 (++)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-Spam-Score: 1.0 (+)
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+larch=yhetil.org@gnu.org>
X-Scanner: scn0
X-Spam-Score: 0.69
Authentication-Results: aspmx1.migadu.com;
	dkim=none;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org
X-Scan-Result: default: False [0.69 / 13.00];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 GENERIC_REPUTATION(0.00)[-0.54001266847887];
	 DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail];
	 R_SPF_ALLOW(0.00)[+ip4:209.51.188.0/24:c];
	 IP_REPUTATION_HAM(0.00)[asn: 22989(0.05), country: US(-0.00), ip: 209.51.188.17(-0.54)];
	 TO_DN_NONE(0.00)[];
	 MX_GOOD(-0.50)[cached: eggs.gnu.org];
	 RCPT_COUNT_TWO(0.00)[2];
	 MAILLIST(-0.20)[mailman];
	 SIGNED_PGP(-2.00)[];
	 FORGED_RECIPIENTS_MAILLIST(0.00)[];
	 RCVD_IN_DNSWL_FAIL(0.00)[209.51.188.17:server fail];
	 R_DKIM_NA(0.00)[];
	 MIME_TRACE(0.00)[0:+,1:+,2:~];
	 ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US];
	 TAGGED_FROM(0.00)[larch=yhetil.org];
	 FROM_NEQ_ENVFROM(0.00)[efraim@flashner.co.il,guix-patches-bounces@gnu.org];
	 ARC_NA(0.00)[];
	 RECEIVED_SPAMHAUS_XBL(3.00)[188.120.128.132:received];
	 URIBL_BLOCKED(0.00)[wilsonb.com:email,disroot.org:email,gnu.org:email,lassieur.org:email,tildegit.org:url,flashner.co.il:email];
	 FROM_HAS_DN(0.00)[];
	 MIME_GOOD(-0.20)[multipart/signed,text/plain];
	 RCVD_TLS_LAST(0.00)[];
	 DMARC_NA(0.00)[flashner.co.il];
	 HAS_LIST_UNSUB(-0.01)[];
	 BAD_REP_POLICIES(0.10)[];
	 RECEIVED_SPAMHAUS_PBL(0.00)[188.120.128.132:received];
	 RWL_MAILSPIKE_POSSIBLE(0.00)[209.51.188.17:from];
	 MID_RHS_NOT_FQDN(0.50)[];
	 RCVD_COUNT_SEVEN(0.00)[8];
	 FORGED_SENDER_MAILLIST(0.00)[]
X-TUID: UJyT43YTxxBz


--jaoouwwPWoQSJZYp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

A couple of inline comments

On Wed, May 13, 2020 at 04:26:21PM +0900, elaexuotee--- via Guix-patches vi=
a wrote:
> Ugh, should have linkted and checkd indenting before sending. Here is an
> update.
>=20

> From b96fef2d85741ceac135a9c286a00a070b6b75e7 Mon Sep 17 00:00:00 2001
> From: "B. Wilson" <elaexuotee@wilsonb.com>
> Date: Wed, 13 May 2020 13:51:19 +0900
> Subject: [PATCH] gnu: Add bombadillo.
> To: guix-patches@gnu.org
>=20
> gnu/packages/web-browsers.scm (bombadillo): New variable.
> ---
>  gnu/packages/web-browsers.scm | 42 ++++++++++++++++++++++++++++++++++-
>  1 file changed, 41 insertions(+), 1 deletion(-)
>=20
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index 62b7a5bdca..acdd27509e 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -11,6 +11,7 @@
>  ;;; Copyright =C2=A9 2019 Cl=C3=A9ment Lassieur <clement@lassieur.org>
>  ;;; Copyright =C2=A9 2019 Brett Gilio <brettg@gnu.org>
>  ;;; Copyright =C2=A9 2020 Raghav Gururajan <raghavgururajan@disroot.org>
> +;;; Copyright =C2=A9 2020 B. Wilson <elaexuotee@wilsonb.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -66,7 +67,8 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system python)
> -  #:use-module (guix build-system asdf))
> +  #:use-module (guix build-system asdf)
> +  #:use-module (guix build-system go))
> =20
>  (define-public midori
>    (package
> @@ -692,3 +694,41 @@ key-bindings and is fully configurable and extensibl=
e in Common Lisp.")
> =20
>  (define-public sbcl-next
>    (deprecated-package "sbcl-next" next))
> +
> +(define-public bombadillo
> +  (package
> +    (name "bombadillo")
> +    (version "2.2.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://tildegit.org/sloum/bombadillo=
/"
> +                                  "archive/" version ".tar.gz"))

'guix lint' didn't catch this, but I'm pretty sure that this is an
auto-generated tarball and you should use git-fetch to download the
source instead.

> +              (sha256
> +               (base32
> +                "0g4zjg717zvva85h1sxw2zqzlrkbaw8h2w8zs2vk9krgn1q5wyh3"))
> +
> +              (file-name (string-append name "-" version))))
> +    (build-system go-build-system)
> +    (native-inputs `(("gzip" ,gzip)))
> +    (arguments `(#:import-path "tildegit.org/sloum/bombadillo"

Assuming nothing needs this to build another package, you can add
'#:install-source? #f' to the arguments.

> +                 #:phases
> +                 (modify-phases %standard-phases
> +                   (add-after 'install 'install-man
> +                     (lambda _
> +                       (let* ((manpage (string-append "src/tildegit.org"
> +                                                      "/sloum/bombadillo"
> +                                                      "/bombadillo.1"))
> +                              (zmanpage (string-append manpage ".gz"))
> +                              (mandir (string-append %output
> +                                                     "/share/man/man1")))
> +                         (invoke "gzip" manpage)
> +                         (install-file zmanpage mandir)

You actually don't need to gzip the man-page, it happens automatically
as part of the build process. Also, I noticed that there's a .desktop
file and a license file. Both of those can be installed.

> +                         #t))))))
> +    (home-page "http://bombadillo.colorfield.space")
> +    (synopsis "Terminal browser for the gopher, gemini, and finger proto=
cols")
> +    (description "Bombadillo is a non-web browser for the terminal with
> +vim-like key bindings, a document pager, configurable settings, and robu=
st
> +command selection.  The following protocols are supported as first-class
> +citizens: gopher, gemini, finger, and local.  There is also support for =
telnet,
> +http, and https via third-party applications.")
> +    (license license:gpl3+)))
> --=20
> 2.26.2
>=20

Other than those small things it looks good. Can you send an updated
patch?




--=20
Efraim Flashner   <efraim@flashner.co.il>   =D7=90=D7=A4=D7=A8=D7=99=D7=9D =
=D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

--jaoouwwPWoQSJZYp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl68Qr8ACgkQQarn3Mo9
g1F9Dg/+Ja9SNZvJzFCECHy23suFEVDwaOZeId0k/0UZgqWTJ4QbGifuaqLJ3za9
0bWHGxBDWIMc8tTtXYnmUid/U6ZOPxcUN7t18cSJOCDptJO7Y8Qwl5366Opre1hK
5B9O9s5Nz5plV4Sl/Ixno55uZo6an2BEoeVW2v3dPYJ2sRD7W15WTMfp8nbsd2Od
TjOWp1FI4C82HuM/gCK6iq8B6gxmM6RNya9FmzNjrWi2Vi6ojVfAUe8QIwyoNPu5
/Tg3H80pgUPcw+5yGDwLmD65jbRI4fJwJEXoc5P3o54mBx9QZ3ydEj+H/RlkaRnA
VSkyjw/CJU/xvVxdlBGaB9wjv2i0SbbCQqWNysM0XQNG9erkQuwlI4MmUH6cgxcs
NtGKNjRSM/S6cO/tXrMZdZ+KbWC4gNlR+Aje225ohc2klAW1yFB8HT4ujWfHV756
eGaEcxsqSKzqylhuYXooj9P7hDcu6xN48vEnn1Ltn/wz2mzRxx3nsEPmDvgbbAJK
3h1+WlkIhEfWKbknMMVItowtcNUhBhdTZ+PXpm1lsqyJnmw4bqDHstAyatjXKj7t
BvnARDHSyXC+UOvtlgEUrbOxPGVUzLOsi7KF6BjKvDrLogV+hFWVHbdZ+eZGmIkR
jnZJ6foODUC1rtNkEPCth4s2MS3Emlez1kD2lxXm5U4yJqyd6/Y=
=QEY0
-----END PGP SIGNATURE-----

--jaoouwwPWoQSJZYp--