unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#40471] [PATCH] gnu: Add lsp-plugins.
@ 2020-04-06 15:08 Alexandros Theodotou
  2020-04-07 20:08 ` Alexandros Theodotou
  0 siblings, 1 reply; 5+ messages in thread
From: Alexandros Theodotou @ 2020-04-06 15:08 UTC (permalink / raw)
  To: 40471

[-- Attachment #1: Type: text/plain, Size: 77 bytes --]

Hi,

This patch adds LSP plugins (https://lsp-plug.in/).

Thanks,
Alex

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#40471] [PATCH] gnu: Add lsp-plugins.
  2020-04-06 15:08 [bug#40471] [PATCH] gnu: Add lsp-plugins Alexandros Theodotou
@ 2020-04-07 20:08 ` Alexandros Theodotou
  2020-05-06 19:55   ` Efraim Flashner
  0 siblings, 1 reply; 5+ messages in thread
From: Alexandros Theodotou @ 2020-04-07 20:08 UTC (permalink / raw)
  To: 40471


[-- Attachment #1.1: Type: text/plain, Size: 25 bytes --]

Oops, here's the patch.

[-- Attachment #1.2: 0001-gnu-Add-lsp-plugins.patch --]
[-- Type: text/x-patch, Size: 2277 bytes --]

From 5426409d1d392b8f5fab184a64526d597dd690fa Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Mon, 6 Apr 2020 16:07:19 +0100
Subject: [PATCH] gnu: Add lsp-plugins.

* gnu/packages/music.scm (lsp-plugins): new variable.
---
 gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index ee402bad4d..41c93c5a90 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5380,3 +5380,46 @@ filtered, pitch shifted and ultimately disintegrated.  This is an unofficial
 port of the Regrader plugin created by Igorski.  It is available as an LV2
 plugin and a standalone JACK application.")
     (license license:expat)))
+
+(define-public lsp-plugins
+  (package
+    (name "lsp-plugins")
+    (version "1.1.17")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/sadko4u/lsp-plugins.git")
+               (commit (string-append "lsp-plugins-" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "04w3lhnbnfynrr3zpcr7cdrlddxa6v3mdmj7rvbxi2xbczbqpa15"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags
+       (list "CC=gcc" "BUILD_MODULES=\"lv2 ladspa jack\"" "VST_UI=0"
+             (string-append "PREFIX=" (assoc-ref %outputs "out"))
+             (string-append "ETC_PATH=" (assoc-ref %outputs "out") "/etc"))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure) ; no configure
+         (replace 'check
+           (lambda _
+             (invoke "make" "test"))))))
+    (inputs
+      `(("cairo", cairo)
+        ("hicolor-icon-theme", hicolor-icon-theme)
+        ("jack", jack-1)
+        ("ladspa", ladspa)
+        ("libsndfile", libsndfile)
+        ("lv2", lv2)
+        ("mesa", mesa)))
+    (native-inputs
+      `(("pkg-config", pkg-config)))
+    (synopsis "Audio plugin collection")
+    (description "LSP (Linux Studio Plugins) is a collection of audio
+plugins available as LADSPA/LV2 plugins and as standalone JACK
+applications.")
+    (home-page "https://lsp-plug.in/")
+    (license license:lgpl3)))
-- 
2.26.0


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#40471] [PATCH] gnu: Add lsp-plugins.
  2020-04-07 20:08 ` Alexandros Theodotou
@ 2020-05-06 19:55   ` Efraim Flashner
  2020-05-27  0:06     ` Alexandros Theodotou
  0 siblings, 1 reply; 5+ messages in thread
From: Efraim Flashner @ 2020-05-06 19:55 UTC (permalink / raw)
  To: Alexandros Theodotou; +Cc: 40471

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

This actually failed to build for me, even when I bumped the version up
to 1.1.19. Can you take a look at it?

Thanks


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#40471] [PATCH] gnu: Add lsp-plugins.
  2020-05-06 19:55   ` Efraim Flashner
@ 2020-05-27  0:06     ` Alexandros Theodotou
  2020-05-27  9:25       ` bug#40471: " Efraim Flashner
  0 siblings, 1 reply; 5+ messages in thread
From: Alexandros Theodotou @ 2020-05-27  0:06 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 40471


[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]

Fixed! The failure was due to the lv2 upgrade. The upstream has fixed
this in the new release.

See new patch attached.

Thanks,
Alex

On Wed, 2020-05-06 at 22:55 +0300, Efraim Flashner wrote:
> This actually failed to build for me, even when I bumped the version
> up
> to 1.1.19. Can you take a look at it?
> 
> Thanks
> 
> 

[-- Attachment #1.2: 0001-gnu-Add-lsp-plugins.patch --]
[-- Type: text/x-patch, Size: 2243 bytes --]

From b3aa2ea22bc2be15a7ab11c792ea85a1ec3900d6 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Wed, 27 May 2020 01:04:42 +0100
Subject: [PATCH] gnu: Add lsp-plugins.

* gnu/packages/music.scm (lsp-plugins): new variable.
---
 gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2c6be8eba8..f01978d118 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4863,6 +4863,49 @@ effects.  It contains a bitcrusher, delay, distortion, equalizer, compressor,
 and reverb.")
     (license license:gpl2+)))
 
+(define-public lsp-plugins
+  (package
+    (name "lsp-plugins")
+    (version "1.1.21")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/sadko4u/lsp-plugins.git")
+               (commit (string-append "lsp-plugins-" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "1zw0iip6ki9k65kh8dp53x7l4va4mi5rj793n2yn4p9y84qzwrz9"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags
+       (list "CC=gcc" "BUILD_MODULES=\"lv2 ladspa jack\"" "VST_UI=0"
+             (string-append "PREFIX=" (assoc-ref %outputs "out"))
+             (string-append "ETC_PATH=" (assoc-ref %outputs "out") "/etc"))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure) ; no configure
+         (replace 'check
+           (lambda _
+             (invoke "make" "test"))))))
+    (inputs
+      `(("cairo", cairo)
+        ("hicolor-icon-theme", hicolor-icon-theme)
+        ("jack", jack-1)
+        ("ladspa", ladspa)
+        ("libsndfile", libsndfile)
+        ("lv2", lv2)
+        ("mesa", mesa)))
+    (native-inputs
+      `(("pkg-config", pkg-config)))
+    (synopsis "Audio plugin collection")
+    (description "LSP (Linux Studio Plugins) is a collection of audio
+plugins available as LADSPA/LV2 plugins and as standalone JACK
+applications.")
+    (home-page "https://lsp-plug.in/")
+    (license license:lgpl3)))
+
 (define-public sherlock-lv2
   (package
     (name "sherlock-lv2")
-- 
2.26.2


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#40471: [PATCH] gnu: Add lsp-plugins.
  2020-05-27  0:06     ` Alexandros Theodotou
@ 2020-05-27  9:25       ` Efraim Flashner
  0 siblings, 0 replies; 5+ messages in thread
From: Efraim Flashner @ 2020-05-27  9:25 UTC (permalink / raw)
  To: Alexandros Theodotou; +Cc: 40471-done

[-- Attachment #1: Type: text/plain, Size: 3338 bytes --]

Patched pushed with a few changes:

On Wed, May 27, 2020 at 01:06:38AM +0100, Alexandros Theodotou wrote:
> Fixed! The failure was due to the lv2 upgrade. The upstream has fixed
> this in the new release.
> 
> See new patch attached.
> 
> Thanks,
> Alex
> 
> On Wed, 2020-05-06 at 22:55 +0300, Efraim Flashner wrote:
> > This actually failed to build for me, even when I bumped the version
> > up
> > to 1.1.19. Can you take a look at it?
> > 
> > Thanks
> > 
> > 

> From b3aa2ea22bc2be15a7ab11c792ea85a1ec3900d6 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Wed, 27 May 2020 01:04:42 +0100
> Subject: [PATCH] gnu: Add lsp-plugins.
> 
> * gnu/packages/music.scm (lsp-plugins): new variable.
> ---
>  gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 2c6be8eba8..f01978d118 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -4863,6 +4863,49 @@ effects.  It contains a bitcrusher, delay, distortion, equalizer, compressor,
>  and reverb.")
>      (license license:gpl2+)))
>  
> +(define-public lsp-plugins
> +  (package
> +    (name "lsp-plugins")
> +    (version "1.1.21")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/sadko4u/lsp-plugins.git")
> +               (commit (string-append "lsp-plugins-" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32
> +            "1zw0iip6ki9k65kh8dp53x7l4va4mi5rj793n2yn4p9y84qzwrz9"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags

I changed the CC=gcc line so that it can cross compile

> +       (list "CC=gcc" "BUILD_MODULES=\"lv2 ladspa jack\"" "VST_UI=0"
> +             (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +             (string-append "ETC_PATH=" (assoc-ref %outputs "out") "/etc"))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure) ; no configure

I changed this to a #:test-flag

> +         (replace 'check
> +           (lambda _
> +             (invoke "make" "test"))))))

And I re-indented so that the ` was under the 'i' in inputs.
Same with native-inputs.

> +    (inputs
> +      `(("cairo", cairo)
> +        ("hicolor-icon-theme", hicolor-icon-theme)
> +        ("jack", jack-1)
> +        ("ladspa", ladspa)
> +        ("libsndfile", libsndfile)
> +        ("lv2", lv2)
> +        ("mesa", mesa)))
> +    (native-inputs
> +      `(("pkg-config", pkg-config)))
> +    (synopsis "Audio plugin collection")
> +    (description "LSP (Linux Studio Plugins) is a collection of audio
> +plugins available as LADSPA/LV2 plugins and as standalone JACK
> +applications.")
> +    (home-page "https://lsp-plug.in/")
> +    (license license:lgpl3)))
> +
>  (define-public sherlock-lv2
>    (package
>      (name "sherlock-lv2")
> -- 
> 2.26.2
> 




-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-05-27  9:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-06 15:08 [bug#40471] [PATCH] gnu: Add lsp-plugins Alexandros Theodotou
2020-04-07 20:08 ` Alexandros Theodotou
2020-05-06 19:55   ` Efraim Flashner
2020-05-27  0:06     ` Alexandros Theodotou
2020-05-27  9:25       ` bug#40471: " Efraim Flashner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).