unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#40920] gnu: Add gtksu.
@ 2020-04-28  2:35 Raghav Gururajan
  2020-05-03  6:38 ` 宋文武
  0 siblings, 1 reply; 4+ messages in thread
From: Raghav Gururajan @ 2020-04-28  2:35 UTC (permalink / raw)
  To: 40920

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]



[-- Attachment #2: 0002-gnu-Add-gtksu.patch --]
[-- Type: application/octet-stream, Size: 2361 bytes --]

From 50743e3c242c3e5e10f5e144c72025610278c94d Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Mon, 27 Apr 2020 22:32:56 -0400
Subject: [PATCH 2/2] gnu: Add gtksu.

* gnu/packages/admin.scm (gtksu): New variable.
---
 gnu/packages/admin.scm | 45 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 9316e974bc..2db399ec38 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -130,6 +130,51 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg))
 
+(define-public gtksu
+  (package
+    (name "gtksu")
+    (version "0.1.6")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://github.com/KeithDHedger/GtkSu.git")
+         (commit (string-append name "-" version))))
+       (sha256
+        (base32 "1lrlyps1960294kcn3b0m86hdxr87hy3wmyjsjqwfb2rcrm0vvwg"))
+       (file-name (git-file-name name version))))
+    (build-system glib-or-gtk-build-system)
+    (arguments
+     `(#:configure-flags
+       ;; Creates ktsuss link that will refer to gtksu; so that some programs
+       ;; that hard code the files, think that ktsuss is being used.
+       (list "--enable-ktsuss-link")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-suwrap
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* "GtkSu/MakeSuWrap/suwrap.cpp"
+               (("/usr/bin/xauth")
+                (string-append (assoc-ref inputs "xauth") "/bin/xauth"))
+               (("/usr/X11R6/bin/xauth")
+                (string-append (assoc-ref inputs "xauth") "/bin/xauth")))
+             #t)))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("glib" ,glib)
+       ("gtk+" ,gtk+-2)
+       ("xauth" ,xauth)))
+    (synopsis "Graphical front end for @command{su}")
+    (description "GtkSu is a simple replacement for gksu/ktsuss etc that allows
+you to run a program with different privileges ( root etc ).")
+    (home-page "https://github.com/KeithDHedger/GtkSu")
+    (license license:gpl3+)))
+
 (define-public ktsuss
   (package
     (name "ktsuss")
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#40920] gnu: Add gtksu.
  2020-04-28  2:35 [bug#40920] gnu: Add gtksu Raghav Gururajan
@ 2020-05-03  6:38 ` 宋文武
  2020-05-04  3:23   ` Raghav Gururajan
  0 siblings, 1 reply; 4+ messages in thread
From: 宋文武 @ 2020-05-03  6:38 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 40920

"Raghav Gururajan" <raghavgururajan@disroot.org> writes:

> From 50743e3c242c3e5e10f5e144c72025610278c94d Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Mon, 27 Apr 2020 22:32:56 -0400
> Subject: [PATCH 2/2] gnu: Add gtksu.
>
> * gnu/packages/admin.scm (gtksu): New variable.

Hello, this patch looks good to me, but after install, it doesn't works..

I think gtksuwrap should be setup with 'setuid', and gtksu should look
it through PATH or under '/run/setuid-programs'.  Also this program
lookup executables in '_PATH_STDPATH' (and '_PATH_DEFPATH') from glibc's
'shadow.h' and 'paths.h', they're defined as
'/usr/bin:/bin:/usr/sbin:/sbin' and '/usr/bin:/bin', so we'd better
modify 'paths.h' in glibc or modify gtksu to use a suitable 'PATH'.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#40920] gnu: Add gtksu.
  2020-05-03  6:38 ` 宋文武
@ 2020-05-04  3:23   ` Raghav Gururajan
  2020-05-30  5:05     ` bug#40920: " Maxim Cournoyer
  0 siblings, 1 reply; 4+ messages in thread
From: Raghav Gururajan @ 2020-05-04  3:23 UTC (permalink / raw)
  To: 宋文武; +Cc: 40920

Hi!

> Hello, this patch looks good to me, but after install, it doesn't works..
> 
> I think gtksuwrap should be setup with 'setuid', and gtksu should look
> it through PATH or under '/run/setuid-programs'.  Also this program
> lookup executables in '_PATH_STDPATH' (and '_PATH_DEFPATH') from glibc's
> 'shadow.h' and 'paths.h', they're defined as
> '/usr/bin:/bin:/usr/sbin:/sbin' and '/usr/bin:/bin', so we'd better
> modify 'paths.h' in glibc or modify gtksu to use a suitable 'PATH'.

Sorry, I sent this patch by mistake. I was packaged ktsuss, which is now in
master. :-)

Regards,
RG.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#40920: gnu: Add gtksu.
  2020-05-04  3:23   ` Raghav Gururajan
@ 2020-05-30  5:05     ` Maxim Cournoyer
  0 siblings, 0 replies; 4+ messages in thread
From: Maxim Cournoyer @ 2020-05-30  5:05 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 40920-done, 宋文武

Raghav Gururajan <raghavgururajan@disroot.org> writes:

> Hi!
>
>> Hello, this patch looks good to me, but after install, it doesn't works..
>> 
>> I think gtksuwrap should be setup with 'setuid', and gtksu should look
>> it through PATH or under '/run/setuid-programs'.  Also this program
>> lookup executables in '_PATH_STDPATH' (and '_PATH_DEFPATH') from glibc's
>> 'shadow.h' and 'paths.h', they're defined as
>> '/usr/bin:/bin:/usr/sbin:/sbin' and '/usr/bin:/bin', so we'd better
>> modify 'paths.h' in glibc or modify gtksu to use a suitable 'PATH'.
>
> Sorry, I sent this patch by mistake. I was packaged ktsuss, which is now in
> master. :-)

Closing, then, by editing the debbugs email in my wide reply to
40920-done@debbugs.gnu.org (hint: you can do it yourself next time :-)).

Maxim




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-30  5:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28  2:35 [bug#40920] gnu: Add gtksu Raghav Gururajan
2020-05-03  6:38 ` 宋文武
2020-05-04  3:23   ` Raghav Gururajan
2020-05-30  5:05     ` bug#40920: " Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).