unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 40980@debbugs.gnu.org
Subject: [bug#40980] gnu: xfe: Fix configuration and icons. (v2)
Date: Fri, 1 May 2020 13:55:54 +0200	[thread overview]
Message-ID: <20200501135554.07ea33ac@scratchpost.org> (raw)
In-Reply-To: <20200501034703.685faec8.raghavgururajan@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

Hi Raghav,

On Fri, 1 May 2020 03:47:03 -0400
Raghav Gururajan <raghavgururajan@disroot.org> wrote:

> * gnu/packages/disk.scm (xfe): Fix configuration and icons.

Please mention the phases and arguments you changed.

>       (origin
>         (method url-fetch)
>         (uri
> -        (string-append "https://sourceforge.net/projects/xfe/files/xfe/"
> -                       version
> -                       "/xfe-" version ".tar.gz"))
> +        (string-append "https://sourceforge.net/projects/" name "/files/" name
> +                       "/" version "/" name "-" version ".tar.gz"))

Please don't do that without a good reason because it makes us unable to rename
our package later.

> -         (add-after 'unpack 'patch-xferc-path
> +         (add-after 'unpack 'patch-xfe-paths

Please mention this in the commit log.

> -       #:make-flags
> -       (let ((out (assoc-ref %outputs "out")))
> -         (list (string-append "BASH_COMPLETION_DIR=" out
> -                              "/share/bash-completion/completions")))))

Please mention the removal of make-flags in the commit log.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-05-01 11:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 11:29 [bug#40980] gnu: xfe: Fix configuration and icons Raghav Gururajan
2020-05-01  7:47 ` [bug#40980] gnu: xfe: Fix configuration and icons. (v2) Raghav Gururajan
2020-05-01 11:55   ` Danny Milosavljevic [this message]
2020-05-01 14:41     ` [bug#40980] gnu: xfe: Fix configuration and icons. (v3) Raghav Gururajan
2020-05-01 14:54       ` Danny Milosavljevic
2020-05-01 16:45         ` [bug#40980] gnu: xfe: Fix configuration and icons. (v4) Raghav Gururajan
2020-05-01 17:21           ` bug#40980: " Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200501135554.07ea33ac@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=40980@debbugs.gnu.org \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).