From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wLQjF4k1rF5wUQAA0tVLHw (envelope-from ) for ; Fri, 01 May 2020 14:43:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id APK/EZI1rF66QQAAB5/wlQ (envelope-from ) for ; Fri, 01 May 2020 14:43:30 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3E7EF9400EA for ; Fri, 1 May 2020 14:43:29 +0000 (UTC) Received: from localhost ([::1]:58710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUWsz-0006s6-Ah for larch@yhetil.org; Fri, 01 May 2020 10:43:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51684) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUWsm-0006db-4g for guix-patches@gnu.org; Fri, 01 May 2020 10:43:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUWsY-00062G-Av for guix-patches@gnu.org; Fri, 01 May 2020 10:43:15 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUWsX-00061l-RF for guix-patches@gnu.org; Fri, 01 May 2020 10:43:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUWsX-0001Vn-O9 for guix-patches@gnu.org; Fri, 01 May 2020 10:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40980] gnu: xfe: Fix configuration and icons. (v3) Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 May 2020 14:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40980 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Danny Milosavljevic Cc: 40980@debbugs.gnu.org Received: via spool by 40980-submit@debbugs.gnu.org id=B40980.15883441345737 (code B ref 40980); Fri, 01 May 2020 14:43:01 +0000 Received: (at 40980) by debbugs.gnu.org; 1 May 2020 14:42:14 +0000 Received: from localhost ([127.0.0.1]:50393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUWri-0001UQ-Qb for submit@debbugs.gnu.org; Fri, 01 May 2020 10:42:14 -0400 Received: from knopi.disroot.org ([178.21.23.139]:48168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUWrc-0001UB-Re for 40980@debbugs.gnu.org; Fri, 01 May 2020 10:42:09 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 5970F28973; Fri, 1 May 2020 16:42:03 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IepeeF9Wm-ml; Fri, 1 May 2020 16:41:59 +0200 (CEST) Date: Fri, 1 May 2020 10:41:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1588344116; bh=Zmr3eHR9BwOG5ddkAoa62O1/fPSepu/tIE4dTaYLgsM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=URNn8VwfLuoQ5uXHe0OyykZoVSbfESoTRLwi+cW78k4jcYTatWarpS5MAlhDhTFm6 NORi9OjIcRb7DLJtEMrxlO7nb0KCqVH0ILf2EWR2oqFBrGzZng+ZvvT5AX/GRBmUkM VHjqCThosnITV38K75R9f2gklJDPnKADpv5aLdobU4XYPCwaxm5XkXJxdlRbir+BUH rcQIB0c34WzfKpvCxTWmC0da0MkF2OwcjjMcRF6yeDvzepwVa9jPRWdA6BRIGm1PkU pqHJXCe/1mqbjk8wOdf/X3Ver4HYDYaxZNqQBHK1Rqo5UDFncbMgTBaQLADtIWLDaY WeURAjXvsn8Ag== From: Raghav Gururajan Message-ID: <20200501104129.339a98c7.raghavgururajan@disroot.org> In-Reply-To: <20200501135554.07ea33ac@scratchpost.org> References: <20200430072930.607771c2.raghavgururajan@disroot.org> <20200501034703.685faec8.raghavgururajan@disroot.org> <20200501135554.07ea33ac@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/8a4NfhiJzKASxXPnymEb2WX" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: 1.59 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=disroot.org header.s=mail header.b=URNn8Vwf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=disroot.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [1.59 / 13.00]; GENERIC_REPUTATION(0.00)[-0.49523068719542]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; MV_CASE(0.50)[]; HAS_ATTACHMENT(0.00)[]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.16), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; R_DKIM_REJECT(1.00)[disroot.org:s=mail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[disroot.org:-]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[raghavgururajan@disroot.org,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[disroot.org:email]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[2001:470:142::17:from]; MID_CONTAINS_FROM(1.00)[]; RCVD_COUNT_SEVEN(0.00)[10]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[disroot.org : SPF not aligned (relaxed),none] X-TUID: R7lYEmE1eBKz --MP_/8a4NfhiJzKASxXPnymEb2WX Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Danny! > > * gnu/packages/disk.scm (xfe): Fix configuration and icons. > > Please mention the phases and arguments you changed. > > > (origin > > (method url-fetch) > > (uri > > - (string-append "https://sourceforge.net/projects/xfe/files/xfe/" > > - version > > - "/xfe-" version ".tar.gz")) > > + (string-append "https://sourceforge.net/projects/" name "/files/" > > name > > + "/" version "/" name "-" version ".tar.gz")) > > Please don't do that without a good reason because it makes us unable to > rename our package later. > > > - (add-after 'unpack 'patch-xferc-path > > + (add-after 'unpack 'patch-xfe-paths > > Please mention this in the commit log. > > > - #:make-flags > > - (let ((out (assoc-ref %outputs "out"))) > > - (list (string-append "BASH_COMPLETION_DIR=" out > > - "/share/bash-completion/completions"))))) > > Please mention the removal of make-flags in the commit log. Please find the revised patch attached with this email. Regards, RG. --MP_/8a4NfhiJzKASxXPnymEb2WX Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-xfe-Fix-configuration-and-icons.patch >From 18ead96ab6498f2e197ca967e0e55a4c84cbb8f9 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Fri, 1 May 2020 10:29:06 -0400 Subject: [PATCH] gnu: xfe: Fix configuration and icons. In patch-phase, added paths to datadir, xferc and icons; to patch the respective and load them correctly. Changed name of patch-phase to fit above changes. Removed bash-completion make-flag, as the directory does not exist. * gnu/packages/disk.scm (xfe): Fix configuration and icons. --- gnu/packages/disk.scm | 35 +++++++++++++++++++++++------------ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm index b7d3b9d954..41429b73cc 100644 --- a/gnu/packages/disk.scm +++ b/gnu/packages/disk.scm @@ -918,8 +918,7 @@ since they are better handled by external tools.") (method url-fetch) (uri (string-append "https://sourceforge.net/projects/xfe/files/xfe/" - version - "/xfe-" version ".tar.gz")) + version "/xfe-" version ".tar.gz")) (sha256 (base32 "1fl51k5jm2vrfc2g66agbikzirmp0yb0lqhmsssixfb4mky3hpzs")))) (build-system gnu-build-system) @@ -937,20 +936,32 @@ since they are better handled by external tools.") (arguments `(#:phases (modify-phases %standard-phases - (add-after 'unpack 'patch-xferc-path + (add-after 'unpack 'patch-xfe-paths (lambda* (#:key outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (xferc (string-append out "/share/xfe/xferc"))) + (let* + ((out (assoc-ref outputs "out")) + (share (string-append out "/share")) + (xferc (string-append out "/share/xfe/xferc")) + (xfe-theme (string-append out "/share/xfe/icons/xfe-theme"))) + ;; Correct path for xfe registry. + (substitute* "src/foxhacks.cpp" + (("/etc:/usr/share:/usr/local/share") share)) + ;; Correct path for xfe configuration. (substitute* "src/XFileExplorer.cpp" - (("/usr/share/xfe/xferc") xferc)) - #t)))) - #:make-flags - (let ((out (assoc-ref %outputs "out"))) - (list (string-append "BASH_COMPLETION_DIR=" out - "/share/bash-completion/completions"))))) + (("/usr/share/xfe/xferc") xferc) + (("/usr/local/share/xfe/xferc") xferc) + (("/opt/local/share/xfe/xferc") xferc)) + ;; Correct path for xfe icons. + (substitute* "src/xfedefs.h" + (((string-append + "~/.config/xfe/icons/xfe-theme:" + "/usr/local/share/xfe/icons/xfe-theme:" + "/usr/share/xfe/icons/xfe-theme")) + xfe-theme)) + #t)))))) (synopsis "File Manager for X-Based Graphical Systems") (description"XFE (X File Explorer) is a file manager for X. It is based on the popular but discontinued, X Win Commander. It aims to be the file manager of choice for all light thinking Unix addicts!") (home-page "http://roland65.free.fr/xfe/") - (license license:gpl2+))) + (license license:gpl2+))) \ No newline at end of file -- 2.26.2 --MP_/8a4NfhiJzKASxXPnymEb2WX--