From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 5zBfM57aqV4mFgAA0tVLHw (envelope-from ) for ; Wed, 29 Apr 2020 19:50:54 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sHTjEKfaqV4lLgAA1q6Kng (envelope-from ) for ; Wed, 29 Apr 2020 19:51:03 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 40DBE941C78 for ; Wed, 29 Apr 2020 19:51:02 +0000 (UTC) Received: from localhost ([::1]:60522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTsjW-0003mI-4c for larch@yhetil.org; Wed, 29 Apr 2020 15:51:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48846) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTsge-00008I-5l for guix-patches@gnu.org; Wed, 29 Apr 2020 15:48:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTsgc-0004Zu-Tw for guix-patches@gnu.org; Wed, 29 Apr 2020 15:48:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33201) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTsgc-0004X6-F9 for guix-patches@gnu.org; Wed, 29 Apr 2020 15:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTsgc-0005NJ-Ds for guix-patches@gnu.org; Wed, 29 Apr 2020 15:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40959] [PATCH 1/1] gnu: Add icedove. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Apr 2020 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40959 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: 40959@debbugs.gnu.org, malacoda@monarch-pass.net, gillmann@infotropique.org, Jonathan Brielmaier Received: via spool by 40959-submit@debbugs.gnu.org id=B40959.158818966320618 (code B ref 40959); Wed, 29 Apr 2020 19:48:02 +0000 Received: (at 40959) by debbugs.gnu.org; 29 Apr 2020 19:47:43 +0000 Received: from localhost ([127.0.0.1]:44744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTsgJ-0005MS-7o for submit@debbugs.gnu.org; Wed, 29 Apr 2020 15:47:43 -0400 Received: from flashner.co.il ([178.62.234.194]:56732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTsgH-0005ME-Ua for 40959@debbugs.gnu.org; Wed, 29 Apr 2020 15:47:42 -0400 Received: from localhost (unknown [31.210.177.209]) by flashner.co.il (Postfix) with ESMTPSA id BD75F4005E; Wed, 29 Apr 2020 19:47:35 +0000 (UTC) Date: Wed, 29 Apr 2020 22:47:02 +0300 From: Efraim Flashner Message-ID: <20200429194702.GX5243@E5400> References: <20200429105614.11517-1-jonathan.brielmaier@web.de> <20200429110018.11677-1-jonathan.brielmaier@web.de> <877dxyjpsv.fsf@elephly.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="g3IWFuR7/O9KKcN6" Content-Disposition: inline In-Reply-To: <877dxyjpsv.fsf@elephly.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -2.61 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-2.61 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49362826937924]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.17), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCPT_COUNT_FIVE(0.00)[5]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; RECEIVED_SPAMHAUS_PBL(0.00)[31.210.177.209:received]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[efraim@flashner.co.il,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[torproject.org:url,flashner.co.il:email,gnu.org:url]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MIME_TRACE(0.00)[0:+,1:+,2:~]; DMARC_NA(0.00)[flashner.co.il]; HAS_LIST_UNSUB(-0.01)[]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_CC(0.00)[debbugs.gnu.org,monarch-pass.net,infotropique.org,web.de]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: qWf0CTAc88DY --g3IWFuR7/O9KKcN6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 29, 2020 at 05:05:04PM +0200, Ricardo Wurmus wrote: >=20 > Thank you for this patch. >=20 > > + (arguments > > + `(#:tests? #f ; no check target > > + ;; XXX: There are RUNPATH issues such as > > + ;; $prefix/lib/icecat-31.6.0/plugin-container NEEDing libmozall= oc.so, > > + ;; which is not in its RUNPATH, but they appear to be harmless = in > > + ;; practice somehow. See . > > + #:validate-runpath? #f >=20 > The comment seems to have been copied from somewhere. I don=E2=80=99t th= ink > this package produces $prefix/lib/icecat-31.6.0/plugin-container >=20 > The URL is also no longer reachable. >=20 > > + (add-after 'unpack 'remove-bundled-libraries > > + (lambda _ > > + ;; Remove bundled libraries that we don't use. > > + (for-each (lambda (file) > > + (format #t "deleting '~a'...~%" file) > > + (delete-file-recursively file)) > > + '(;; UNBUNDLE-ME! icu > > + ;; UNBUNDLE-ME! nss > > + "modules/zlib")) > > + #t)) >=20 > This should be done in a snippet. >=20 > > + (add-after 'patch-source-shebangs 'patch-cargo-checksums > > + (lambda _ > > + (use-modules (guix build cargo-utils)) > > + (let ((null-hash > > "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855")) >=20 > What is this null-hash? >=20 This is the "null-hash" that is also used in (gnu packages gnuzilla) > > + (substitute* '("Cargo.lock" "gfx/wr/Cargo.lock") > > + (("(\"checksum .* =3D )\".*\"" all name) > > + (string-append name "\"" null-hash "\""))) > > + (for-each > > + (lambda (filename) > > + (delete-file filename) > > + (let ((dir (dirname filename))) > > + (display (string-append > > + "patch-cargo-checksums: generate-checksu= ms for " > > + dir "\n")) > > + (generate-checksums dir))) > > + (find-files "third_party/rust" ".cargo-checksum.json")= )) > > + #t)) >=20 > Oh, there are a lot of things in third_party/rust=E2=80=A6 Can this be u= nbundled? >=20 We don't yet unbundle the crates used in icecat so I wouldn't consider it a blocker yet. On the other hand we do have a function for this in (guix build cargo-utils) which should be used. > > + ; Fixes issue where each installation directory generates its= own profile. > > + ; See e.g. https://trac.torproject.org/projects/tor/ticket/31= 457 > > + (add-after 'patch-source-shebangs 'fix-profile-setting > > + (lambda _ > > + (let ((mozconfigure "comm/mail/moz.configure")) > > + (substitute* mozconfigure > > + (("'MOZ_DEDICATED_PROFILES', True") > > + "'MOZ_DEDICATED_PROFILES', False"))))) >=20 > This phase needs to end on #t. >=20 > > + (replace 'configure > > + (lambda* (#:key outputs configure-flags #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (bash (which "bash")) > > + (abs-srcdir (getcwd)) > > + (srcdir (string-append "../" (basename abs-srcdir)= )) > > + (flags `(,(string-append "--prefix=3D" out) > > + ,@configure-flags)) > > + (mozconfig (string-append (getcwd) "/.mozconfig"))) > > + (setenv "SHELL" bash) > > + (setenv "AUTOCONF" > > + (string-append (assoc-ref %build-inputs > > + "autoconf") > > + "/bin/autoconf")) > > + (setenv "CONFIG_SHELL" bash) > > + (setenv "QA_CONFIGURE_OPTIONS" ".*") > > + (setenv "MOZBUILD_STATE_PATH" > > + (string-append (getcwd) "/mach_state")) > > + (setenv "MOZCONFIG" > > + (string-append (getcwd) "/.mozconfig")) > > + (setenv "CC" "gcc") > > + (setenv "MOZ_NOSPAM" "1") > > + (setenv "PYTHON" > > + (string-append (assoc-ref %build-inputs > > + "python2") > > + "/bin/python")) >=20 > Looks like Python 3 could be used instead. Have you tried that? >=20 > > + (delete-file-recursively "obj-x86_64-pc-linux-gnu") >=20 > Can this be deleted in a snippet or is this generated in some earlier > phase? Is the same directory generated on other architectures? >=20 I noticed this too. It should probably be generated per-architecture. > > + (zero? (system* "./mach" "configure"))))) >=20 > Please use (invoke =E2=80=A6) instead of (zero? (system* =E2=80=A6)). >=20 > > + (replace 'build > > + (lambda _ > > + (zero? (system* "./mach" "build")))) >=20 > Same here. >=20 > > + (replace 'install > > + (lambda _ > > + (zero? (system* "./mach" "install")))) >=20 > =E2=80=A6and here. >=20 > > + (add-after 'install 'wrap-program > > + (lambda* (#:key inputs outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (lib (string-append out "/lib")) > > + (gtk (assoc-ref inputs "gtk+")) > > + (gtk-share (string-append gtk "/share")) > > + (pulseaudio (assoc-ref inputs "pulseaudio")) > > + (pulseaudio-lib (string-append pulseaudio "/lib"))) > > + (wrap-program (car (find-files lib "^thunderbird$")) > > + `("XDG_DATA_DIRS" prefix (,gtk-share)) > > + `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib))) > > + #t)))))) >=20 > Why does thunderbird need wrapping with pulseaudio? >=20 > > + ("python" ,python) > > + ("python2" ,python-2.7) >=20 > See above. We may be able to use Python 3 here. >=20 > > + (home-page "https://www.thunderbird.net") > > + (synopsis "Trademarkless version of Mozilla Thunderbird") >=20 > Is the use of the name =E2=80=9CThunderbird=E2=80=9D a violation of Mozil= la=E2=80=99s trademark > policies? >=20 > -- > Ricardo >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --g3IWFuR7/O9KKcN6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl6p2bIACgkQQarn3Mo9 g1HnlRAAtFnZdwoEuBUR88Ftnc82e/s/qFj6RJ0veKt5EiT1MNV/QlKQLhbgjLRV U+QOqeOVC1g++HE6J8XV3f809NR5SEu3UoiLA4z51uR/gPDo+IJ4oKExQGpZ2/6e jYZ8QAoZjoUen75PqJpC9Afp8u4g8t4wl01D0ThJ9Sd8LLDQM+LMtYDiiY0J/s+W x1merPW3swrsj/1L2K7skbmxWJ43kZsUq7k9gfirOTdjJFNCAfj+E+UNCuVt6h9j t/MM3q7rutxHE1vxPewZM6ajKT2WmAUEVh++dNoQ65nL05X0YqkDGFCzBNENVctS KVrZTZW+Oux7JGYaxbz1elt+YaKgL8G//iUzQrYYKSTpFK6A8MzdbqEWyzcSb0Wb t4WWi65Q4MuoMP3aYwhVVimzs237UWwpiI1XB0f+ThaBpYKQkp1UXWGfI0a5lLIA 90KyoFL6ODlaynBXLi4osMitiNyLfoWtlXxmhcJMXepbvdk1a/6XuQF+7f5HgP90 9F8rSU8r/dRtJh9n84cBANDN5FPj0JyyzezVzNaxmNKaC8wIfBK4eGfU6AW4ZkDY h7xrHCi2A8Fbs7g4iOz7FD4DfgPh8PVliWQ7g3YdDmuQGzg0oyKwL9VnSZgVH2Ic OcduOtzriBEr51G1kBEtn6YOk8MzKEAQcaWuMljwcjlzxDM+uWE= =gi3S -----END PGP SIGNATURE----- --g3IWFuR7/O9KKcN6--