* [bug#40810] [PATCH] gnu: Add kbdd.
2020-04-24 7:20 [bug#40810] [PATCH] gnu: Add kbdd Boris A. Dekshteyn
@ 2020-04-27 21:50 ` Jakub Kądziołka
2020-04-28 2:09 ` [bug#40810] [PATCH] gnu: Add kbdd-0.7.1 Boris A. Dekshteyn
1 sibling, 0 replies; 4+ messages in thread
From: Jakub Kądziołka @ 2020-04-27 21:50 UTC (permalink / raw)
To: Boris A. Dekshteyn; +Cc: boris.dekshteyn, 40810
[-- Attachment #1: Type: text/plain, Size: 3293 bytes --]
On Fri, Apr 24, 2020 at 07:20:23PM +1200, Boris A. Dekshteyn wrote:
> ---
> gnu/packages/xdisorg.scm | 38 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
In your future patches, please include a ChangeLog-style line in the
body of the commit message. You can look at the commit history for some
examples. In the case of new packages, it's customary to write
* gnu/packages/xdisorg.scm (kbdd): New variable.
> +(define-public kbdd
> + (package
> + (name "kbdd")
> + (version "0.7.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/qnikst/kbdd/archive/v"
> + version ".tar.gz"))
> + (sha256
> + (base32 "0nhn7cx1z4k1kfll325xjr5a31zjc4h5h8q0wxa9svz8aihfxcqp"))
> + (file-name (string-append "kbdd" version))))
It's generally a bad idea to use GitHub's autogenerated tarball, since
it is occasionally regenerated, which changes the hash. See point 13 of
"(guix)Submitting Patches". This is also pointed out by `guix lint`,
please make sure to run it on your packages.
> + (build-system gnu-build-system)
> + (arguments
> + '(#:phases
> + (modify-phases %standard-phases
> + (add-before 'configure 'configure-fix
> + (lambda* _
> + (invoke "aclocal")
> + (invoke "automake" "--add-missing")
> + (invoke "autoreconf"))))))
I got surprised that this phase is necessary, as gnu-build-system
already includes the 'bootstrap phase. I tried removing it and the
package still builds. Was that not the case for you?
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("glib" ,glib "bin")))
> + (inputs
> + `(("glib" ,glib)
> + ("dbus-glib", dbus-glib)
> + ("libx11" ,libx11)))
Usually, alphabetical order is preferred unless there's a reason to
deviate.
> + (description "Kbdd is a simple keyboard layout manager.
> ++ Features: WM / DE independant, Written in plain C (only glib dependant),
> ++ has optional dbus interface")
The leading pluses almost certainly shouldn't be there. The description
is written somewhat oddly. When you're out of inspiration for a
description, you can adapt Debian's. In fact, the description used by
Debian made it much more clear to me why I'd want to use the package:
(synopsis "Per-window keyboard layout switching daemon for X")
(description "@command{kbdd} is a simple keyboard layout switching
program, which is designed to run in an X11 session and remember
keyboard layouts on a per-window basis. That can be very handy for a
user of a non-US keyboard who does not want to jump through layouts back
and forth while typing in terminals (mostly in a latin alphabet) and
some kind of chat (in native language).
@command{kbdd} also supports D-Bus signals, which makes it possible to
create layout indicator widgets.")
Thanks for your contributions! Would you mind sending an updated patch?
(To the same bug number, 40810@debbugs.gnu.org. Also, please CC me, as I
don't subscribe to the guix-patches mailing list.)
Regards,
Jakub Kądziołka
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [bug#40810] [PATCH] gnu: Add kbdd-0.7.1
2020-04-24 7:20 [bug#40810] [PATCH] gnu: Add kbdd Boris A. Dekshteyn
2020-04-27 21:50 ` Jakub Kądziołka
@ 2020-04-28 2:09 ` Boris A. Dekshteyn
2020-04-28 10:05 ` bug#40810: " Jakub Kądziołka
1 sibling, 1 reply; 4+ messages in thread
From: Boris A. Dekshteyn @ 2020-04-28 2:09 UTC (permalink / raw)
To: 40810; +Cc: Boris A. Dekshteyn
* gnu/packages/xdisorg.scm (kbdd): New variable.
---
gnu/packages/xdisorg.scm | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index bc2c9c4622..9edd46e889 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -2286,3 +2286,40 @@ to find all available clips and launches @command{dmenu} (or @command{rofi},
depending on the value of @code{CM_LAUNCHER}) to let the user select a clip.
After selection, the clip is put onto the PRIMARY and CLIPBOARD X selections.")
(license license:public-domain))))
+
+(define-public kbdd
+ (package
+ (name "kbdd")
+ (version "0.7.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/qnikst/kbdd.git")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0qkq75grbd4wkx4nlvswgavpijk9ad0pzqyj89a0ayjsbsn36pqy"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("glib" ,glib "bin")
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("dbus-glib", dbus-glib)
+ ("glib" ,glib)
+ ("libx11" ,libx11)))
+ (home-page "https://github.com/qnikst/kbdd")
+ (synopsis "Per-window keyboard layout switching daemon for X")
+ (description "@command{kbdd} is a simple keyboard layout switching
+program, which is designed to run in an X11 session and remember
+keyboard layouts on a per-window basis. That can be very handy for a
+user of a non-US keyboard who does not want to jump through layouts back
+and forth while typing in terminals (mostly in a latin alphabet) and
+some kind of chat (in native language).
+
+@command{kbdd} also supports D-Bus signals, which makes it possible to
+create layout indicator widgets.")
+ (license license:bsd-2)))
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread