unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: "Boris A. Dekshteyn" <harlequin78@gmail.com>
Cc: boris.dekshteyn@google.com, 40812@debbugs.gnu.org
Subject: [bug#40812] [PATCH] gnu: herbstluftwm: update to 0.8.1
Date: Sun, 26 Apr 2020 18:33:40 +0200	[thread overview]
Message-ID: <20200426163340.scv6ih3l5up3bpha@gravity> (raw)
In-Reply-To: <20200424072106.32741-1-boris.dekshteyn@google.com>

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

On Fri, Apr 24, 2020 at 07:21:06PM +1200, Boris A. Dekshteyn wrote:
> @@ -169,13 +169,21 @@ the leaves of a full binary tree.")
>         ("xsetroot"    ,xsetroot)
>         ("libx11"      ,libx11)
>         ("libxext"     ,libxext)
> -       ("libxinerama" ,libxinerama)))
> +       ("libxrandr"   ,libxrandr)
> +       ("libxinerama" ,libxinerama)
> +       ("bash"        ,bash)))

May I ask why you added bash to the dependencies? In my tests the
package builds fine when I remove this line. Apart from this, LGTM.

Thanks for your patch!
Jakub Kądziołka

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-04-26 16:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24  7:21 [bug#40812] [PATCH] gnu: herbstluftwm: update to 0.8.1 Boris A. Dekshteyn
2020-04-26 16:33 ` Jakub Kądziołka [this message]
2020-04-27 16:08 ` bug#40812: " Jakub Kądziołka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200426163340.scv6ih3l5up3bpha@gravity \
    --to=kuba@kadziolka.net \
    --cc=40812@debbugs.gnu.org \
    --cc=boris.dekshteyn@google.com \
    --cc=harlequin78@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).