unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Raghav Gururajan <raghavgururajan@disroot.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: 40753@debbugs.gnu.org
Subject: [bug#40753] gnu: spacefm: Add missing dependencies.
Date: Wed, 22 Apr 2020 12:28:33 -0400	[thread overview]
Message-ID: <20200422122833.076c8a60.raghavgururajan@disroot.org> (raw)
In-Reply-To: <87ftcw81bl.fsf@gnu.org>

Hi Jan!

> > BLOCKERS: #40630 and #40752.  
> 
> ...what does this mean?

They are dependencies of this patch, that needs to be pushed before this patch.

> It builds OK without this patch; it does not seem that any dependencies
> are missing.  Could it be that these dependencies change or amend its
> behaviour?

It is to change and amend the behaviour. It adds missing features and fixes
icons+privilege-management+disk-management.

> After applying this patch, spacefm does not build for me, I get
> 
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix build spacefm
> ice-9/eval.scm:223:20: In procedure proc:
> error: eject: unbound variable
> hint: Did you forget a `use-modules' form?
> --8<---------------cut here---------------end--------------->8---

That's correct. Eject is provided by one of the blockers.

> I am feeling a bit uncomfortable about the fact that you pinged me to
> "push" this patch, it seems it needs a bit more attention than that.

I apologize. I spent whole day to create these patches and throughly testing
them. If I missed anything, please understand it would not have been
intentional. Also, there is a v2 patch in #40753 thread that has 3 blockers.

Thank you for considering my request.

Regards,
RG.

  reply	other threads:[~2020-04-22 16:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 21:28 [bug#40753] gnu: spacefm: Add missing dependencies Raghav Gururajan
2020-04-22  0:15 ` [bug#40753] gnu: spacefm: Add and configure missing dependencies. (v2) Raghav Gururajan
2020-04-22  6:46 ` [bug#40753] gnu: spacefm: Add missing dependencies Jan Nieuwenhuizen
2020-04-22 16:28   ` Raghav Gururajan [this message]
2020-04-22 17:59     ` Jan Nieuwenhuizen
2020-04-22 20:22       ` [bug#40753] gnu: spacefm: Add missing dependencies. (v3) Raghav Gururajan
2020-04-24 19:35 ` [bug#40753] gnu: spacefm: Add dependencies for extra functionality. (v3) Raghav Gururajan
2020-04-24 20:09   ` Jan Nieuwenhuizen
2020-04-26  2:11     ` [bug#40753] gnu: spacefm: Add dependencies for extra functionality Raghav Gururajan
2020-04-26 14:00       ` Jan Nieuwenhuizen
2020-04-27  6:29         ` Raghav Gururajan
2020-04-27  6:38           ` Efraim Flashner
2020-04-27  8:42             ` Jan Nieuwenhuizen
2020-04-28  9:11               ` Raghav Gururajan
2020-04-30 13:57                 ` Raghav Gururajan
2020-05-30  5:08                   ` bug#40753: " Maxim Cournoyer
2020-04-27  8:37           ` [bug#40753] " Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200422122833.076c8a60.raghavgururajan@disroot.org \
    --to=raghavgururajan@disroot.org \
    --cc=40753@debbugs.gnu.org \
    --cc=janneke@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).