unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 40680-done@debbugs.gnu.org
Subject: bug#40680: [PATCH] service: sddm: Have sddm-service-type conflict with other display managers.
Date: Sun, 19 Apr 2020 09:07:29 +0300	[thread overview]
Message-ID: <20200419060729.GB939@E5400> (raw)
In-Reply-To: <87h7xg4bf0.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

On Sun, Apr 19, 2020 at 01:33:07AM +0200, Ludovic Courtès wrote:
> Hi,
> 
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > On Fri, Apr 17, 2020 at 11:00:49PM +0200, Ludovic Courtès wrote:
> 
> [...]
> 
> >> > --- a/gnu/services/sddm.scm
> >> > +++ b/gnu/services/sddm.scm
> >> > @@ -171,6 +171,7 @@ Relogin="              (if (sddm-configuration-relogin? config)
> >> >           (documentation "SDDM display manager.")
> >> >           (requirement '(user-processes))
> >> >           (provision '(display-manager))
> >> > +         (conflicts-with '(xorg-server))
> >> 
> >> ‘conflicts-with’ doesn’t exist, right?  :-)
> >> 
> >
> > I haven't tried it out for Guix services, but it exists for shepherd
> > services, according to the manual¹
> 
> Right, it’s not available in Guix <shepherd-service>.
> 
> However, simplify adding ‘xorg-server’ to ‘provision’ should have the
> desired effect: ‘guix system’ errors out if more than one service
> provides the same symbol.
> 
> >> But yes, I think (provision '(xorg-server display-manager)) would be
> >> fine.
> >> 
> >> Or we can even drop ‘display-manager’ since it’s not used anywhere else.
> >
> > Normally I'd be skeptical about dropping it since people might expect it
> > if they're using sddm, but it'd probably be fine.
> 
> Yeah, maybe it’s safer to keep it.
> 
> Thanks,
> Ludo’.

Sounds good. I put xorg-server first so it more closely matches with the
other ones.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-04-19  6:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 14:41 [bug#40680] [PATCH] service: sddm: Have sddm-service-type conflict with other display managers Efraim Flashner
2020-04-17 21:00 ` Ludovic Courtès
2020-04-18 18:01   ` Efraim Flashner
2020-04-18 23:33     ` Ludovic Courtès
2020-04-19  6:07       ` Efraim Flashner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200419060729.GB939@E5400 \
    --to=efraim@flashner.co.il \
    --cc=40680-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).