From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:48587) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPSYB-0002MS-QX for guix-patches@gnu.org; Fri, 17 Apr 2020 11:05:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPSYA-0000cC-IX for guix-patches@gnu.org; Fri, 17 Apr 2020 11:05:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58133) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPSYA-0000c5-Ef for guix-patches@gnu.org; Fri, 17 Apr 2020 11:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jPSYA-0000KK-9m for guix-patches@gnu.org; Fri, 17 Apr 2020 11:05:02 -0400 Subject: [bug#36599] [PATCH] gnu: Add node-semver. (Updated) Resent-Message-ID: Date: Fri, 17 Apr 2020 18:03:52 +0300 From: Efraim Flashner Message-ID: <20200417150352.GB9867@E5400> References: <20190711121221.16123-1-goodoldpaul@autistici.org> <0dc7cf533fa5aa29a12e7b1da9532869@autistici.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yEPQxsgoJgBvi8ip" Content-Disposition: inline In-Reply-To: <0dc7cf533fa5aa29a12e7b1da9532869@autistici.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: goodoldpaul@autistici.org Cc: julien@lepiller.eu, 36599@debbugs.gnu.org --yEPQxsgoJgBvi8ip Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 17, 2020 at 02:54:43PM +0000, goodoldpaul@autistici.org wrote: > Hi Julien, >=20 > > Does npm install the test.js files when run by ittself (in which case we > > replicate its behavior), or does it have a mechanism to know what files > > to install? If so we thould replicate that mecanism. >=20 > On my system I get >=20 > giacomo@frarch /tmp$ npm i semver > npm WARN saveError ENOENT: no such file or directory, open > '/tmp/package.json' > npm WARN enoent ENOENT: no such file or directory, open '/tmp/package.jso= n' > npm WARN tmp No description > npm WARN tmp No repository field. > npm WARN tmp No README data > npm WARN tmp No license field. >=20 > + semver@7.3.2 > added 1 package and audited 1 package in 0.626s > found 0 vulnerabilities >=20 > giacomo@frarch /tmp$ ls -l node_modules/semver/ > total 48 > drwxr-xr-x 2 giacomo giacomo 60 Apr 17 16:43 bin/ > -rw-r--r-- 1 giacomo giacomo 2257 Oct 26 1985 CHANGELOG.md > drwxr-xr-x 2 giacomo giacomo 120 Apr 17 16:43 classes/ > drwxr-xr-x 2 giacomo giacomo 520 Apr 17 16:43 functions/ > -rw-r--r-- 1 giacomo giacomo 1982 Oct 26 1985 index.js > drwxr-xr-x 2 giacomo giacomo 120 Apr 17 16:43 internal/ > -rw-r--r-- 1 giacomo giacomo 765 Oct 26 1985 LICENSE > -rw-r--r-- 1 giacomo giacomo 1645 Apr 17 16:43 package.json > -rw-r--r-- 1 giacomo giacomo 69 Oct 26 1985 preload.js > -rw-r--r-- 1 giacomo giacomo 619 Oct 26 1985 range.bnf > drwxr-xr-x 2 giacomo giacomo 260 Apr 17 16:43 ranges/ > -rw-r--r-- 1 giacomo giacomo 22109 Oct 26 1985 README.md >=20 > so I believe that npm uses the "files" key [0] in package.json to decide > what to install. >=20 Thanks for looking into it. > I'm definitely available to implement that but it could take a week or tw= o, > if we feel it should be changed right away I'm probably not the best pers= on > to do that. >=20 > What do you think? Should I open another issue about this? I think we should fix it, but it shouldn't block getting your package into Guix. Go ahead and open a new issue for it. >=20 > Giacomo >=20 > [0]: https://github.com/npm/node-semver/blob/master/package.json#L21 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --yEPQxsgoJgBvi8ip Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl6ZxVUACgkQQarn3Mo9 g1Ez5BAArRBvyE2TGRBggNLZZVUQaRF4enl2LNu68WyLc4dTVyWXnYJVdDSP4yu8 44LIfEbvGuknJrAMLzRFVDrMIkbzaT4GWbhyoWHb/SeCZrZrXWIoBIXo24xEbzHM jIu3vLSyPDFNvLwp7pqzZEE9IleM/Q/CSNo1UvR/TzOTP7qGu82GBK92lln85Quv ijLpKXl+ESzRAHaCJCGT3FOuU2/G6C3o3T5uZkA44zK9kbuo+kqcr6+E8xjskGN6 N90q5f49osNm4kI1cO0Oxf95TYezrIliAIQ4LtSBDeNehpyONqBr7e1qKqZN5O2F W96KfyxNpi8DmqpUhl1sC0rJjJ/PoZam5hRZX1Z255Oad0hBviscMqkLTN2SrmJV Y8lCG8vs+XLODA9Ij4EOMrdlXmic6vJE2iIIz7tcFSGL8HngRfeoHEoFp2E8mgYZ PWqqGaKfhwOf5RZ8rXvOnR7dnzlG8Sg2VI8lQWY3tOxYETowAxacfmk5VgVJ9y42 cYzAIfKTsQoja8uGAru0eYIbhalJlUlc5bgsBHmYp3zMYgNGYoP4Rzz8rPbzs7d+ kuU1uhoXxj7xR7oYN+MSQeqIUMtldNIDnxo2y/kxp7Qh6Rw9RjaeUlA3gdfJGTvh RyYWt+pNHquvnqxFD5POTCtVETNyLYPv7YyeOHxKV2PySp4Crgs= =q62H -----END PGP SIGNATURE----- --yEPQxsgoJgBvi8ip--