From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:35279)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMCr1-0007na-9Y
 for guix-patches@gnu.org; Wed, 08 Apr 2020 11:43:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMCr0-0000VN-7q
 for guix-patches@gnu.org; Wed, 08 Apr 2020 11:43:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41281)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jMCr0-0000VA-1I
 for guix-patches@gnu.org; Wed, 08 Apr 2020 11:43:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jMCqz-0001Ec-W2
 for guix-patches@gnu.org; Wed, 08 Apr 2020 11:43:01 -0400
Subject: [bug#40468] [PATCH 3/3] gnu: Add shiru-lv2.
Resent-Message-ID: <handler.40468.B40468.15863605254680@debbugs.gnu.org>
Date: Wed, 8 Apr 2020 11:41:55 -0400
From: Leo Famulari <leo@famulari.name>
Message-ID: <20200408154155.GA26684@jasmine.lan>
References: <053db596207697e4b7d32b55a965b2ba88beca75.camel@zrythm.org>
 <e43d20b120dd66887e587ac9d157dd7d7df4e411.camel@zrythm.org>
 <20200407182511.GA9039@jasmine.lan>
 <224c908df7cf2e32dff2bd31e5050dd4d552093a.camel@zrythm.org>
 <20200407194138.GA14915@jasmine.lan>
 <1fe07e3677e852cd9d502b68e4659879fc21e6b0.camel@zrythm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1fe07e3677e852cd9d502b68e4659879fc21e6b0.camel@zrythm.org>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 40468@debbugs.gnu.org

On Tue, Apr 07, 2020 at 09:04:40PM +0100, Alexandros Theodotou wrote:
> This is supposed to be merged after those changes. The first patch
> (40466) changes the install procedure in dragonfly-reverb, which is
> inherited here.

In general, I think that using syntactic inheritance to factorize build
phases is not the right way to go here. It can cause a big headache
later when the time comes to adjust things, and it removes the
advantages of Guix tools such as `guix graph` and `guix refresh`.

I think the better options are to create a new lv2-build-system that
inherits from gnu-build-system and replaces the install phase, or to
just copy and paste the code around. It depends on how many of these
packages we plan to add.

Let me know if you need help with any of that! The font-build-system is
a concise example of making a new build system based on the
gnu-build-system.