From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36177) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKJRf-0005Ne-IK for guix-patches@gnu.org; Fri, 03 Apr 2020 06:21:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKJRe-0002yq-De for guix-patches@gnu.org; Fri, 03 Apr 2020 06:21:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57882) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKJRe-0002yd-Ay for guix-patches@gnu.org; Fri, 03 Apr 2020 06:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jKJRe-0000XQ-5P for guix-patches@gnu.org; Fri, 03 Apr 2020 06:21:02 -0400 Subject: [bug#40274] [PATCH v5] gnu: Add kernel-module-loader-service. Resent-Message-ID: Date: Fri, 3 Apr 2020 12:20:44 +0200 From: Danny Milosavljevic Message-ID: <20200403122044.2f9e2552@scratchpost.org> In-Reply-To: <2b32956fc10fd3012388722e1b00ce21@waegenei.re> References: <20200328135908.2540-1-brice@waegenei.re> <20200402123712.338-1-brice@waegenei.re> <20200402155640.121e4879@scratchpost.org> <2b32956fc10fd3012388722e1b00ce21@waegenei.re> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/B9hFx6KpkqGUyz.XmQ+2b+R"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Brice Waegeneire Cc: ludo@gnu.org, 40274@debbugs.gnu.org --Sig_/B9hFx6KpkqGUyz.XmQ+2b+R Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Brice, On Thu, 02 Apr 2020 17:13:05 +0000 Brice Waegeneire wrote: > *could* be useful, to some, to pass arguments to modprobe since it is > present in its API;=20 Definitely could be useful. The question is whether the complexity justifi= es it and whether it can be reliable. > Should I just go back to the first format, with just a list of module > names, and we merge this patch?=20 I would like that more since it's very improbable to ever need changing. >Or would it be better, regarding the=20 > user > interface, to start this patch anew by using `modprobe.d` API as a base. > By that I mean defining a `modprobe-service-type` which populates > `/etc/modprobe.d/` and can manually load a module at boot if needed=20 > (like > kernel-module-loader does)? Would it be overkill? Following is an=20 > example of > what such service could look like: I think the two things (loading a module and configuring a module) can be seperate, so I wouldn't mix it. For example why would you load a module before the service that needs it actually starts up (if ever)? That just increases the attack surface=20 for no reason. On the other hand, module configuration will probably be done as part of some guix service presence--used or not. That said, maybe there are upsides to--among other things easier-understand= able configuration if it's central. > #+begin_src scheme > (service modprobe-service-type > (list (modprobe-entry > (module "ddcci") > (load? #t) > (options '("dyndbg" "delay=3D120")) > (alises '("ddc/ci")) > (install "") ; default > (remove "")) ; default > (modprobe-entry > (module "acpi-call") > (blacklist? #t)))) A service to do that would still be nice. But maybe "kernel-module-configuration-service" ? (Please don't think I have all the answers, let's see which way is better) --Sig_/B9hFx6KpkqGUyz.XmQ+2b+R Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6HDfwACgkQ5xo1VCww uqUsAAgAob3KNEkmMLjYLY1uztGTqcAPd1mv51woMd5x9aaQtwYvgBBWzDXSl6nL 2y7kM6AbtVxPSSrqlvZFk0OMZvqOJfq7oz/vBsyPFGJCVD9vISZqi0CyYgC9sRCq DoWIUc6Wvo2+hTGEvTabamitaIFIgyJfkm0UUsyXq7X13NqiS04ReCwabUbbRu0H YS+7a2CBJ2WvWmHhgANr7BTVNNlrPEdu4KWKFcB/NppSCjAnJfMF7VcQYlBxZDQ+ 9iRM9hBPAgNNAnS6KbROyZYcGzPEKE7T4mk3WlinF2CvlQ/pEzDuiDlbeYWOqgxL KeVAm4/pDTssRfVwKYcbAeR//4RYUg== =jwhD -----END PGP SIGNATURE----- --Sig_/B9hFx6KpkqGUyz.XmQ+2b+R--