From: R Veera Kumar <vkor@vkten.in>
To: 40209@debbugs.gnu.org
Subject: [bug#40209] [PATCH v4] gnu: Add qiv.
Date: Wed, 1 Apr 2020 06:37:03 +0530 [thread overview]
Message-ID: <20200401010703.GA3180@tulip> (raw)
In-Reply-To: <20200324093627.GB3208@tulip>
* gnu/packages/image-viewers.scm (qiv): New variable.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
Changes in v4:
- Make install check pass by setting up Xvfb for test
- Patch Makefile so that qiv runs and exits by itself during test
- Make proper guile comments
Changes in v3:
- Commit msg as per changelog format.
- Change quasi quote to normal in modify phases 'configure
- Add lcms2 and jpeg support
Changes in v2:
- Add into image-viewers instead of separate
- Add reason for no make check as comments
- Correct indentation using indent-code.el
---
gnu/packages/image-viewers.scm | 55 ++++++++++++++++++++++++++++++++++
1 file changed, 55 insertions(+)
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 8f3f61c4b1..6bbbf2a3b0 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -13,6 +13,7 @@
;;; Copyright © 2019 Guy Fleury Iteriteka <hoonandon@gmail.com>
;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
;;; Copyright © 2020 Peng Mei Yu <pengmeiyu@riseup.net>
+;;; Copyright © 2020 R Veera Kumar <vkor@vkten.in>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -596,3 +597,57 @@ with tiling window managers. Features include:
@end itemize\n")
(home-page "https://github.com/eXeC64/imv")
(license license:expat)))
+
+(define-public qiv
+ (package
+ (name "qiv")
+ (version "2.3.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "http://spiegl.de/qiv/download/qiv-"
+ version ".tgz"))
+ (sha256
+ (base32 "1rlf5h67vhj7n1y7jqkm9k115nfnzpwngj3kzqsi2lg676srclv7"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ;; for testing
+ ("xorg-server" ,xorg-server-for-tests)))
+ (inputs
+ `(("imlib2" ,imlib2)
+ ("glib" ,glib)
+ ("gtk+" ,gtk+-2)
+ ("lcms" ,lcms)
+ ("libjpeg" ,libjpeg)
+ ("libtiff" ,libtiff)
+ ("libexif" ,libexif)
+ ("libx11" ,libx11)
+ ("libxext" ,libxext)))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (delete 'configure) ; no configure script
+ (add-before 'install 'patch-file-start-xserver
+ (lambda* (#:key inputs #:allow-other-keys)
+ ;; patch the file so that qiv runs and exits by itself
+ (substitute* "Makefile"
+ (("./qiv -f ./intro.jpg") "./qiv -f -C -s ./intro.jpg"))
+ (let ((xorg-server (assoc-ref inputs "xorg-server")))
+ ;; There must be a running X server and make install doesn't start one.
+ ;; Therefore we must do it.
+ (system (format #f "~a/bin/Xvfb :1 &" xorg-server))
+ (setenv "DISPLAY" ":1") ) #t)))
+ #:tests? #f ; there is no check target
+ #:make-flags
+ (list
+ (string-append "PREFIX=" (assoc-ref %outputs "out")))))
+ (home-page "http://spiegl.de/qiv/")
+ (synopsis "Graphical image viewer for X")
+ (description
+ "Quick Image Viewer is a small and fast GDK/Imlib2 image viewer.
+Features include zoom, maxpect, scale down, fullscreen, slideshow, delete,
+brightness/contrast/gamma correction, pan with keyboard and mouse, flip,
+rotate left/right, jump/forward/backward images, filename filter and use it
+to set X desktop background.")
+ (license license:gpl2)))
--
2.26.0
next prev parent reply other threads:[~2020-04-01 1:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 9:36 [bug#40209] [PATCH] gnu: qiv: Add qiv image viewer for X R Veera Kumar
2020-03-24 10:33 ` [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an " R Veera Kumar
2020-03-24 12:04 ` Danny Milosavljevic
2020-03-25 8:08 ` [bug#40209] [PATCH v2] gnu: image-viewers: " R Veera Kumar
2020-03-31 13:38 ` Danny Milosavljevic
2020-03-31 11:03 ` [bug#40209] [PATCH v3] gnu: Add qiv R Veera Kumar
2020-03-31 11:17 ` Danny Milosavljevic
2020-03-31 11:53 ` R Veera Kumar
2020-04-01 1:07 ` R Veera Kumar [this message]
2020-04-01 10:20 ` bug#40209: [PATCH v4] " Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401010703.GA3180@tulip \
--to=vkor@vkten.in \
--cc=40209@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).