From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:51801)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIs0V-0007Zg-5V
 for guix-patches@gnu.org; Mon, 30 Mar 2020 06:51:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIs0U-0000lM-AH
 for guix-patches@gnu.org; Mon, 30 Mar 2020 06:51:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:49468)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jIs0U-0000l9-6V
 for guix-patches@gnu.org; Mon, 30 Mar 2020 06:51:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jIs0U-0003bQ-5Z
 for guix-patches@gnu.org; Mon, 30 Mar 2020 06:51:02 -0400
Subject: [bug#40320] [PATCH 2/2] gnu: Add qalculate-gtk
Resent-Message-ID: <handler.40320.B40320.158556541713782@debbugs.gnu.org>
Date: Mon, 30 Mar 2020 12:50:13 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20200330125013.54640bbc@scratchpost.org>
In-Reply-To: <e8055db728ed9ac1655d91d17e5dfae6407c7e4b.1585545646.git.vkor@vkten.in>
References: <c7ae76e80872ed303cbc0c8e8216f56ea7061d8e.1585545646.git.vkor@vkten.in>
 <e8055db728ed9ac1655d91d17e5dfae6407c7e4b.1585545646.git.vkor@vkten.in>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/n4cfXHO+ZqLAWH5/GmsH2+e";
 protocol="application/pgp-signature"; micalg=pgp-sha256
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: R Veera Kumar <vkor@vkten.in>
Cc: 40320@debbugs.gnu.org

--Sig_/n4cfXHO+ZqLAWH5/GmsH2+e
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

> +  (let ((commit "87f78ab3d7ed0dedf56edc38242d559ac07b1330")
> +        (revision "1"))
> +    (package
> +      (name "qalculate-gtk")
> +      (version (git-version "3.8.0" revision commit))

Same as in libqalculate, please use the git tag "v3.8.0" instead.

> +         ("automake" ,automake)
> +         ("autoconf" ,autoconf)

Why?

> +           (add-before 'check 'update-po-files ;; to pass po check

Please use just one semicolon for this kind of comment.
Maybe also include the error message one would get otherwise, as a comment.

> +             (lambda _
> +               (with-output-to-file "po/POTFILES.skip"
> +                 (lambda _ (format #t "data/shortcuts.ui~%"))))))))

Please end the phase in #t.

--Sig_/n4cfXHO+ZqLAWH5/GmsH2+e
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6BzuUACgkQ5xo1VCww
uqVduwgAkYehLthJLAr7GuN8NyRAfOQU7A2ENKwaOFeEH0GHpPT7C+8orgZXIFbe
CJqcY58QNzUsYctykCZYaOQ0tl4bzWvOnZkEu2Yoe0+qPhZ9V6EqSA59tQmlxaIC
RUi7/EKaiUIJWXICm3IGnoqV0SPZIAHIoycPeL863TEtoluzsxXr393NgIoXTVpI
PaPaMr4Rx4+NiZhwQUoyBfPWvA7lJyDntAVq9Y+6wzUMECrT6J3fe0B7ywmT/PPn
r5W2iosl0zbcoTvheQAj4fUgfSSt+uo6/vuQHYw5m7uGJztozjMDKm1xHvpKg0oC
TF53VwVal4dXKJbQZRfIiJI91fFvOQ==
=MN26
-----END PGP SIGNATURE-----

--Sig_/n4cfXHO+ZqLAWH5/GmsH2+e--