From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:51001) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIrvf-0005MF-Vv for guix-patches@gnu.org; Mon, 30 Mar 2020 06:46:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIrvd-0003ME-Po for guix-patches@gnu.org; Mon, 30 Mar 2020 06:46:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49464) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIrvd-0003Lz-Lo for guix-patches@gnu.org; Mon, 30 Mar 2020 06:46:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jIrvd-0003TT-Ks for guix-patches@gnu.org; Mon, 30 Mar 2020 06:46:01 -0400 Subject: [bug#40320] [PATCH 1/2] gnu: Add libqalculate Resent-Message-ID: Date: Mon, 30 Mar 2020 12:45:39 +0200 From: Danny Milosavljevic Message-ID: <20200330124539.79f6568a@scratchpost.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/zFC4sBoJOGbrRhILJWzmX0n"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: R Veera Kumar Cc: 40320@debbugs.gnu.org --Sig_/zFC4sBoJOGbrRhILJWzmX0n Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Veera, thanks for the patch! I have a few suggestions: On Mon, 30 Mar 2020 10:52:23 +0530 R Veera Kumar wrote: > +(define-public libqalculate > + (let ((commit "90b52e685c1b0575558c5dd449dde71c313d084a") > + (revision "1")) According to github[1], this seems to be the tag "v3.8.0". > + (version (git-version "3.8.0" revision commit)) ... so please just use (version "3.8.0") > + (commit commit) ... and (commit (string-append "v" version)) > + ("automake" ,automake) > + ("autoconf" ,autoconf) It's unusual to need those in a release. Why are they necessary? > + (arguments > + `( #:phases > + (modify-phases %standard-phases > + (delete 'bootstrap) ;; fails in autogen.sh > + (add-before 'configure 'autogen Why not just (replace 'bootstrap ... ) ? >+ (synopsis "Multi-purpose cli desktop calculator and library") > + (description > + "Libqalculate is a multi-purpose cli desktop calculator and libra= ry. > +It provides basic and advanced functionality. Features include customiz= able > +functions, unit calculations, and conversions, physical constants, symbo= lic > +calculations (including integrals and equations), arbitrary precision, > +uncertainity propagation, interval arithmetic, plotting and a user-frien= dly > +cli.") Maybe mention that this is the library, not the program. [1] https://github.com/Qalculate/libqalculate/releases --Sig_/zFC4sBoJOGbrRhILJWzmX0n Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6BzdMACgkQ5xo1VCww uqUfMQf/bhwNy+i8VnzV87LgCDAhI1ZUHVUYurPI98ls462W1CcV54tb7SGuF26q oEyqnWi7ZLudzj0i0SDj1lB+2m/p2JSoFeMkoGKQgH6Uqhy42Um4W15jiM8Nlm3B tBYIwIAgBZAHCPUOcSw4O/uEs+Ff0InYIW9jALcXK8quowJe19Yy+cLythunLTXK xA/gTY15mGRrKEmK3SwBB+wRZMvj/m2mz5/xRFrDnfG+D4NfhhvRE9DHJq+cS9+R IwTdvWIix2vWlTcFZZs8Vq6QtCWQEAl84JBDVas/nsVTOgPhHx8H7RCASryX0Liv A4Ton2JYOF0yJ/xG8fOV+Oo7gWEecA== =jW1M -----END PGP SIGNATURE----- --Sig_/zFC4sBoJOGbrRhILJWzmX0n--