From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34500) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIq5U-0002qg-7v for guix-patches@gnu.org; Mon, 30 Mar 2020 04:48:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIq5S-00069N-Su for guix-patches@gnu.org; Mon, 30 Mar 2020 04:48:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIq5S-00068P-Oo for guix-patches@gnu.org; Mon, 30 Mar 2020 04:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jIq5R-00006D-NZ for guix-patches@gnu.org; Mon, 30 Mar 2020 04:48:01 -0400 Subject: [bug#40288] [PATCH 1/1] gnu: Add lxqt-organizer. Resent-Message-ID: Date: Mon, 30 Mar 2020 11:46:30 +0300 From: Efraim Flashner Message-ID: <20200330084630.GB5436@E5400> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PmA2V3Z32TCmWXqI" Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Hamzeh Nasajpour Cc: 40288@debbugs.gnu.org --PmA2V3Z32TCmWXqI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I didn't realize we had so much of lxqt packaged. Some comments inline: On Sat, Mar 28, 2020 at 09:11:06PM +0430, Hamzeh Nasajpour wrote: > * gnu/packages/lxqt.scm (lxqt-organizer): New variable. > --- > gnu/packages/lxqt.scm | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) >=20 > diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm > index a440491633..7ef6ca51ce 100644 > --- a/gnu/packages/lxqt.scm > +++ b/gnu/packages/lxqt.scm > @@ -1269,6 +1269,40 @@ QTermWidget.") > easily publishing them on internet image hosting services.") > (license license:gpl2+))) > =20 > +(define-public lxqt-organizer > + (package > + (name "lxqt-organizer") > + (version "v0.003") The author seems to be using this time to do some rapid development and has already (at the time I checked) already bumped the version to v0.6.0. Can you update to the most recent version? > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url (string-append "https://github.com/lxqt/organizer.gi= t")) > + (commit "5aa556aa0f0409e00fac5b63d9118ff228d2e840") > + (recursive? #t))) I was going to mention using the version string for the commit but it seems they haven't pushed any tags to the repo. Can you add a comment saying they haven't tagged any releases in git? Also, it doesn't look like there are any submodules so you don't need 'recursive? #t' > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1czs9gca7aqsfcnxhi7nzq97pxbmhfgbfh00j7nl8cig0yxb6apv"= )))) > + (build-system cmake-build-system) > + (inputs > + `(("kwindowsystem" ,kwindowsystem) > + ("liblxqt" ,liblxqt) > + ("libqtxdg" ,libqtxdg) > + ("qtbase" ,qtbase) > + ("qtsvg" ,qtsvg) > + ;;("qtlinguist" ,qttools) > + ("qtx11extras" ,qtx11extras))) guix gc --references /path/to/item doesn't list all the inputs, so many of them can actually be moved to native-inputs. > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("lxqt-build-tools" ,lxqt-build-tools) > + ("qttools" ,qttools))) > + (arguments > + '(#:tests? #f)) I saw that there were no tests in the repo, please add a note. > + (home-page "https://lxqt.org/") Is there a project-specific home-page? If not I'd recommend just using the github repo as the home-page. > + (synopsis "LXQt Organizer is a lightweight organizer for personal in= formation management.") Perhaps: "LXQt desktop organizer" or "LXQt organizer for personal information management" Actually the second sounds clunky. "LXQt personal information management organizer" > + (description > + "This package provides a Qt-based application for managing meetings= , events and other personal information.") > + (license license:lgpl2.1+))) > =20 > (define-public lxqt-archiver > (package > --=20 > 2.25.1 >=20 In addition, in the desktop file (in %out/share/application/) there's a second exec line which starts /usr/local/lxqt-organizer. Can you add a phase to patch that? Also, 'guix lint' complains about the length of two of the lines and about the period in the synopsis. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --PmA2V3Z32TCmWXqI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl6BseMACgkQQarn3Mo9 g1HfbA/9FQQ9NZmz6qwuWQmFc7uuH/CuwP65hnFswDTXlZGYPl3wnZYQlW5gCIsD 8QSkoXJK4sDGw/tW+RQMlY1i1TVHDuPrCHH5W/EossgQ722DXdxD8IzNeKIa8cxX xcIBWiStDBXNh6Yy/3CPpEh/ByaYMPACmAjvoBzXfN7kZ2D+ZQLbBBUOF4TRFGEi G81PqxloCWC0Xog7gu22dAxQsV+d1W35Kwj6tQ+2ENoDli8jDD+VsSolxx3S+Sx/ 2d5Ci16llFl5iJGaP0UdHCcLhAUgHrxkSqVFaXIgQL3kL8sj0ty++4GFMpPtUohM oOkiF2S/jEHuEnHUKL7yoF3FQN1aA7qNxTEUuBcQPqgJ/PafxrEYUHt2/vzTaPGE 11b8fj5VooiJPT4r1JE7OBRzv0Q11cdP+xUW7rKLt84YeKBBMFC1xjNJZmq8kaez 9bKEeyIKHENb5YLJwmqduBUZYF2pS17nxqOwOluPtZuJ1by8Me8gDQL2KjX7cia9 0d6NAFnQoU2i8P784I56M3CK3jwcYHDL0YI86nqaz0vaQ8h2blVKvr0zBtm/ni8N Nv4iBTvyDEn3sQWr70M8r1ujN4vf3X8d5z0fZVmpL5X9I0A0QaMOoGWQcah4Oa/L lxd+7kpkHmJCj7zqPvNF/4hsrtIZTAaotdoSBksxluKQtuOXEhY= =CJog -----END PGP SIGNATURE----- --PmA2V3Z32TCmWXqI--