unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 40105-done@debbugs.gnu.org
Subject: bug#40105: [PATCH] gnu: Add wol.
Date: Sun, 29 Mar 2020 00:09:35 +0100	[thread overview]
Message-ID: <20200328230935.7tqjyjazm55pv3fr@gravity> (raw)
In-Reply-To: <CAEwRq=rtcoaKA5PYNyiZrMKdLhOGc3SWUwCjKWvD-oo=sQqqWg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

On Thu, Mar 19, 2020 at 03:57:42PM +0100, Vincent Legoll wrote:
> > > +    (description "Tool to send a @code{magic} packet to wake another host
> > > +on the network.  This must be enabled on the target host, usually in the
> > > +BIOS.")
> >
> > If I may ask, what's the rationale behind putting "magic" in a @code tag
> > here?
> 
> I think I copied that desc from somewhere else (maybe nixos) and it had quoting
> around, and then guix lint told me to use @code instead, I probably should just
> have removed the quotes... Nothing more than that, you can remove them if
> you want to commit, or if you want I can resubmit without...

Sorry for taking a while to respond on this, but I pushed your patch as
commit 62b9ad19e3a6638f8e077753454fdf08ba586146 with two changes:
Firstly, I removed the @code tag as you suggested. Secondly, I removed
the references to `name' in the URL, since, as the contributing
guidelines suggest, the URL likely won't be valid if the name gets
changed.

Cheers!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-03-30  2:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 15:04 [bug#40105] [PATCH] gnu: Add wol Vincent Legoll
2020-03-19 12:55 ` Jakub Kądziołka
2020-03-19 14:57   ` Vincent Legoll
2020-03-28 23:09     ` Jakub Kądziołka [this message]
2020-03-29  8:26       ` Vincent Legoll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200328230935.7tqjyjazm55pv3fr@gravity \
    --to=kuba@kadziolka.net \
    --cc=40105-done@debbugs.gnu.org \
    --cc=vincent.legoll@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).