* [bug#40209] [PATCH] gnu: qiv: Add qiv image viewer for X
@ 2020-03-24 9:36 R Veera Kumar
2020-03-24 10:33 ` [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an " R Veera Kumar
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: R Veera Kumar @ 2020-03-24 9:36 UTC (permalink / raw)
To: 40209
Hi,
Add Quick Image Viewer (qiv) for X. A new pkg submission.
Website: http://spiegl.de/qiv/
Regards,
R Veera Kumar
[Outreachy Contrib]
India
^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an image viewer for X
2020-03-24 9:36 [bug#40209] [PATCH] gnu: qiv: Add qiv image viewer for X R Veera Kumar
@ 2020-03-24 10:33 ` R Veera Kumar
2020-03-24 12:04 ` Danny Milosavljevic
2020-03-25 8:08 ` [bug#40209] [PATCH v2] gnu: image-viewers: " R Veera Kumar
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: R Veera Kumar @ 2020-03-24 10:33 UTC (permalink / raw)
To: 40209
Add qiv an image viewer for X.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
gnu/packages/qiv.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 gnu/packages/qiv.scm
diff --git a/gnu/packages/qiv.scm b/gnu/packages/qiv.scm
new file mode 100644
index 0000000000..76b3c5702c
--- /dev/null
+++ b/gnu/packages/qiv.scm
@@ -0,0 +1,53 @@
+(define-module (gnu packages qiv)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix packages)
+ #:use-module (guix download)
+ #:use-module (guix build-system gnu)
+ #:use-module (gnu packages)
+ #:use-module (gnu packages image)
+ #:use-module (gnu packages glib)
+ #:use-module (gnu packages gtk)
+ #:use-module (gnu packages photo)
+ #:use-module (gnu packages pkg-config))
+
+
+(define-public qiv
+ (package
+ (name "qiv")
+ (version "2.3.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "http://spiegl.de/qiv/download/qiv-"
+ version ".tgz"))
+ (sha256
+ (base32 "1rlf5h67vhj7n1y7jqkm9k115nfnzpwngj3kzqsi2lg676srclv7"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("imlib2" ,imlib2)
+ ("glib" ,glib)
+ ("gtk+" ,gtk+-2)
+ ("libtiff" ,libtiff)
+ ("libexif" ,libexif)
+ ("libpng" ,libpng)))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (delete `configure))
+ #:tests? #f
+ #:make-flags
+ (list
+ "CC=gcc"
+ "LCMS="
+ (string-append "PREFIX=" (assoc-ref %outputs "out")))))
+ (home-page "http://spiegl.de/qiv/")
+ (synopsis "Graphical image viewer for X")
+ (description
+ "Quick Image Viewer is a very small and fast GDK/Imlib image viewer.
+Features include zoom, maxpect, scale down, fullscreen, brightness/contrast/
+gamma correction, slideshow, pan with keyboard and mouse, rotate left/right,
+flip, delete, jump/forward/backward images, filename filter and use it to
+set X desktop background.")
+ (license license:gpl2)))
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an image viewer for X
2020-03-24 10:33 ` [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an " R Veera Kumar
@ 2020-03-24 12:04 ` Danny Milosavljevic
0 siblings, 0 replies; 10+ messages in thread
From: Danny Milosavljevic @ 2020-03-24 12:04 UTC (permalink / raw)
To: R Veera Kumar; +Cc: 40209
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
Hi Veera,
in order to make this actually work in a Guix release, please refer to the new
file in gnu/local.mk in GNU_SYSTEM_MODULES .
Or better yet, in this case I would prefer if you just added qiv to the existing
file gnu/packages/image-viewers.scm .
>+ #:tests? #f
Why? Please add a comment.
It seems that the changelog mentions that the tests are now in "make install".
Did the tests work?
>+ #:make-flags
>+ (list
>+ "CC=gcc"
>+ "LCMS="
>+ (string-append "PREFIX=" (assoc-ref %outputs "out")))))
Indentation is off.
Otherwise it looks good.
Could you send a v2 of your patch with these points addressed?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#40209] [PATCH v2] gnu: image-viewers: Add new pkg qiv an image viewer for X
2020-03-24 9:36 [bug#40209] [PATCH] gnu: qiv: Add qiv image viewer for X R Veera Kumar
2020-03-24 10:33 ` [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an " R Veera Kumar
@ 2020-03-25 8:08 ` R Veera Kumar
2020-03-31 13:38 ` Danny Milosavljevic
2020-03-31 11:03 ` [bug#40209] [PATCH v3] gnu: Add qiv R Veera Kumar
2020-04-01 1:07 ` [bug#40209] [PATCH v4] " R Veera Kumar
3 siblings, 1 reply; 10+ messages in thread
From: R Veera Kumar @ 2020-03-25 8:08 UTC (permalink / raw)
To: 40209; +Cc: Danny Milosavljevic
Add qiv (Quick Image Viewer) is a very small and fast GDK/Imlib2
image viewer for X.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
Changes in v2:
- Add into image-viewers instead of separate
- Add reason for no make check as comments
- Correct indentation using indent-code.el
- remove libpng from inputs
---
gnu/packages/image-viewers.scm | 42 ++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 8f3f61c4b1..133df4f741 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -596,3 +596,45 @@ with tiling window managers. Features include:
@end itemize\n")
(home-page "https://github.com/eXeC64/imv")
(license license:expat)))
+
+(define-public qiv
+ (package
+ (name "qiv")
+ (version "2.3.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "http://spiegl.de/qiv/download/qiv-"
+ version ".tgz"))
+ (sha256
+ (base32 "1rlf5h67vhj7n1y7jqkm9k115nfnzpwngj3kzqsi2lg676srclv7"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("imlib2" ,imlib2)
+ ("glib" ,glib)
+ ("gtk+" ,gtk+-2)
+ ("libtiff" ,libtiff)
+ ("libexif" ,libexif)))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (delete `configure)) ;; no configure script
+ #:tests? #f ;; there is no check target
+ ;; make install runs the built qiv binary
+ ;; which fails as no X in build env
+ #:make-flags
+ (list
+ "CC=gcc"
+ "LCMS=" ;; requires lcms2
+ (string-append "PREFIX=" (assoc-ref %outputs "out")))))
+ (home-page "http://spiegl.de/qiv/")
+ (synopsis "Graphical image viewer for X")
+ (description
+ "Quick Image Viewer is a very small and fast GDK/Imlib2 image viewer.
+Features include zoom, maxpect, scale down, fullscreen, brightness/contrast/
+gamma correction, slideshow, pan with keyboard and mouse, rotate left/right,
+flip, delete, jump/forward/backward images, filename filter and use it to
+set X desktop background.")
+ (license license:gpl2)))
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [bug#40209] [PATCH v3] gnu: Add qiv.
2020-03-24 9:36 [bug#40209] [PATCH] gnu: qiv: Add qiv image viewer for X R Veera Kumar
2020-03-24 10:33 ` [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an " R Veera Kumar
2020-03-25 8:08 ` [bug#40209] [PATCH v2] gnu: image-viewers: " R Veera Kumar
@ 2020-03-31 11:03 ` R Veera Kumar
2020-03-31 11:17 ` Danny Milosavljevic
2020-04-01 1:07 ` [bug#40209] [PATCH v4] " R Veera Kumar
3 siblings, 1 reply; 10+ messages in thread
From: R Veera Kumar @ 2020-03-31 11:03 UTC (permalink / raw)
To: 40209
* gnu/packages/image-viewers.scm (qiv): New variable.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
Changes in v3:
- Commit msg as per changelog format.
- Change quasi quote to normal in modify phases 'configure
- Add lcms2 and jpeg support
Changes in v2:
- Add into image-viewers instead of separate
- Add reason for no make check as comments
- Correct indentation using indent-code.el
---
gnu/packages/image-viewers.scm | 45 ++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 8f3f61c4b1..bc2ad69473 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -13,6 +13,7 @@
;;; Copyright © 2019 Guy Fleury Iteriteka <hoonandon@gmail.com>
;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
;;; Copyright © 2020 Peng Mei Yu <pengmeiyu@riseup.net>
+;;; Copyright © 2020 R Veera Kumar <vkor@vkten.in>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -596,3 +597,47 @@ with tiling window managers. Features include:
@end itemize\n")
(home-page "https://github.com/eXeC64/imv")
(license license:expat)))
+
+(define-public qiv
+ (package
+ (name "qiv")
+ (version "2.3.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "http://spiegl.de/qiv/download/qiv-"
+ version ".tgz"))
+ (sha256
+ (base32 "1rlf5h67vhj7n1y7jqkm9k115nfnzpwngj3kzqsi2lg676srclv7"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("imlib2" ,imlib2)
+ ("glib" ,glib)
+ ("gtk+" ,gtk+-2)
+ ("lcms" ,lcms)
+ ("libjpeg" ,libjpeg)
+ ("libtiff" ,libtiff)
+ ("libexif" ,libexif)
+ ("libx11" ,libx11)
+ ("libxext" ,libxext)))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (delete 'configure)) ;; no configure script
+ #:tests? #f ;; there is no check target
+ ;; make install runs the built qiv binary
+ ;; which fails as no X in build env
+ #:make-flags
+ (list
+ (string-append "PREFIX=" (assoc-ref %outputs "out")))))
+ (home-page "http://spiegl.de/qiv/")
+ (synopsis "Graphical image viewer for X")
+ (description
+ "Quick Image Viewer is a small and fast GDK/Imlib2 image viewer.
+Features include zoom, maxpect, scale down, fullscreen, slideshow, delete,
+brightness/contrast/gamma correction, pan with keyboard and mouse, flip,
+rotate left/right, jump/forward/backward images, filename filter and use it
+to set X desktop background.")
+ (license license:gpl2)))
--
2.26.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [bug#40209] [PATCH v3] gnu: Add qiv.
2020-03-31 11:03 ` [bug#40209] [PATCH v3] gnu: Add qiv R Veera Kumar
@ 2020-03-31 11:17 ` Danny Milosavljevic
2020-03-31 11:53 ` R Veera Kumar
0 siblings, 1 reply; 10+ messages in thread
From: Danny Milosavljevic @ 2020-03-31 11:17 UTC (permalink / raw)
To: R Veera Kumar; +Cc: 40209
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
Hi Veera,
thanks!
> + ;; make install runs the built qiv binary
> + ;; which fails as no X in build env
But that should mean that this package should fail to install.
Doesn't it?
Also, you can just start an X server. (search for the text "Xvfb" in gnu/packages)
Everything else it fine.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#40209] [PATCH v3] gnu: Add qiv.
2020-03-31 11:17 ` Danny Milosavljevic
@ 2020-03-31 11:53 ` R Veera Kumar
0 siblings, 0 replies; 10+ messages in thread
From: R Veera Kumar @ 2020-03-31 11:53 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: 40209
On Tue, Mar 31, 2020 at 01:17:12PM +0200, Danny Milosavljevic wrote:
> Hi Veera,
>
> thanks!
>
> > + ;; make install runs the built qiv binary
> > + ;; which fails as no X in build env
>
> But that should mean that this package should fail to install.
>
> Doesn't it?
>
I am running the build in X environment (Mate DM).
Package builds fine. And installs fine. And works fine.
The Makefile has this:
@if ./qiv -f ./intro.jpg ; \
then echo "-- Test Passed --" ; \
else echo "-- Test Failed --" ; \
fi
It justs echos this in build log which I saw.
> Also, you can just start an X server. (search for the text "Xvfb" in gnu/packages)
>
Is it neccessary?
Am finding about it.
> Everything else it fine.
Thanks,
R Veera Kumar
^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#40209] [PATCH v2] gnu: image-viewers: Add new pkg qiv an image viewer for X
2020-03-25 8:08 ` [bug#40209] [PATCH v2] gnu: image-viewers: " R Veera Kumar
@ 2020-03-31 13:38 ` Danny Milosavljevic
0 siblings, 0 replies; 10+ messages in thread
From: Danny Milosavljevic @ 2020-03-31 13:38 UTC (permalink / raw)
To: R Veera Kumar; +Cc: 40209
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
There are different kinds of comments we use (by convention):
;; These comments are for sentences describing the next thing.
(foo...)
;;;
;;; These comments are for describing entire sections.
;;;
(foo...) ; these just for short trailing note
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#40209] [PATCH v4] gnu: Add qiv.
2020-03-24 9:36 [bug#40209] [PATCH] gnu: qiv: Add qiv image viewer for X R Veera Kumar
` (2 preceding siblings ...)
2020-03-31 11:03 ` [bug#40209] [PATCH v3] gnu: Add qiv R Veera Kumar
@ 2020-04-01 1:07 ` R Veera Kumar
2020-04-01 10:20 ` bug#40209: " Danny Milosavljevic
3 siblings, 1 reply; 10+ messages in thread
From: R Veera Kumar @ 2020-04-01 1:07 UTC (permalink / raw)
To: 40209
* gnu/packages/image-viewers.scm (qiv): New variable.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
Changes in v4:
- Make install check pass by setting up Xvfb for test
- Patch Makefile so that qiv runs and exits by itself during test
- Make proper guile comments
Changes in v3:
- Commit msg as per changelog format.
- Change quasi quote to normal in modify phases 'configure
- Add lcms2 and jpeg support
Changes in v2:
- Add into image-viewers instead of separate
- Add reason for no make check as comments
- Correct indentation using indent-code.el
---
gnu/packages/image-viewers.scm | 55 ++++++++++++++++++++++++++++++++++
1 file changed, 55 insertions(+)
diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 8f3f61c4b1..6bbbf2a3b0 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -13,6 +13,7 @@
;;; Copyright © 2019 Guy Fleury Iteriteka <hoonandon@gmail.com>
;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
;;; Copyright © 2020 Peng Mei Yu <pengmeiyu@riseup.net>
+;;; Copyright © 2020 R Veera Kumar <vkor@vkten.in>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -596,3 +597,57 @@ with tiling window managers. Features include:
@end itemize\n")
(home-page "https://github.com/eXeC64/imv")
(license license:expat)))
+
+(define-public qiv
+ (package
+ (name "qiv")
+ (version "2.3.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "http://spiegl.de/qiv/download/qiv-"
+ version ".tgz"))
+ (sha256
+ (base32 "1rlf5h67vhj7n1y7jqkm9k115nfnzpwngj3kzqsi2lg676srclv7"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ;; for testing
+ ("xorg-server" ,xorg-server-for-tests)))
+ (inputs
+ `(("imlib2" ,imlib2)
+ ("glib" ,glib)
+ ("gtk+" ,gtk+-2)
+ ("lcms" ,lcms)
+ ("libjpeg" ,libjpeg)
+ ("libtiff" ,libtiff)
+ ("libexif" ,libexif)
+ ("libx11" ,libx11)
+ ("libxext" ,libxext)))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (delete 'configure) ; no configure script
+ (add-before 'install 'patch-file-start-xserver
+ (lambda* (#:key inputs #:allow-other-keys)
+ ;; patch the file so that qiv runs and exits by itself
+ (substitute* "Makefile"
+ (("./qiv -f ./intro.jpg") "./qiv -f -C -s ./intro.jpg"))
+ (let ((xorg-server (assoc-ref inputs "xorg-server")))
+ ;; There must be a running X server and make install doesn't start one.
+ ;; Therefore we must do it.
+ (system (format #f "~a/bin/Xvfb :1 &" xorg-server))
+ (setenv "DISPLAY" ":1") ) #t)))
+ #:tests? #f ; there is no check target
+ #:make-flags
+ (list
+ (string-append "PREFIX=" (assoc-ref %outputs "out")))))
+ (home-page "http://spiegl.de/qiv/")
+ (synopsis "Graphical image viewer for X")
+ (description
+ "Quick Image Viewer is a small and fast GDK/Imlib2 image viewer.
+Features include zoom, maxpect, scale down, fullscreen, slideshow, delete,
+brightness/contrast/gamma correction, pan with keyboard and mouse, flip,
+rotate left/right, jump/forward/backward images, filename filter and use it
+to set X desktop background.")
+ (license license:gpl2)))
--
2.26.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* bug#40209: [PATCH v4] gnu: Add qiv.
2020-04-01 1:07 ` [bug#40209] [PATCH v4] " R Veera Kumar
@ 2020-04-01 10:20 ` Danny Milosavljevic
0 siblings, 0 replies; 10+ messages in thread
From: Danny Milosavljevic @ 2020-04-01 10:20 UTC (permalink / raw)
To: R Veera Kumar; +Cc: 40209-done
[-- Attachment #1: Type: text/plain, Size: 132 bytes --]
Hi Veera,
Thanks for the patch!
pushed to guix master as commit e2bd0af373d3abfba645647e6ec674670f2bd1e4 with
tiny changes.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-04-01 10:21 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-24 9:36 [bug#40209] [PATCH] gnu: qiv: Add qiv image viewer for X R Veera Kumar
2020-03-24 10:33 ` [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an " R Veera Kumar
2020-03-24 12:04 ` Danny Milosavljevic
2020-03-25 8:08 ` [bug#40209] [PATCH v2] gnu: image-viewers: " R Veera Kumar
2020-03-31 13:38 ` Danny Milosavljevic
2020-03-31 11:03 ` [bug#40209] [PATCH v3] gnu: Add qiv R Veera Kumar
2020-03-31 11:17 ` Danny Milosavljevic
2020-03-31 11:53 ` R Veera Kumar
2020-04-01 1:07 ` [bug#40209] [PATCH v4] " R Veera Kumar
2020-04-01 10:20 ` bug#40209: " Danny Milosavljevic
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).