From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:38793) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGiIq-0005FI-Bs for guix-patches@gnu.org; Tue, 24 Mar 2020 08:05:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGiIn-0000lo-VN for guix-patches@gnu.org; Tue, 24 Mar 2020 08:05:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48044) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jGiIn-0000lb-SJ for guix-patches@gnu.org; Tue, 24 Mar 2020 08:05:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jGiIn-0001Mo-Mh for guix-patches@gnu.org; Tue, 24 Mar 2020 08:05:01 -0400 Subject: [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an image viewer for X Resent-Message-ID: Date: Tue, 24 Mar 2020 13:04:35 +0100 From: Danny Milosavljevic Message-ID: <20200324130435.53b67995@scratchpost.org> In-Reply-To: <20200324103316.GA3324@tulip> References: <20200324093627.GB3208@tulip> <20200324103316.GA3324@tulip> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/B.J0=2qU3OKi.B3vmeZwVlT"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: R Veera Kumar Cc: 40209@debbugs.gnu.org --Sig_/B.J0=2qU3OKi.B3vmeZwVlT Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Veera, in order to make this actually work in a Guix release, please refer to the = new file in gnu/local.mk in GNU_SYSTEM_MODULES . Or better yet, in this case I would prefer if you just added qiv to the exi= sting file gnu/packages/image-viewers.scm . >+ #:tests? #f Why? Please add a comment. It seems that the changelog mentions that the tests are now in "make instal= l". Did the tests work? >+ #:make-flags >+ (list >+ "CC=3Dgcc" >+ "LCMS=3D" >+ (string-append "PREFIX=3D" (assoc-ref %outputs "out"))))) Indentation is off. Otherwise it looks good. Could you send a v2 of your patch with these points addressed? --Sig_/B.J0=2qU3OKi.B3vmeZwVlT Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl5591MACgkQ5xo1VCww uqVaPwf/YfAuHNKvU6/mY9AoPHXINg61Azd+1I5nBEtusKBTJUb5ezoa2jzN0uX7 3YTZ6JT7UOzYfO/HdYsn5osGZLlZyBUpvTJ/S4GzvpAiXMHmpK92SiuIOHsgbbjZ JQS8n/e8jsTJldY/7DMrveiZSGsClhzMr6osSKqf/3YSsoyqJlrnudQqJ/efOoZB 8oWmCEGvTZ82kJOO/geZRxLcCyUmE1RMF50EarXEvhfAflO3uOuI81Om1WzlK8f5 MeS8vBcMxLY+wnsQ1gRv0O89VEakawgWt1jcoOPruj19Yv6sM6LaViJ0fUzGuMSn QnhXqcDWbh9mhybnQzagg+stm4b0HA== =zV0D -----END PGP SIGNATURE----- --Sig_/B.J0=2qU3OKi.B3vmeZwVlT--