unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 40178@debbugs.gnu.org
Subject: [bug#40178] [PATCH 2/2] gnu: Remove qemu-minimal-2.10.
Date: Sun, 22 Mar 2020 14:29:40 -0400	[thread overview]
Message-ID: <20200322182940.GB1532@jasmine.lan> (raw)
In-Reply-To: <87fte04ggb.fsf@devup.no>

On Sun, Mar 22, 2020 at 03:22:44PM +0100, Marius Bakke wrote:
> > -             ;; afl only supports using a single afl-qemu-trace executable, so
> > -             ;; we only build qemu for the native target.
> 
> Perhaps preserve this comment close to the (let ((machine ...))) line?

Done.

> > +         (add-after 'install 'install-info

> > +         (add-after 'install-info 'create-samba-wrapper

> > +         (add-before 'configure 'prevent-network-configuration
> 
> I think we can remove all the phases above for simplicity.

Done.

> > +       ("texinfo" ,texinfo)))
> 
> As well as the texinfo input.

Done.

> > +    (home-page "https://www.qemu.org")
> > +    (synopsis "Machine emulator and virtualizer (without GUI)")
> > +    (description
> > +     "QEMU is a generic machine emulator and virtualizer.
> > +
> > +When used as a machine emulator, QEMU can run OSes and programs made for one
> > +machine (e.g. an ARM board) on a different machine---e.g., your own PC.  By
> > +using dynamic translation, it achieves very good performance.
> > +
> > +When used as a virtualizer, QEMU achieves near native performances by
> > +executing the guest code directly on the host CPU.  QEMU supports
> > +virtualization when executing under the Xen hypervisor or using
> > +the KVM kernel module in Linux.  When using KVM, QEMU can virtualize x86,
> > +server and embedded PowerPC, and S390 guests.")
> > +    ;; Many files are GPLv2+, but some are GPLv2-only---e.g., `memory.c'.
> > +    (license license:gpl2)
> > +    ;; Several tests fail on MIPS.
> > +    (supported-systems (delete "mips64el-linux" %supported-systems))))))
> 
> This section can be removed, as it gets inherited and does not affect
> the derivation.

This qemu-for-american-fuzzy-lop package doesn't inherit from anything.
My goal was to completely separate it from the "real" QEMU package so
that we can ignore about it and let whoever is interesting in AFL take
care of it. It wouldn't be a problem to inherit these fields, but
instead I will edit them to describe what this package is for.

> In any case LGTM, too!

Thanks for the review! Pushed as 268efd97c255d75ac488c163ff1b8c66c6bcb2b6

  reply	other threads:[~2020-03-22 18:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-21 22:21 [bug#40178] QEMU for american fuzzy lop Leo Famulari
2020-03-21 22:24 ` [bug#40178] [PATCH 1/2] gnu: Prefix licenses in (gnu packages debug) Leo Famulari
2020-03-21 22:24   ` [bug#40178] [PATCH 2/2] gnu: Remove qemu-minimal-2.10 Leo Famulari
2020-03-22 13:16     ` Danny Milosavljevic
2020-03-22 14:22     ` Marius Bakke
2020-03-22 18:29       ` Leo Famulari [this message]
2020-03-31 21:07         ` bug#40178: " Christopher Baines
2020-03-22 13:12   ` [bug#40178] [PATCH 1/2] gnu: Prefix licenses in (gnu packages debug) Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200322182940.GB1532@jasmine.lan \
    --to=leo@famulari.name \
    --cc=40178@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).