From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:33926)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jDXWV-00071d-PF
 for guix-patches@gnu.org; Sun, 15 Mar 2020 13:58:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jDXWU-0004Te-KD
 for guix-patches@gnu.org; Sun, 15 Mar 2020 13:58:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:57748)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jDXWU-0004Rq-Dw
 for guix-patches@gnu.org; Sun, 15 Mar 2020 13:58:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jDXWU-0003JA-DE
 for guix-patches@gnu.org; Sun, 15 Mar 2020 13:58:02 -0400
Subject: bug#40032: [PATCH] gnu: Add nvme-cli
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.40032.D40032.158429505112655.done@debbugs.gnu.org>
Date: Sun, 15 Mar 2020 13:57:22 -0400
From: Leo Famulari <leo@famulari.name>
Message-ID: <20200315175722.GE26892@jasmine.lan>
References: <CAEwRq=r4yWqyJ6GEK+Bj4UibDvXkqBpphVchw7UmeTe04r7+5g@mail.gmail.com>
 <20200312181513.GA8595@jasmine.lan>
 <CAEwRq=qtHYZ7wXT-TWfZLh837mGMb+cCgjbKOrPagdsq5-r8MQ@mail.gmail.com>
 <CAEwRq=pMDGyhQvOBMex6PXYx+2W71kZGHGx3p_v=26APXbtw8w@mail.gmail.com>
 <20200315172242.GA26892@jasmine.lan>
 <CAEwRq=pKhf5YhFc6pG8=0o28HTMJ7f_uss4UHc11YkTKQtUc2A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEwRq=pKhf5YhFc6pG8=0o28HTMJ7f_uss4UHc11YkTKQtUc2A@mail.gmail.com>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 40032-done@debbugs.gnu.org

On Sun, Mar 15, 2020 at 06:36:54PM +0100, Vincent Legoll wrote:
> From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001
> From: Vincent Legoll <vincent.legoll@gmail.com>
> Date: Thu, 12 Mar 2020 01:51:12 +0100
> Subject: [PATCH] gnu: Add nvme-cli
> 
> * gnu/packages/linux.scm (nvme-cli): New variable.

Thanks! Pushed as 323841bda4e5b8f9b30626ab768aaf711ee6aabf with the
following changes that I somehow forgot to mention. There was no need to
make you revise the patch again...

> +       #:phases (modify-phases %standard-phases
> +                  (delete 'configure)

I added a comment about why the phase is deleted.

> +                  (replace 'install
> +                    (lambda _
> +                      (zero? (system* "make" "install-spec" "PREFIX="
> +                                      (string-append "DESTDIR=" %output))))))

I replaced (zero? (system* ...)) with (invoke ...), which raises
exceptions on failure rather than returning a boolean #f. This is "the
Guix way" for a while now:

https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html

> +    (description "Utility to provide standards compliant tooling for NVM-Express
> +drives.  It was made specifically for Linux as it relies on the IOCTLs defined

And I made this first sentence into a complete sentence.