From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:41165) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDX1X-0006Kd-9z for guix-patches@gnu.org; Sun, 15 Mar 2020 13:26:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDX1W-0004gk-Ag for guix-patches@gnu.org; Sun, 15 Mar 2020 13:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57700) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDX1W-0004fU-6G for guix-patches@gnu.org; Sun, 15 Mar 2020 13:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDX1W-0002RH-32 for guix-patches@gnu.org; Sun, 15 Mar 2020 13:26:02 -0400 Subject: [bug#40060] [PATCH 1/2] gnu: youtube-dl: Use ffmpeg and pycryptodome Resent-Message-ID: Date: Sun, 15 Mar 2020 13:25:13 -0400 From: Leo Famulari Message-ID: <20200315172513.GB26892@jasmine.lan> References: <20200314143418.13963-1-brice@waegenei.re> <20200314144221.17112-1-brice@waegenei.re> <20200314172114.GA23019@jasmine.lan> <87y2s2lgxl.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <87y2s2lgxl.fsf@nckx> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 40060@debbugs.gnu.org On Sat, Mar 14, 2020 at 11:17:42PM +0100, Tobias Geerinckx-Rice wrote: > Brice Waegeneire =E5=86=99=E9=81=93=EF=BC=9A > > I should have written this in the cover-letter, my bad. > > pycryptodome is needed for the hlsative downloader, ffmpeg adds the > > ability to merge video and audio files downloaded separately by > > youtube-dl and removes the following warning: > > WARNING: You have requested multiple formats but ffmpeg or avconv are > > not installed. The formats won't be merged. >=20 > This message is one of the best I've seen. It clearly explains to the us= er > what's (not) going to happen, and what they can do to change that *if* th= ey > want to. Hence I think adding ffmpeg as a hard dependency is incorrect. I see your point of view, and I also have FFmpeg installed manually because I use it frequently in my work. I guess it depends on how many people are experiencing the issue that Brice is having.