From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55874) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCO67-0003I1-KZ for guix-patches@gnu.org; Thu, 12 Mar 2020 09:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCO66-0002Wf-5x for guix-patches@gnu.org; Thu, 12 Mar 2020 09:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jCO66-0002WX-1s for guix-patches@gnu.org; Thu, 12 Mar 2020 09:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jCO66-0002wd-0l for guix-patches@gnu.org; Thu, 12 Mar 2020 09:42:02 -0400 Subject: bug#39943: [PATCH v2 4/4] gnu: Add hyperledger-iroha. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Thu, 12 Mar 2020 15:40:55 +0200 From: Efraim Flashner Message-ID: <20200312134055.GC824@E5400> References: <20200310083105.21013-1-efraim@flashner.co.il> <20200310083105.21013-5-efraim@flashner.co.il> <87r1xz2d4q.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xo44VMWPx7vlQ2+2" Content-Disposition: inline In-Reply-To: <87r1xz2d4q.fsf@ambrevar.xyz> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 39943-done@debbugs.gnu.org --xo44VMWPx7vlQ2+2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 11, 2020 at 03:13:25PM +0100, Pierre Neidhardt wrote: > I've tested it and run the example here > https://iroha.readthedocs.io/en/latest/getting_started/cli-guide.html > It works! >=20 > Patch looks good, feel free to merge. > A few comments below: >=20 > > + (snippet > > + '(begin > > + ;; Backport unversioned fmt dependency: > > + (substitute* "libs/logger/logger.hpp" > > + (("fmt::v5") "fmt")) > > + #t)))) >=20 > Mention the commit you've sent me and that this should be removed on > next update. Done >=20 > > + (build-system cmake-build-system) > > + (arguments > > + `(#:configure-flags > > + '("-DTESTING=3DOFF" > > + ; Don't install the shared libraries of the dependencies: > > + "-DENABLE_LIBS_PACKAGING=3DOFF") > > + #:tests? #f >=20 > Explain why the tests must be disabled. >=20 Noted > > + #:test-target "." >=20 > Why setting the test-target if you are not running it? >=20 I added a note to the build instructions, for when we can run the tests > > + #:phases > > + (modify-phases %standard-phases > > + (add-after 'unpack 'change-compilation-flags > > + (lambda _ > > + (substitute* "cmake/functions.cmake" > > + (("-Werror") "")) > > + #t))))) >=20 > Why do you need to do this? >=20 Turns out we don't, I removed it > > + ;; See https://iroha.readthedocs.io/en/latest/build/index.html. > > + (native-inputs > > + `(("googletest" ,googletest))) > > + (inputs > > + `(("boost" ,boost-1.69) > > + ("fmt" ,fmt) > > + ("gflags" ,gflags) > > + ("grpc" ,grpc) > > + ("hyperledger-iroha-ed25519" ,hyperledger-iroha-ed25519) > > + ("postgresql" ,postgresql) > > + ("protobuf" ,protobuf) > > + ("rapidjson" ,rapidjson) > > + ("rxcpp" ,rxcpp) > > + ("soci" ,soci) > > + ("spdlog" ,spdlog) > > + ("tbb" ,tbb))) > > + (synopsis "Simple, decentralized ledger") > > + (description "Iroha is a distributed ledger technology (DLT). Iroh= a has >=20 > Double spacing. >=20 > Thanks! > Cheers! >=20 > --=20 > Pierre Neidhardt > https://ambrevar.xyz/ --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --xo44VMWPx7vlQ2+2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5qO+cACgkQQarn3Mo9 g1H9aQ/9G0pAXnVdrFJ0P+yaiFb8g5kZc+WcfWDLM7CCCOfJ75n2f1Z/GJb8SJOb BIQrN+depQR5SN6gZ2uJIw0bN7++sL36KkGjCuFuWyFU2khrpK03EwN+oFytgNmk T968vr6Jd75rMIby6MnyFcl8QVYCbmIV6f2CS/KrXJ3GXtqPNbH3/XVvJw54xmB5 AQFVi62qv9RHRXPAYzqbzWjwtEOwLIryE3QWfxsdN1wziVFbH6QLtWqyjdu/Gcal 7wFTFoCyjYD+6nEBVt8O+gEnkmJX/J2ZIQfsmFDTDyBVm33kdYUGGzcK3ybENmBV kSjKYuswAihV3l/gO1Vga5zo/B0+w35/hVgw9Bjif9EkYwF9V2aUl7+MFzKGvUop MXKpEJ9a5sTFgk3Jy5QG1QhmnXc42qiU8fd3PQigOOoUqf6vZJb2mttcqgvET2Y6 qZNIHU04bE11w0pD7DNW0D+U96K715cbNfLvonDAqF1rhSSWiUZjkreFPuKbrtHn zhL86qOpPGcwGQ2a80AnkR15o08kXuhAnOcdNU9rS/KlanDftycSqrTMClsY18u7 3DDtGAz5L40kWKhB6sdCILcJsD0PvS8+jxc9+zq1OROwfsqFBZVuzvj4U8po8ALk 5U+nkY1NhKmohsBe4DEVYZQuiKi4emy7PMmxwRbVaC4JUWLC8N0= =D0Ou -----END PGP SIGNATURE----- --xo44VMWPx7vlQ2+2--