From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50029) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCJWZ-0001DK-Hz for guix-patches@gnu.org; Thu, 12 Mar 2020 04:49:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCJWY-0004pv-EG for guix-patches@gnu.org; Thu, 12 Mar 2020 04:49:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jCJWY-0004pp-Aa for guix-patches@gnu.org; Thu, 12 Mar 2020 04:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jCJWY-00078q-9u for guix-patches@gnu.org; Thu, 12 Mar 2020 04:49:02 -0400 Subject: [bug#39777] [PATCH V3 04/11] gnu: python-jsonschema: Update to 3.2.0. Resent-Message-ID: Date: Thu, 12 Mar 2020 09:48:28 +0100 From: Tanguy Le Carrour Message-ID: <20200312084828.o5lsuze5mmdrjg6w@rafflesia> References: <20200309081827.13489-1-tanguy@bioneland.org> <20200309081827.13489-4-tanguy@bioneland.org> <20200311191542.GB13879@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200311191542.GB13879@jasmine.lan> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 39777@debbugs.gnu.org Hi Leo, Thanks for taking the time to read my patches! Le 03/11, Leo Famulari a écrit : > On Mon, Mar 09, 2020 at 09:18:20AM +0100, Tanguy Le Carrour wrote: > > * gnu/packages/python-xyz.scm (python-jsonschema): Update to 3.2.0. > > [propagated-inputs]: Add python-importlib-metadata. > > [arguments]: Disable failing test. > > > + (add-before 'check 'disable-failing-test > > + (lambda _ > > + (substitute* "jsonschema/tests/test_cli.py" > > + (("def test_version") "def _test_version")) > > + #t)) > > Again, we need a comment explaining what's wrong with the test. My bad! Sorry! I started investigating when I submitted the patch, but… well… I haven't found a fix yet and I'm not sure who to blame! The test relies on a call to `subprocess.check_output` to run `python -m jsonschema --version`, but it behaves like `--version` was never passed to the command?! ``` 145 def test_version(self): 146 version = subprocess.check_output( 147 [sys.executable, "-m", "jsonschema", "--version"], 148 stderr=subprocess.STDOUT, 149 ) ``` Replacing `check_output` with `check_call` shows the actual error message: ``` usage: __main__.py [-h] [-i INSTANCES] [-F ERROR_FORMAT] [-V VALIDATOR] schema __main__.py: error: the following arguments are required: schema ``` Doesn't really look like a problem with jsonschema to me, and… I would not dare blaming python. ^_^' Any idea welcome! -- Tanguy