From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55735) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHGN-0004dS-A9 for guix-patches@gnu.org; Mon, 09 Mar 2020 08:12:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBHGM-0000UP-AM for guix-patches@gnu.org; Mon, 09 Mar 2020 08:12:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43933) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBHGM-0000U8-78 for guix-patches@gnu.org; Mon, 09 Mar 2020 08:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jBHGM-0001Up-2S for guix-patches@gnu.org; Mon, 09 Mar 2020 08:12:02 -0400 Subject: [bug#39915] [PATCH] gnu: Add nyancat. Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:55682) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHFr-0003y1-0t for guix-patches@gnu.org; Mon, 09 Mar 2020 08:11:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBHFq-00007V-0q for guix-patches@gnu.org; Mon, 09 Mar 2020 08:11:30 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:48228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jBHFp-00005b-N5 for guix-patches@gnu.org; Mon, 09 Mar 2020 08:11:29 -0400 Date: Mon, 9 Mar 2020 13:12:19 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200309121219.zf6m5kjvurgeug6s@gravity> References: <20200304194448.11305-1-efraim@flashner.co.il> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xj7r5t3hpq24bf2o" Content-Disposition: inline In-Reply-To: <20200304194448.11305-1-efraim@flashner.co.il> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 39915@debbugs.gnu.org --xj7r5t3hpq24bf2o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 04, 2020 at 09:44:48PM +0200, Efraim Flashner wrote: > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'configure) ; no configure script > + (add-after 'unpack 'set-environment-variables > + (lambda _ (setenv "CC" (which "gcc")) #t)) I'm not fond of formatting a whole phase on one line, I feel like (lambda _ (setenv "CC" (which "gcc")) #t) would be clearer. Either way, as far as I can see, this can also be done with the simpler #:make-flags '("CC=gcc") Apart from that, LGTM. > + (synopsis "Nyan cat telnet server") I'm kinda disappointed you didn't include a service to go with it :P --xj7r5t3hpq24bf2o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5mMqMACgkQ4xWnWEYT FWQmxQ//WZWQbwjJNmCaQ/3SmqDZTcmdoXW8MjwpiTvilcZKiV/jWIxmNv7wmM8s CqwRxm5kQG8TvXHkp3wC11dM+TmKPaR+EB/lRYrUxZSHvKEECI7yp5FeR8VujI/4 xGZ4BFRy7JejSfvs2PsaDKei9emKT3Eh5AJNjuv+khccKoL9W6MO4iyyrluUk2B3 kvFibOmB3IXHHEkARZYwifrgnKVAcDbitxqGXy+MDIuXYckAh+0D7S+vALAicdLQ Cmyu8BYxq/JkklV8v97b/M4HFpXQdKYwK5Herz4AviF4BOlCKuC9SS4g1SCRV543 z5CpjEKc9AtdEcNOml69FwY8KQ7THKH9hnInQEAlk0jmb5A+LLAEi88zFdj+mh7E smd9rs8IM+GfmExymw8TSBWXDHOk6Fx2Ywaz9LqWc36DWoHZ5Cel7vaOrJFlFNQ5 TtO2a9qWPnBvh/0KEEmaxmoTCfRqWfmkDzfNrl8OQC/8pNwIrSfMd+w4oE8WgDYS w9m1iOIeQotyfnAt8VN2nO7CwO9jjPKJTB2BERhfVZEhp69g0X/me87AYCS8/8pU JTwU77GCRE6UEF2qSEFJ+geVuXJUXgkJKaxlCnzNyysFvCekApJ2VeNtOXIo7HKC h0/ZA7amSYpcwrfH3nOiFrH3Naf6MfQMPZcrSFV75nfRxUTe0eU= =Pqz2 -----END PGP SIGNATURE----- --xj7r5t3hpq24bf2o--