unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 39915@debbugs.gnu.org
Subject: [bug#39915] [PATCH] gnu: Add nyancat.
Date: Mon, 9 Mar 2020 13:12:19 +0100	[thread overview]
Message-ID: <20200309121219.zf6m5kjvurgeug6s@gravity> (raw)
In-Reply-To: <20200304194448.11305-1-efraim@flashner.co.il>

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

On Wed, Mar 04, 2020 at 09:44:48PM +0200, Efraim Flashner wrote:
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure) ; no configure script
> +         (add-after 'unpack 'set-environment-variables
> +           (lambda _ (setenv "CC" (which "gcc")) #t))
I'm not fond of formatting a whole phase on one line, I feel like
(lambda _
  (setenv "CC" (which "gcc"))
  #t)
would be clearer. Either way, as far as I can see, this can also be done
with the simpler #:make-flags '("CC=gcc")

Apart from that, LGTM.

> +    (synopsis "Nyan cat telnet server")
I'm kinda disappointed you didn't include a service to go with it :P

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-03-09 12:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 19:44 [bug#39915] [PATCH] gnu: Add nyancat Efraim Flashner
2020-03-09 12:12 ` Jakub Kądziołka [this message]
2020-03-09 12:32   ` bug#39915: " Efraim Flashner
2020-03-09 12:44     ` [bug#39915] " Jakub Kądziołka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200309121219.zf6m5kjvurgeug6s@gravity \
    --to=kuba@kadziolka.net \
    --cc=39915@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).