unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Robert Smith <robertsmith@posteo.net>
Cc: 39814-done@debbugs.gnu.org
Subject: bug#39814: [PATCH v2] gnu: anki: Fix mpv audio playback
Date: Sat, 7 Mar 2020 17:30:39 +0100	[thread overview]
Message-ID: <20200307163039.nprj5l6cr3ldk2xv@gravity> (raw)
In-Reply-To: <20200306160019.13440-1-robertsmith@posteo.net>

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On Fri, Mar 06, 2020 at 05:00:19PM +0100, Robert Smith wrote:
> * gnu/packages/patches/anki-mpv-args.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Adjust accordingly.
> * gnu/packages/education.scm (anki): Adjust accordingly, wrap anki's
>   PATH to include mpv executable.
> ---
> Thanks for the feedback Jakub, I've rewritten the patch based on the
> upstream commit and modified the commit message.

Thanks! The revised patch LGTM, and it indeed helps with audio playback
in anki, so I've pushed it to master as 880a316591650a06c18aeaef1703800784d2c196

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-03-07 16:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 20:09 [bug#39814] [PATCH] gnu: anki: Fix mpv audio playback Robert Smith
2020-03-01 21:20 ` Jakub Kądziołka
2020-03-06 16:00 ` [bug#39814] [PATCH v2] " Robert Smith
2020-03-07 16:30   ` Jakub Kądziołka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200307163039.nprj5l6cr3ldk2xv@gravity \
    --to=kuba@kadziolka.net \
    --cc=39814-done@debbugs.gnu.org \
    --cc=robertsmith@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).