From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:52521)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j9KHP-0000y6-9q
 for guix-patches@gnu.org; Tue, 03 Mar 2020 22:01:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j9KHO-0008OQ-B8
 for guix-patches@gnu.org; Tue, 03 Mar 2020 22:01:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:34238)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j9KHO-0008OC-7S
 for guix-patches@gnu.org; Tue, 03 Mar 2020 22:01:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j9KHO-0003GO-5D
 for guix-patches@gnu.org; Tue, 03 Mar 2020 22:01:02 -0500
Subject: [bug#39747] [PATCH 3/7] gnu: java-openjfx-graphics: Implement a
 complete compilation.
Resent-Message-ID: <handler.39747.B39747.158329082512493@debbugs.gnu.org>
Date: Tue, 3 Mar 2020 22:00:12 -0500
From: Leo Famulari <leo@famulari.name>
Message-ID: <20200304030012.GB1199@jasmine.lan>
References: <20200222201755.50425-1-levenson@mmer.org>
 <20200222201755.50425-3-levenson@mmer.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200222201755.50425-3-levenson@mmer.org>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alexey Abramov <levenson@mmer.org>
Cc: 39747@debbugs.gnu.org

On Sat, Feb 22, 2020 at 09:17:51PM +0100, Alexey Abramov wrote:
> +           (name "java-openjfx-graphics")
> +           (arguments
> +            `(#:jar-name "java-openjfx-graphics.jar"
> +              #:source-dir "modules/graphics/src/main/java"
> +              #:tests? #f               ; requires X
> +              #:test-dir "modules/graphics/src/test"
> +              #:test-include (list "**/*Test.*")
> +              #:modules ((guix build ant-build-system)
> +                         (guix build utils)
> +                         (srfi srfi-1)
> +                         (srfi srfi-26)
> +                         (ice-9 regex)
> +                         (ice-9 match))

[...]

Wow, this might be one of the longest package definitions in Guix :)

I can't review it in detail but if it's working for you, okay. Just make
sure to run `./pre-inst-env guix lint java-openjfx-graphics` and fix any
cosmetic issues.

Maybe some of the Guix Java experts can give it a closer review...