From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44975) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9KDd-0007hv-5U for guix-patches@gnu.org; Tue, 03 Mar 2020 21:57:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9KDY-0002Zf-MI for guix-patches@gnu.org; Tue, 03 Mar 2020 21:57:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34233) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9KDV-0002Yy-QO for guix-patches@gnu.org; Tue, 03 Mar 2020 21:57:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9KDV-00039D-Nu for guix-patches@gnu.org; Tue, 03 Mar 2020 21:57:01 -0500 Subject: [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful patch. Resent-Message-ID: Date: Tue, 3 Mar 2020 21:56:07 -0500 From: Leo Famulari Message-ID: <20200304025607.GA1199@jasmine.lan> References: <20200222201755.50425-1-levenson@mmer.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200222201755.50425-1-levenson@mmer.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alexey Abramov Cc: 39742@debbugs.gnu.org Hi, Thanks for these patches and sorry for the delay in review! There are a lot of patches and it takes a while to get through them. On Sat, Feb 22, 2020 at 09:17:49PM +0100, Alexey Abramov wrote: > * gnu/packages/java.scm: Add patch > * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New > file. Allows you to run gradlew to run properly. Useful for debugging. The commit message needs a couple changes, to something like this: ------ * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/java.scm (java-openjfx-build)[source]: Use it. ------ We don't need to describe the patch in the commit message. Instead, we explain it in a comment at the beginning of the patch file itself. This is easier for the people that will read the patch later. The comment should explain what the patch does and where it came from, including links to bug reports and external patch sources, if they exist. We need to register the new patch file in 'gnu/local.mk', so that it gets distributed in the Guix release process. And finally, we need to name the package variable (java-openjfx-build) that the patch is being used by. Here is an example from an older commit: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ca5e404f9a1ff81a38a32578c9c3a6c866482a9a