* [bug#39880] [PATCH] gnu: python-keras: Fix tests.
@ 2020-03-03 9:22 Pierre Neidhardt
2020-03-03 10:17 ` Efraim Flashner
2020-03-03 10:38 ` [bug#39880] [PATCHv2] " Pierre Neidhardt
0 siblings, 2 replies; 6+ messages in thread
From: Pierre Neidhardt @ 2020-03-03 9:22 UTC (permalink / raw)
To: 39880
* gnu/packages/machine-learning.scm (python-keras)[origin]: Add patch to
remove unstable selu test.
* gnu/local.mk: Include patch.
---
gnu/local.mk | 1 +
gnu/packages/machine-learning.scm | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gnu/local.mk b/gnu/local.mk
index 857345cfad..e5922aae54 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1329,6 +1329,7 @@ dist_patch_DATA = \
%D%/packages/patches/python-configobj-setuptools.patch \
%D%/packages/patches/python-faker-fix-build-32bit.patch \
%D%/packages/patches/python-keras-integration-test.patch \
+ %D%/packages/patches/python-keras-selu-test.patch \
%D%/packages/patches/python-pep8-stdlib-tokenize-compat.patch \
%D%/packages/patches/python-pyfakefs-remove-bad-test.patch \
%D%/packages/patches/python-flint-includes.patch \
diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 8262a418cc..7fbdef0163 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -1863,7 +1863,9 @@ with image data, text data, and sequence data.")
(origin
(method url-fetch)
(uri (pypi-uri "Keras" version))
- (patches (search-patches "python-keras-integration-test.patch"))
+ (patches
+ (search-patches "python-keras-selu-test.patch" ; Numerically unstable?
+ "python-keras-integration-test.patch"))
(sha256
(base32
"1j8bsqzh49vjdxy6l1k4iwax5vpjzniynyd041xjavdzvfii1dlh"))))
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [bug#39880] [PATCH] gnu: python-keras: Fix tests.
2020-03-03 9:22 [bug#39880] [PATCH] gnu: python-keras: Fix tests Pierre Neidhardt
@ 2020-03-03 10:17 ` Efraim Flashner
2020-03-03 10:38 ` Pierre Neidhardt
2020-03-03 10:38 ` [bug#39880] [PATCHv2] " Pierre Neidhardt
1 sibling, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2020-03-03 10:17 UTC (permalink / raw)
To: Pierre Neidhardt; +Cc: 39880
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
You forgot to add the patch :P
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#39880] [PATCHv2] gnu: python-keras: Fix tests.
2020-03-03 9:22 [bug#39880] [PATCH] gnu: python-keras: Fix tests Pierre Neidhardt
2020-03-03 10:17 ` Efraim Flashner
@ 2020-03-03 10:38 ` Pierre Neidhardt
2020-03-03 11:44 ` Efraim Flashner
1 sibling, 1 reply; 6+ messages in thread
From: Pierre Neidhardt @ 2020-03-03 10:38 UTC (permalink / raw)
To: 39880
* gnu/packages/machine-learning.scm (python-keras)[origin]: Add patch to
remove unstable selu test.
* gnu/local.mk: Include patch.
* gnu/packages/patches/python-keras-selu-test.patch: New file.
---
gnu/local.mk | 1 +
gnu/packages/machine-learning.scm | 4 ++-
.../patches/python-keras-selu-test.patch | 35 +++++++++++++++++++
3 files changed, 39 insertions(+), 1 deletion(-)
create mode 100644 gnu/packages/patches/python-keras-selu-test.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index 857345cfad..e5922aae54 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1329,6 +1329,7 @@ dist_patch_DATA = \
%D%/packages/patches/python-configobj-setuptools.patch \
%D%/packages/patches/python-faker-fix-build-32bit.patch \
%D%/packages/patches/python-keras-integration-test.patch \
+ %D%/packages/patches/python-keras-selu-test.patch \
%D%/packages/patches/python-pep8-stdlib-tokenize-compat.patch \
%D%/packages/patches/python-pyfakefs-remove-bad-test.patch \
%D%/packages/patches/python-flint-includes.patch \
diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 8262a418cc..7fbdef0163 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -1863,7 +1863,9 @@ with image data, text data, and sequence data.")
(origin
(method url-fetch)
(uri (pypi-uri "Keras" version))
- (patches (search-patches "python-keras-integration-test.patch"))
+ (patches
+ (search-patches "python-keras-selu-test.patch" ; Numerically unstable?
+ "python-keras-integration-test.patch"))
(sha256
(base32
"1j8bsqzh49vjdxy6l1k4iwax5vpjzniynyd041xjavdzvfii1dlh"))))
diff --git a/gnu/packages/patches/python-keras-selu-test.patch b/gnu/packages/patches/python-keras-selu-test.patch
new file mode 100644
index 0000000000..68092d2593
--- /dev/null
+++ b/gnu/packages/patches/python-keras-selu-test.patch
@@ -0,0 +1,35 @@
+Disable unstable SELU test.
+See https://github.com/keras-team/keras/issues/13856.
+
+diff --git a/tests/keras/activations_test.py b/tests/keras/activations_test.py
+index 4c0bb36..5808c0f 100644
+--- a/tests/keras/activations_test.py
++++ b/tests/keras/activations_test.py
+@@ -208,24 +208,6 @@ def test_elu():
+ assert_allclose(result, true_result)
+
+
+-def test_selu():
+- x = K.placeholder(ndim=2)
+- f = K.function([x], [activations.selu(x)])
+- alpha = 1.6732632423543772848170429916717
+- scale = 1.0507009873554804934193349852946
+-
+- positive_values = get_standard_values()
+- result = f([positive_values])[0]
+- assert_allclose(result, positive_values * scale, rtol=1e-05)
+-
+- negative_values = np.array([[-1, -2]], dtype=K.floatx())
+-
+- result = f([negative_values])[0]
+- true_result = (np.exp(negative_values) - 1) * scale * alpha
+-
+- assert_allclose(result, true_result)
+-
+-
+ def test_tanh():
+ test_values = get_standard_values()
+
+--
+2.25.1
+
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-03 11:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-03 9:22 [bug#39880] [PATCH] gnu: python-keras: Fix tests Pierre Neidhardt
2020-03-03 10:17 ` Efraim Flashner
2020-03-03 10:38 ` Pierre Neidhardt
2020-03-03 10:38 ` [bug#39880] [PATCHv2] " Pierre Neidhardt
2020-03-03 11:44 ` Efraim Flashner
2020-03-03 11:56 ` Pierre Neidhardt
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).