From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54419) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8W0K-0001vp-Cz for guix-patches@gnu.org; Sun, 01 Mar 2020 16:20:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8W0I-0004ah-5S for guix-patches@gnu.org; Sun, 01 Mar 2020 16:20:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59303) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j8W0I-0004aV-2L for guix-patches@gnu.org; Sun, 01 Mar 2020 16:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j8W0H-0007vV-UD for guix-patches@gnu.org; Sun, 01 Mar 2020 16:20:01 -0500 Subject: [bug#39814] [PATCH] gnu: anki: Fix mpv audio playback Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:54363) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8Vzj-0001sh-7i for guix-patches@gnu.org; Sun, 01 Mar 2020 16:19:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8Vzf-0004Oy-Lp for guix-patches@gnu.org; Sun, 01 Mar 2020 16:19:27 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:56028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j8Vzf-0004OS-Cg for guix-patches@gnu.org; Sun, 01 Mar 2020 16:19:23 -0500 Date: Sun, 1 Mar 2020 22:20:08 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200301212008.m25dqyny6pgebzrg@gravity> References: <20200227200909.16365-1-robertsmith@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i6dm5zgoqlhzjhvd" Content-Disposition: inline In-Reply-To: <20200227200909.16365-1-robertsmith@posteo.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Robert Smith Cc: 39814@debbugs.gnu.org --i6dm5zgoqlhzjhvd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 27, 2020 at 09:09:09PM +0100, Robert Smith wrote: > * gnu/packages/patches/anki-mpv-args.patch: New file. > * gnu/packages/education.scm (anki): Adjust accordingly. Please add the new file to gnu/local.mk > @@ -779,6 +780,9 @@ adjust the level of difficulty.") > (wrap-program program > `("QTWEBENGINEPROCESS_PATH" = > (,qtwebengineprocess)) > + `("PATH" prefix (,(string-append > + (assoc-ref inputs "mpv") > + "/bin"))) > `("PYTHONPATH" = ,site-packages))) > (find-files bin "."))) > #t))))) Please mention this in the commit message. > diff --git a/gnu/packages/patches/anki-mpv-args.patch b/gnu/packages/patches/anki-mpv-args.patch > new file mode 100644 > index 0000000000..a66632c0e0 > --- /dev/null > +++ b/gnu/packages/patches/anki-mpv-args.patch > @@ -0,0 +1,30 @@ > +From 0e2c723f2b920f96937725a12e3db13c14795117 Mon Sep 17 00:00:00 2001 > +From: Robert Smith > +Date: Thu, 27 Feb 2020 20:07:08 +0100 > +Subject: [PATCH] Fix mpv argument formatting > + > +--- > +mpv now requires that the input-ipc-server argument be passed with an > +equals sign and without any spaces. This is a slightly out-of-date > +version of anki, so presumably mpv used to be more lenient with > +command line arguments. > +--- > + anki/mpv.py | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) I don't know how I feel about this header for the patch. > +--- a/anki/mpv.py > ++++ b/anki/mpv.py > +@@ -104,7 +104,7 @@ class MPVBase: > + """ > + self.argv = [self.executable] > + self.argv += self.default_argv > +- self.argv += ["--input-ipc-server", self._sock_filename] > ++ self.argv += ["--input-ipc-server=" + self._sock_filename] > + if self.window_id is not None: > + self.argv += ["--wid", str(self.window_id)] It seems that this is not the only place that should be modified, considering the upstream commit that fixes the same issue: https://github.com/ankitects/anki/commit/ccd715013609133c55e83924734efa78abc03326 --i6dm5zgoqlhzjhvd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5cJwgACgkQ4xWnWEYT FWSW0BAAwjYywI6/HaeiYylit4TvFZ1dp+m5SQLkPoAasXBrWfCNCyYz3aseZNes sSODRja3NPZWLYn9lG9rlwU/0K/gH6a9u+v3tlcTot8sXrpy2pMmoY3/Xwz+mYSB 5Cz88AfmZsru48YP0EVnPIf1asbjdJEIEqVZc8CXPQBWn/tmdFo0Jz1eJFnkwaQE Z2MSxWs+RV5I0IESlU3qBX/T4V0bMMjUu2GDBMyjvZH9A3wphA77MsKkqBl0fVEZ mfAl7zFO6nqlbKH1QtD6froz6tZ9VDYxp9fdLjs3F3OkDVLwisgwJnZKdqZn3fpz 06/GMtI2KuV11KsO9zbbZ5HC01NQLZcVy5JhpZVDb6VFogZzz9NmX9EHSGA27dlx cYBYKZEwrZaowhF8mNT0JyVVCRJ/4BS2hKdD9oKcB7w1ybkmXQfhvmRmna8VEsBS lKKoU26CdgQ7UZ6xouWWc5HGvE5zT7/e1/YymptpBH7mN643tX7MKwzOt9PrR89+ ww1fnnmgUGDUGQNy+1H6vKWU8ObQoSzgHYBiyrwUw3YwZqQrO0kH1INYsmnny3rm uUOHvUK4S3z8n+uzOoKBNmNYqQGv9BU/nYUFF7tg/SK9YS9OuPvZQzo3Z+dvbO1W Nyf13KekKNrWgyBQbqtQo+Oxz/iyrHMwUttPXbvpWohdAuX/uzY= =fsjw -----END PGP SIGNATURE----- --i6dm5zgoqlhzjhvd--