From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:49556) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j74lk-000232-Jv for guix-patches@gnu.org; Wed, 26 Feb 2020 17:03:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j74lj-000828-6e for guix-patches@gnu.org; Wed, 26 Feb 2020 17:03:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j74li-00081I-AB for guix-patches@gnu.org; Wed, 26 Feb 2020 17:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j74li-0001ys-6s for guix-patches@gnu.org; Wed, 26 Feb 2020 17:03:02 -0500 Subject: [bug#39784] [PATCH] Add zlfo. Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:49487) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j74lR-0001rX-Ce for guix-patches@gnu.org; Wed, 26 Feb 2020 17:02:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j74lP-0007k8-HD for guix-patches@gnu.org; Wed, 26 Feb 2020 17:02:44 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:60152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j74lP-0007Vs-7a for guix-patches@gnu.org; Wed, 26 Feb 2020 17:02:43 -0500 Date: Wed, 26 Feb 2020 23:03:20 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200226220320.qfog7rmaqsglx2dg@gravity> References: <0f84534047c834937c210429116d686bc159e8a3.camel@zrythm.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ytfptfebvehglb2o" Content-Disposition: inline In-Reply-To: <0f84534047c834937c210429116d686bc159e8a3.camel@zrythm.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alexandros Theodotou Cc: 39784@debbugs.gnu.org --ytfptfebvehglb2o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 25, 2020 at 03:06:38PM +0000, Alexandros Theodotou wrote: > Hi, >=20 > This is a new LV2 plugin. It uses Ztoolkit for its UI so I packaged > that separately. Hi, could you send your patches inline, instead of as an attachment? It makes reviews easier. The workflow on your side is easier too, since you only need to `git send-email` (available as git:send-email in guix). It's fine if you prefer not to do this, though. > * gnu/packages/audio.scm (ztoolkit): New variable. > --- > gnu/packages/audio.scm | 43 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) I'm not sure if audio.scm is the best place for a GUI toolkit. It might be fine since audio plugins are the primary usecase, but I'm not sure. > +(define-public ztoolkit > + (package > + (name "ztoolkit") > + (version "0.1.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.zrythm.org/git/ztoolkit") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "07xl3cmdaf7k9mm58m93cn8i1jvgimmiifdw1w7v2jl88nx60pm1")))) Please run etc/indent-code.el on your packages. > + (build-system meson-build-system) > + (propagated-inputs > + `(("cairo" ,cairo) > + ("libx11" ,libx11))) Why are these propagated-inputs? I would've thought that these dependencies get linked into the binary, so they don't need to propagate to the user's profile. > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("git" ,git))) Why the dependency on git? The package seems to build fine without it. > + (synopsis "GUI toolkit for LV2 plugins") > + (description "ZToolkit (Ztk) is a cross-platform GUI toolkit heavily > +inspired by GTK. It handles events and low level drawing on behalf of > +the user and provides a high-level API for managing the UI and custom > +widgets. ZToolkit is written in C and was created to be used for buildi= ng > +audio plugin UIs, where the dependencies often need to be kept to a > +minimum.") > + (home-page "https://git.zrythm.org/cgit/ztoolkit/") > + (license license:agpl3+))) > +(define-public zlfo > + (package > + (name "zlfo") > + (version "0.1.3") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.zrythm.org/git/ZLFO") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0bm466ci5xyvxvq7l9p6xyh789lvk6i31b4zja1igqh13akbjnjz")))) > + (build-system meson-build-system) > + (inputs > + `(("ztoolkit-rsvg" ,ztoolkit-rsvg))) > + (native-inputs > + `(("git" ,git) Same question as above. > + ("lv2" ,lv2) > + ("pkg-config" ,pkg-config))) > + (synopsis "LFO plugin") That's quite blunt, and impenetrable for non-domain-experts. Is there really nothing more you could say about the package? Perhaps expand the acronym? > + (description "ZLFO is a fully featured LFO for CV-based automation > +that comes as a cross-platform LV2 plugin bundle with a custom UI.") Consider using Texinfo's @acronym. > + (home-page "https://git.zrythm.org/cgit/ZLFO/") > + (license license:agpl3+))) --ytfptfebvehglb2o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5W6ycACgkQ4xWnWEYT FWRFFw//TgpQQAiCWjQlMbX2KAkIA6+f3kqETCJQfokHKV/D7N/4N/3ybEUgIoU3 Hrswg3zcnY7wMTwT3NuegBD2YiczbIa+Vz6OcZ6ilW/rAVp5cDEfzkX5+otoU6FC +4ndF5ZCiDn62ebg1iK9lLzNNP4H60CUTLRK0WfQ4cVQzC+yDY+J6z+FD0CeYhBr 6l5knop2hX44MWyKKZN/+jOuSXR12QWEPVutsorrpeIjSv6CF6ZSxiv5qCRXfRh2 pepmr/5LdcWeHbRr5fZXwYyNmwJF0kJA+MPTWhRmcZGsc6jd5JHu+ws/OkW5kjEA rwC6JflU0D9ScW0rfJ3crScg+9bBnRzHkrWd9fxbfsQnXligQhA2NQu03MiV2w5e eHjoy82QCAx5elmg63ORHzbhAcAKbCbkCDolZ2hCEjpLg5EU6+3UsmsoOQbmEzgG CZxNtuelf95uNnnHsnuFP40RKPZ0tUxMTCyJL11OSL0HkiesqNJHU/DBkibdW/qt Pt0A4EJEkr8ZiIxV9e7e0f51WcIJXYEXT3Pwof6Sl4qEH+Xri25tEbnVz4Km86cO 1izR/phXo86LFH6r6C5sSeieiXqdCc13kgDijrtF5gAQRXSL/xWm3FecMgYmdxb2 pmDJVzyuzekBnDHfF14INDTsJESLF6feDAnGkzmBLFE9Z6w8QjU= =62ba -----END PGP SIGNATURE----- --ytfptfebvehglb2o--