From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34529) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5ubs-0003SK-Mr for guix-patches@gnu.org; Sun, 23 Feb 2020 12:00:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5ubr-0005zA-Cy for guix-patches@gnu.org; Sun, 23 Feb 2020 12:00:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45587) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5ubr-0005z3-9t for guix-patches@gnu.org; Sun, 23 Feb 2020 12:00:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5ubr-0000kr-A8 for guix-patches@gnu.org; Sun, 23 Feb 2020 12:00:03 -0500 Subject: bug#39754: [PATCH v2] gnu: z3: Build the Python bindings Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Sun, 23 Feb 2020 17:59:56 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200223165956.fwhqktyn4z5exnrr@gravity> References: <20200223151410.30739-1-kuba@kadziolka.net> <20200223163245.10253-1-kuba@kadziolka.net> <871rqls0zz.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2jxbn4smmlux4g5q" Content-Disposition: inline In-Reply-To: <871rqls0zz.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 39754-done@debbugs.gnu.org --2jxbn4smmlux4g5q Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 23, 2020 at 05:48:48PM +0100, Ludovic Court=C3=A8s wrote: > Hi! >=20 > Jakub K=C4=85dzio=C5=82ka skribis: >=20 > > * gnu/packages/maths.scm (z3)[arguments]: Add the --python and > > --pypkgdir flags to configure. >=20 > Could you also mention the addition of #:modules and #:imported-modules? Sure thing! >=20 > > Changed the #:modules argument to only import site-packages from (guix > > build python-build-system) as, as Ludo' pointed out on IRC, it also > > exports %standard-phases, which could conflict with (guix build > > gnu-build-system). > > > > I considered putting the Python bindings in a separate output; I decide= d not to > > do so as this change increases `guix size z3' from 116.4 MiB to 117.5 > > MiB, which is barely noticeable. >=20 > Makes sense to me. >=20 > LGTM, thanks! Thanks! Pushed: commit f6b4d395fd321d43fd548ba832c78320ac3f8d51 Author: Jakub K=C4=85dzio=C5=82ka Date: Sun Feb 23 16:11:30 2020 +0100 gnu: z3: Build the Python bindings * gnu/packages/maths.scm (z3)[arguments]: Add the --python and --pypkgdir flags to configure. To facilitate the latter, add (guix build python-build-system) to #:modules and #:imported-modules. --2jxbn4smmlux4g5q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5Sr4sACgkQ4xWnWEYT FWQbqA//YVd0G1XBEXLDqF7UviGpPaBeNKUa7YtSWDfMlHldhUYKqcBhPu669zXL XYVeOoc01ButyGVjyCFmuqDE/lapsho0iyNjnoUZdMSu4iljPVz/CRbect+63W0F eneokeoiSs3BT/szymNDBLGj/bah17/LdDgGcLFFaj68vJy4+MnLs3outQBM6nje 4Yp3SFqMK5xJGqwWvx1TmChl8zOwFy/SpR6yc7yK9SAvXgVaSa944pS47ZFwM/5n 1b7jgxXarTy3Ja/9WbdQaN6Jldmb8t5RUYOzLMSEwW/1mqLeq6ONNPPf1GLWweso f6sYyoC4Ls/MD0WDWo9ecKLwSwy6zRFama6n1HFQsvc2NBbT71LOw0OBlyh4RN8p kjo+0okvfbyNBRZCu1KhSFaMEWI4lN9hxfFY8J/41rmcGOjK6fJoeSa4r4LuXY98 Ffb++aoo6IVaGG7uNwWgnj8KrJ9HnyQAJMNHMjwWtROZnsaHRzYl7pCO5GH8giac fkdM+Wi+K/ESNrF5BThvwJJSX57XWVr9we87q545XtSGxpotTZQmzqFUMFsh09SF UE+RkLsHXPITNAEip5QcewAtQQakfXekWwMzg+wE4yonCfn7hez0t4YeZqIJcH7m ZTDjxsrDkVuHDi+KDtEzWJqsdA42U2KrKhv6DubL7oWoAZU2PwE= =Ae/d -----END PGP SIGNATURE----- --2jxbn4smmlux4g5q--