From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:53253) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4qxY-0002kX-SE for guix-patches@gnu.org; Thu, 20 Feb 2020 13:54:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4qxW-0008C6-RN for guix-patches@gnu.org; Thu, 20 Feb 2020 13:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39890) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4qxV-0008BY-Tu for guix-patches@gnu.org; Thu, 20 Feb 2020 13:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4qxV-0001bb-Rd for guix-patches@gnu.org; Thu, 20 Feb 2020 13:54:01 -0500 Subject: [bug#38408] [PATCH v9 0/8] recursive semver crate importer! Resent-Message-ID: Date: Thu, 20 Feb 2020 13:53:10 -0500 From: Leo Famulari Message-ID: <20200220185310.GA12545@jasmine.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Martin Becze Cc: 38408@debbugs.gnu.org, ludo@gnu.org, efraim@flashner.co.il, jsoo1@asu.edu On Tue, Feb 04, 2020 at 07:18:17AM -0500, Martin Becze wrote: > Here is the another version of the recursive semver crate importer! And hopefully the best one so far. The first 3 commits actully implement the and add semver support. The rest are mainly ergonomics such as > * triming version numbers from package name > * better deduplication of dependencies > * top level importing of development dependenies Wow, this is great! It makes it possible to get a (very close to) working rav1e package. The only things really missing are non-Rust dependencies of rav1e but I think that is not in scope for your importer. > I think it has incorpated the feedback i got from everyone so far, but if i forgot something or if there is more to add let me know! A minor bug: Sometimes if a dependency is already existing, the importer will construct its variable name incorrectly. For example, some of the packages I imported require version 2.33 of rust-clap. We already have this package, and the variable is named 'rust-clap-2', but the importer makes the packages depend on 'rust-clap-2.33'. It has to be adjusted by hand. You should be able to reproduce the bug with the following command. It doesn't matter if guile-semver is a hard dependency or autoloaded. `guix environment guix --ad-hoc guile-json guile-semver -- ./pre-inst-env guix import crate --recursive rav1e` Also, it prints the skip-build? argument on multiple lines, like this... #:skip-build? #t