From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44515) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2PYS-0005re-Dw for guix-patches@gnu.org; Thu, 13 Feb 2020 20:14:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2PYQ-0003Pi-RC for guix-patches@gnu.org; Thu, 13 Feb 2020 20:14:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54732) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2PYQ-0003PU-KJ for guix-patches@gnu.org; Thu, 13 Feb 2020 20:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j2PYQ-0004uX-Fx for guix-patches@gnu.org; Thu, 13 Feb 2020 20:14:02 -0500 Subject: bug#39365: [PATCH 1/6] gnu: Add qrcodegen-cpp. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Thu, 13 Feb 2020 20:13:42 -0500 From: Leo Famulari Message-ID: <20200214011342.GA26096@jasmine.lan> References: <20200131030509.GA13436@jasmine.lan> <20200131085851.GE9517@E5400> <871rqy2kns.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <871rqy2kns.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 39365-done@debbugs.gnu.org, Efraim Flashner On Thu, Feb 13, 2020 at 11:21:27PM +0100, Ludovic Courtès wrote: > Hi, > > Efraim Flashner skribis: > > >> + (description "qrcodegen-cpp is a QR code generator library in C++. The > >> +project also offers Java, Javascript, Python, C, and Rust implementations.") > > > > You can drop the comma after C if you want. > > Actually no, it would have a different meaning, from what I learned > (namely, the last part would mean “implementations in/of C and Rust”, > instead of “implementations in/of Rust”.) > > More importantly though: apart from the missing patch and ‘gnu/local.mk’ > bit that were reported, the series LGTM. > > Thanks, Leo! Thanks for the reminder about these patches! Pushed as 1ce2467fd6d5f8da259be1c7609702814c716702