From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50478) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1DxX-0007Jj-93 for guix-patches@gnu.org; Mon, 10 Feb 2020 13:39:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1DxW-0008RB-C5 for guix-patches@gnu.org; Mon, 10 Feb 2020 13:39:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49417) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1DxV-0008QZ-L8 for guix-patches@gnu.org; Mon, 10 Feb 2020 13:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1DxV-0006sn-JX for guix-patches@gnu.org; Mon, 10 Feb 2020 13:39:01 -0500 Subject: [bug#39146] [PATCH v2] gnu: icecat: Remove compiler paths from about:buildconfig Resent-Message-ID: Date: Mon, 10 Feb 2020 19:38:31 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200210183831.7evt4ci6r3qtgfm5@gravity> References: <20200115222115.322ymuuqkwlnbl3v@zdrowyportier.kadziolka.net> <20200121173711.5gegrl233dtjneni@zdrowyportier.kadziolka.net> <20200121185202.4cfbdc37@scratchpost.org> <87muaf6v81.fsf@netris.org> <20200123083738.c5wd3mx2bk3a5xy7@zdrowyportier.kadziolka.net> <87k15h7eeg.fsf@netris.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ycerfm2yodxrgg4e" Content-Disposition: inline In-Reply-To: <87k15h7eeg.fsf@netris.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mark H Weaver Cc: Danny Milosavljevic , Marius Bakke , Tobias Geerinckx-Rice , 39146@debbugs.gnu.org --ycerfm2yodxrgg4e Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 23, 2020 at 09:53:48PM -0500, Mark H Weaver wrote: > I like the approach of Tobias' proposed patch, but to avoid losing > information (most of the hash), how about changing: >=20 > (string-append store (string-take hash 8) "=E2=80=A6") >=20 > to something like: >=20 > (string-append store (string-take hash 2) "." (string-drop hash 2)) >=20 > What do you think? Anyway, I don't feel strongly about it, and I > acknowledge that neither approach is perfect. I feel like the unicode character "=E2=80=A6" makes it much more clear that= the path has been modified, but it's a moot point considering that if someone might get confused by this, they probably won't be able to make use of the hash. However, now that I come back to this after some time, I realize that there is another solution: (string-append store (string-take hash 8) "" (string-drop hash 8)) This would neuter the reference without having any user-visible impact on about:buildconfig. What do you think? Kind regards, Jakub K=C4=85dzio=C5=82ka --ycerfm2yodxrgg4e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5BoyMACgkQ4xWnWEYT FWQ5YA//bTFb7ANKOwiwUoi+zlTZtGAHUs/QjXBoRePlyoLWjHz4Z+VELvYBMsdN 0pgJ74WyrbNomSYM1liR+VzpvOuzM+8vR5HaNYCBoSViDDTlDYaiwaE7f+RBayr+ BBzyOlR9eHsHL42JRkzJwbjkCuNqRlsdw1znZRMo/uhPsqXnV3hidM+olZsdIgfJ Dc3zWbAElz/zPIlk4YeKefzT3d3wh1ksFpKrwOXORiTkPK7SmdXTnsQ4UIwEmJ9q Z78QweguWsjIeFBkGoSoVDWUQpxx2szJSHBP7Hty0Y/cdqTaqkzSkwFh78LzpYEh 08wi7R8P6WHKQiu978BPwQv/BDTZI90VvjcbWM+dSq+gFQ72/r/Y5Bo9Ir9fhz/h IeuNPCBQimoD6CgcH4cxxCuEiaDoySUYsWJ8NRdQ4wrGMagKcHvNPlCULogDSOdx 3+vzMHvNBKY9+v9FzJQEIDRpoh2KKsteouXHgIZOnVJAPsLkDMP8CIFLM0mIQ94A 5DbVFcxYNR+QIT+o+B4Vq3TNBZgb3K+KDkQRrh5u+kSesKOFt2vIQ0uRoncdXzxc wtm8Ih01hCCITxtMHdd7Ow5nHxg9Qvk75SazEhti49Xxqhrk1KUmExqhMmb/R6vw pbLjipBcxvLK+TmK5Lh57nKyHOQ3I8zoMIysQ0x60XxlxsRMkMc= =tlHT -----END PGP SIGNATURE----- --ycerfm2yodxrgg4e--