From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:40445) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0nc1-0002pE-JK for guix-patches@gnu.org; Sun, 09 Feb 2020 09:31:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0nbz-0005Sf-0x for guix-patches@gnu.org; Sun, 09 Feb 2020 09:31:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46264) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j0nby-0005SM-F4 for guix-patches@gnu.org; Sun, 09 Feb 2020 09:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j0nby-00047k-BA for guix-patches@gnu.org; Sun, 09 Feb 2020 09:31:02 -0500 Subject: [bug#39372] Chicken Scheme: Update version to 5.1.0 and add gcc-toolchain Resent-Message-ID: Date: Sun, 9 Feb 2020 15:30:42 +0100 From: Julien Lepiller Message-ID: <20200209153042.31f2d723@tachikoma.lepiller.eu> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ekaitz Zarraga Cc: "39372@debbugs.gnu.org" <39372@debbugs.gnu.org> Le Sun, 09 Feb 2020 14:11:09 +0000, Ekaitz Zarraga a =C3=A9crit : > > I suppose this is caused by a module loop or something between (gnu > > packages scheme) and (gnu packages commencement). Maybe splitting > > (gnu packages scheme) into two things (maybe a new (gnu packages > > chicken)) would solve the issue? =20 >=20 > I think it does. I made a new patch with that but I'm not sure if I > did everything right: This is almost correct. You should make it two patches: the first moves chicken to its own module, the second updates it. Make sure to add the licence in the new file with a copyright line for yourself. The commit message should be: gnu: chicken: Move to a separate module. * gnu/packages/scheme.scm (chicken): Move to chicken.scm. * gnu/packages/chicken.scm: New file. * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. for the first patch and: gnu: chicken: Update to 5.1.0. * gnu/packages/chicken.scm (chicken): Update to 5.1.0. [propagated-inputs]: Add gcc-toolchain. for the second patch. This makes it clearer what happens. You can find a lot of examples from 'git log'. Since no other package depends on chicken, we're all good I think.