From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56692) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0mex-0007PI-Vd for guix-patches@gnu.org; Sun, 09 Feb 2020 08:30:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0mew-00066U-QO for guix-patches@gnu.org; Sun, 09 Feb 2020 08:30:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46215) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j0mew-00066F-Mq for guix-patches@gnu.org; Sun, 09 Feb 2020 08:30:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j0mew-0002eN-IC for guix-patches@gnu.org; Sun, 09 Feb 2020 08:30:02 -0500 Subject: [bug#39384] [PATCH] gnu: Add emacs-rg. Resent-Message-ID: Date: Sun, 9 Feb 2020 15:28:41 +0200 From: Efraim Flashner Message-ID: <20200209132841.GA9296@E5400> References: <878slmc640.fsf@nicolasgoaziou.fr> <87pnexrrwf.fsf@lafreniere.xyz> <20200202184757.GH9517@E5400> <87o8ugs5fu.fsf@lafreniere.xyz> <20200204095851.GA19864@E5400> <87mu9xspd0.fsf@lafreniere.xyz> <87lfpg4t3t.fsf@devup.no> <87lfpfrzok.fsf@lafreniere.xyz> <20200207105435.GG7827@E5400> <87h800soqr.fsf@lafreniere.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: <87h800soqr.fsf@lafreniere.xyz> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: "LaFreniere, Joseph" Cc: 39384@debbugs.gnu.org, Marius Bakke , Nicolas Goaziou --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 08, 2020 at 04:23:08PM -0600, LaFreniere, Joseph wrote: >=20 > Efraim Flashner writes: > > On Thu, Feb 06, 2020 at 06:47:23PM -0600, LaFreniere, Joseph wrote: > > >=20 > > > Marius Bakke writes: > > > > "LaFreniere\, Joseph" writes: > > > > > Ah, I see what you mean now. But wouldn't hard-coding the > > > > > path to > > > > > ripgrep in that way prevent the package from being able to > > > > > use > > > > > remote systems' ripgrep binaries when running over TRAMP? > > > > > > > > Perhaps we could patch [emacs-rg] to do both? Use the store > > > > prefix if > > > > it > > > > exists, and fall back to searching in PATH? > > >=20 > > > What would be the advantage of that over just searching PATH to > > > start with? > >=20 > > It will still work even if you don't have ripgrep specifically > > installed. >=20 > Can you point me to the Guix documentation where the functionality you're > describing is explained? I have read through the description of package > inputs in section 6.2.1 of Guix's manual, but I still do not explain what > advantage patching the search path offers. I'm not sure I can find a spot in the manual where it is detailed. It comes down to the difference between "search for this program in PATH" and "call this program located at this location". By calling the rg at it's exact path rg doesn't need to be installed directly. > My understanding is that if we want to preserve both local and > remote-via-TRAMP functionality, we can either > - just include ripgrep as a propagated input, or > - include ripgrep as a propagated input _and_ patch the package to look = for > ripgrep in a hardcoded location (for local) as well as PATH (for TRAMP). The second option is to include ripgrep as an input and patch the package to look for it at a hardcoded location (for local) as well as PATH (for TRAMP). > Both options would have ripgrep included as propagated input. As soon as > ripgrep is installed in a user's profile, its binary will be available on > PATH. If that is correct, then I don't see any advantage to patching in a > hardcoded path to ripgrep. >=20 > -- > Joseph LaFreniere --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5ACQgACgkQQarn3Mo9 g1FQIRAAkCP9tvujU2/ydzf9a1bZs5DE8PTQjNS5CvHpRr8g6vSDZ7njKufj6JyH UA5XT9T28Kh5dtUUSu0ncYsLxUrYaDTHXTalu4eN7HSwrPyRW6mCHijFih33VanL bGKU9n32WW7wsqrIGUUpHYEMueAS5qRQNGxvLJUDvzGzdlmksPr7K5GWEwgxTDRY KRUkS246Q9Izz6o0Uw5HXifYBcRgS051MDarKhhim1CeAWOH+xYDKyhx4NPxnj5t 8cAgoSZ2SphwFz+O/o0NScLb3CbgdvEjyxqXeA+Y1MgDvFDDSa5UA3tjBp35gyda diN2U2d8zDd1gvOReDs9XbzagXW1BrlqK3fqIF2QgMdkXMRdDWojHFnIwDoYoS+F XVvwSXeORdx8/vyA49m5+f/40pSl9TQayCyo3bXA2CEvBOqFbN76rbAifUe8x4du tsDWfPkcV7F0l8qgBCE8iEnpEX0kFLQqDVFLlrZlW4GJe0CIVasT7t9PZZ8kWTtg oYLWo7/48jAY7u61sQ8P5g3oinLeYXDE3oBbVP1boLdlq+hi2PBcc6af4PVNFF+R 2tQWqlTljdI7H2L+n1gGSWPw9RK7WuWGoiW13S48YSrhghaEPMiBpXzuRzaDvzaV WosCGPulnKcD3XtZAsy8ar8ySRj26xCcxsz/G6ha+IcXjCT6k1U= =dSJB -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--