From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:37231)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j0DPn-0004Ih-D2
 for guix-patches@gnu.org; Fri, 07 Feb 2020 18:52:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j0DPm-0007mQ-7H
 for guix-patches@gnu.org; Fri, 07 Feb 2020 18:52:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:44485)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j0DPm-0007m8-3b
 for guix-patches@gnu.org; Fri, 07 Feb 2020 18:52:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j0DPm-0006EZ-0q
 for guix-patches@gnu.org; Fri, 07 Feb 2020 18:52:02 -0500
Subject: [bug#39317] [PATCH v2] gnu: Add go 1.13.7.
Resent-Message-ID: <handler.39317.B39317.158111948823920@debbugs.gnu.org>
Date: Fri, 7 Feb 2020 18:51:11 -0500
From: Leo Famulari <leo@famulari.name>
Message-ID: <20200207235111.GC12194@jasmine.lan>
References: <20200130151948.iyvfykj72lxfylqc@zdrowyportier.kadziolka.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200130151948.iyvfykj72lxfylqc@zdrowyportier.kadziolka.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@kadziolka.net>
Cc: 39317@debbugs.gnu.org

On Thu, Jan 30, 2020 at 04:19:48PM +0100, Jakub Kądziołka wrote:
> * gnu/packages/golang.scm (go-source): Factor out the source fields of
>   all the go versions into a new helper function.
>   (go-1.4, go-1.12)[source]: Use go-source.
>   (go-1.13): New variable.

> +(define (go-source version hash)
> +  (origin
> +    (method url-fetch)
> +    (uri (string-append "https://storage.googleapis.com/golang/go"
> +                        version ".src.tar.gz"))
> +    (sha256 (base32 hash))))

There is always a trade-off between readability and time spent writing
code with this kind of helper function. Since there are only 3 Go
compiler packages, I'm not convinced it's necessary here.

We should switch to building the 1.4 bootstrap Go from Git — they make
changes in Git but don't always release a tarball. Then there would only
be two "current" Go packages.