unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#39447] [PATCH] gnu: Add python-gandi.cli.
@ 2020-02-06  3:13 Amin Bandali
  2020-02-13 22:25 ` Ludovic Courtès
  2020-02-13 23:25 ` bug#39447: " Tobias Geerinckx-Rice via Guix-patches via
  0 siblings, 2 replies; 3+ messages in thread
From: Amin Bandali @ 2020-02-06  3:13 UTC (permalink / raw)
  To: 39447; +Cc: Amin Bandali

* gnu/packages/python-xyz.scm (python-gandi.cli): New variable.
---
 gnu/packages/python-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index dcc1595446..2472890dae 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -69,6 +69,7 @@
 ;;; Copyright © 2019 Tanguy Le Carrour <tanguy@bioneland.org>
 ;;; Copyright © 2019 Mădălin Ionel Patrașcu <madalinionel.patrascu@mdc-berlin.de>
 ;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net>
+;;; Copyright © 2020 Amin Bandali <mab@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -17467,3 +17468,35 @@ extensive support of PNG features.  It can also read and write Netpbm PAM
 files, with a focus on its use as an intermediate format for implementing
 custom PNG processing.")
     (license license:expat)))
+
+(define-public python-gandi.cli
+  (package
+    (name "python-gandi.cli")
+    (version "1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "gandi.cli" version))
+       (sha256
+        (base32
+         "110wc9zgxsrvw4yzp21p0ian5lcf7vhcpxhnmsc4fg9pzl2bwxd5"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("git" ,git)
+       ("openssh" ,openssh)
+       ("openssl" ,openssl)
+       ("python-click" ,python-click)
+       ("python-ipy" ,python-ipy)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-requests" ,python-requests)
+       ("python-setuptools" ,python-setuptools)))
+    (native-inputs
+     `(("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-tox" ,python-tox)))
+    (home-page "https://github.com/Gandi/gandi.cli")
+    (synopsis "Gandi command line interface")
+    (description "Gandi CLI is a command line interface for creating and
+managing Gandi.net products (domains, certificates, servers, etc) using
+Gandi's public API.")
+    (license license:gpl3+)))
-- 
2.25.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#39447] [PATCH] gnu: Add python-gandi.cli.
  2020-02-06  3:13 [bug#39447] [PATCH] gnu: Add python-gandi.cli Amin Bandali
@ 2020-02-13 22:25 ` Ludovic Courtès
  2020-02-13 23:25 ` bug#39447: " Tobias Geerinckx-Rice via Guix-patches via
  1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2020-02-13 22:25 UTC (permalink / raw)
  To: Amin Bandali; +Cc: 39447

Hi,

Amin Bandali <mab@gnu.org> skribis:

> * gnu/packages/python-xyz.scm (python-gandi.cli): New variable.

LGTM, thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#39447: [PATCH] gnu: Add python-gandi.cli.
  2020-02-06  3:13 [bug#39447] [PATCH] gnu: Add python-gandi.cli Amin Bandali
  2020-02-13 22:25 ` Ludovic Courtès
@ 2020-02-13 23:25 ` Tobias Geerinckx-Rice via Guix-patches via
  1 sibling, 0 replies; 3+ messages in thread
From: Tobias Geerinckx-Rice via Guix-patches via @ 2020-02-13 23:25 UTC (permalink / raw)
  To: 39447-close, Amin Bandali

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

Amin,

Amin Bandali 写道:
> * gnu/packages/python-xyz.scm (python-gandi.cli): New variable.

Thanks!  This package is already in Guix as ‘gandi.cli’ — we avoid 
the ‘python-’ prefix for stand-alone programmes since being 
written in Python (or any other language) is irrelevant.

+    (propagated-inputs
+     `(("git" ,git)
+       ("openssh" ,openssh)
+       ("openssl" ,openssl)
+       ("python-click" ,python-click)
+       ("python-ipy" ,python-ipy)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-requests" ,python-requests)
+       ("python-setuptools" ,python-setuptools)))

Propagation should be avoided when possible, although it's (sadly) 
more common in Python packages than elsewhere.

However, propagating inputs like git, openssh, openssl, 
python-setuptools… is definitely wrong.  Was this deliberate? 
Which problem were you trying to solve?  Take a look at 
gandi.cli's ‘embed-store-file-names’ for a different approach that 
avoids propagation altogether.

I'm closing this bug, but please let me know if the existing 
gandi.cli is missing features.  I added it but haven't used it in 
a while.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-13 23:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-06  3:13 [bug#39447] [PATCH] gnu: Add python-gandi.cli Amin Bandali
2020-02-13 22:25 ` Ludovic Courtès
2020-02-13 23:25 ` bug#39447: " Tobias Geerinckx-Rice via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).