From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:37236)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iwLQk-0002Pp-Ox
 for guix-patches@gnu.org; Tue, 28 Jan 2020 02:37:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iwLQj-0007kg-QW
 for guix-patches@gnu.org; Tue, 28 Jan 2020 02:37:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:53420)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iwLQj-0007kN-NS
 for guix-patches@gnu.org; Tue, 28 Jan 2020 02:37:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iwLQj-0005fq-Kh
 for guix-patches@gnu.org; Tue, 28 Jan 2020 02:37:01 -0500
Subject: [bug#39192] [PATCH] gnu: hexedit: Make F1 help more reliable
Resent-Message-ID: <handler.39192.B39192.158019701921801@debbugs.gnu.org>
Date: Tue, 28 Jan 2020 08:36:53 +0100
From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@kadziolka.net>
Message-ID: <20200128073653.fvcvzitgphtuxzok@zdrowyportier.kadziolka.net>
References: <20200119124434.aatfpdm6ihiig354@zdrowyportier.kadziolka.net>
 <87mua8qxp7.fsf@devup.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87mua8qxp7.fsf@devup.no>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 39192@debbugs.gnu.org

On Tue, Jan 28, 2020 at 12:36:04AM +0100, Marius Bakke wrote:
> Jakub Kądziołka <kuba@kadziolka.net> writes:
> 
> > * gnu/packages/hexedit.scm (hexedit)[arguments](patch-man-path): New
> >   phase.
> >   [inputs]: Add MAN-DB.
> 
> While this change is harmless, I think we can generally expect "man" to
> be available.  Does the program crash if man-db is not installed?  Or
> does it print an actionable error message?
> 
> In the latter case I'm inclined to leave things as-is, in the former
> case let's patch it.  But no strong opinion, mostly curious :-)

Currently, the problem appears when hexedit is used in a `guix
environment', and man-db is not specified as an input for the
environment. In this case (assuming --pure hasn't been used), man prints
an error message saying "no manpage for hexedit" when the user presses
F1, but it cannot be seen until one exits hexedit. For a new user, this
is not a trivial feat. Moreover, the error is confusing - it suggests
that the manpage just hasn't been packaged.

When man isn't found at all, no error message is printed, the F1 key
just makes the screen blink. This could happen in a --pure environment.

In hindsight, this is something I should've explained in my first message.
Sorry about that.