From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35945) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivJea-0001mF-JK for guix-patches@gnu.org; Sat, 25 Jan 2020 06:31:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivJeY-0003am-Se for guix-patches@gnu.org; Sat, 25 Jan 2020 06:31:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49042) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivJeY-0003YY-AX for guix-patches@gnu.org; Sat, 25 Jan 2020 06:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ivJeY-0002No-6v for guix-patches@gnu.org; Sat, 25 Jan 2020 06:31:02 -0500 Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input. Resent-Message-ID: Date: Sat, 25 Jan 2020 12:30:27 +0100 From: Danny Milosavljevic Message-ID: <20200125123027.50a6ab1a@scratchpost.org> In-Reply-To: <871rro6iis.fsf@cbaines.net> References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> <871rro6iis.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/uw5eHZ8XpWtrHVD=+zrG1fG"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines , jgibbons2357@gmail.com Cc: 39275@debbugs.gnu.org --Sig_/uw5eHZ8XpWtrHVD=+zrG1fG Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, I'd prefer to change the subject to "gnu: vlc: Add MIDI support.". > It would be good to put something in the commit message about why this > is happening, as it's not obvious to me at least. I disagree in general because I've seen before what that leads to: Half the source code (the comments) end up in the commit messages instead. Eventually (because of some merge or something) those get lost, or (because of a new commit) those get hidden. Now someone is going to overlook it. So I'd put documentation into comments, except when it's ephemeral ("news"). Also, in the special case of Guix the reason why we add an input later is "we forgot to add it earlier and it was optional to the package and thus the package built" most of the time. So the commit message would always be "we forgot earlier". In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and nobody noticed. We could have the subject say "Add MIDI support" because it communicates mo= re clearly what this commit does for users. And that's the news :) --Sig_/uw5eHZ8XpWtrHVD=+zrG1fG Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4sJtMACgkQ5xo1VCww uqW6kgf+N9sb5cn0u0bbHONcvsSF8EDZsCFubO2yiQFvQ6TnV2WxWZEOOlI8LuNH Zuwhg3sFDarX9lp2ol3ZMb/rTrmKR7STm3NRFW4bZeVp8kQYxAt7VW5kl29oRR+n U77/9rNpyeOd0OOcfG6+6suumMWC2VSlw3DbjtcGrwFxJX0n+Z9y8EPn8/WqXW3p q82laSqg9X/z8e4FT17e8XQJJkBhPSzcEeT/R0ykxc02SDDVSal53EoRNoIuJZqJ 5/n/S7SXbtxU1DkEUHuDA/eajZZpif9pJIq/xy+sGHOSJ2vJqgpGQ26P7TEJCZ9p IPXYWDMUpMMTG0VOd/OCqyV85SZngg== =Nvop -----END PGP SIGNATURE----- --Sig_/uw5eHZ8XpWtrHVD=+zrG1fG--