From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:53051) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itSyi-0002qi-3T for guix-patches@gnu.org; Mon, 20 Jan 2020 04:04:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itSye-0008Ti-3w for guix-patches@gnu.org; Mon, 20 Jan 2020 04:04:11 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38367) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itSyY-0008RW-Ko for guix-patches@gnu.org; Mon, 20 Jan 2020 04:04:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itSyY-0006p1-HR for guix-patches@gnu.org; Mon, 20 Jan 2020 04:04:02 -0500 Subject: bug#39142: Update USB_ModeSwitch. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Mon, 20 Jan 2020 10:03:38 +0100 From: "pelzflorian (Florian Pelz)" Message-ID: <20200120090338.5otoyrppuhsp4p23@pelzflorian.localdomain> References: <20200115124810.j3myokleoa7le3sq@pelzflorian.localdomain> <87sgkdovdm.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sgkdovdm.fsf@cbaines.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 39142-done@debbugs.gnu.org On Sat, Jan 18, 2020 at 11:29:41AM +0000, Christopher Baines wrote: > > pelzflorian (Florian Pelz) writes: > > > This series updates USB_ModeSwitch and its data package to their > > November release. > > Both patches look good to me :) > Thank you for the review! Pushed as d0759f613480c13b8c81716eb46dc3606b3a34b0 and 17fe068ed7372dbae09043885b8f091105bef143. Closing this bug. > There's a somewhat uninformative comparison of Guix without these > patches, and Guix with these patches here [1]. > > 1: https://guix-patches-data.cbaines.net/compare?base_commit=9edae6c05cd879393d59702f033f4c3ccce30dba&target_commit=0115c829cc1021b01b1686c5d28a7f6004390c83 > > But what it does show is that there aren't any additional lint warnings, > and the derivations can be computed. > I do not see the first patch there, but it should be OK. I have built it on armhf and x86_64 and successfully modeswitched. Regards, Florian