unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Christopher Baines <mail@cbaines.net>
Cc: 39142-done@debbugs.gnu.org
Subject: bug#39142: Update USB_ModeSwitch.
Date: Mon, 20 Jan 2020 10:03:38 +0100	[thread overview]
Message-ID: <20200120090338.5otoyrppuhsp4p23@pelzflorian.localdomain> (raw)
In-Reply-To: <87sgkdovdm.fsf@cbaines.net>

On Sat, Jan 18, 2020 at 11:29:41AM +0000, Christopher Baines wrote:
> 
> pelzflorian (Florian Pelz) <pelzflorian@pelzflorian.de> writes:
> 
> > This series updates USB_ModeSwitch and its data package to their
> > November release.
> 
> Both patches look good to me :)
> 

Thank you for the review!  Pushed as
d0759f613480c13b8c81716eb46dc3606b3a34b0 and
17fe068ed7372dbae09043885b8f091105bef143.
Closing this bug.


> There's a somewhat uninformative comparison of Guix without these
> patches, and Guix with these patches here [1].
> 
> 1: https://guix-patches-data.cbaines.net/compare?base_commit=9edae6c05cd879393d59702f033f4c3ccce30dba&target_commit=0115c829cc1021b01b1686c5d28a7f6004390c83
> 
> But what it does show is that there aren't any additional lint warnings,
> and the derivations can be computed.
> 

I do not see the first patch there, but it should be OK.  I have built
it on armhf and x86_64 and successfully modeswitched.

Regards,
Florian

      parent reply	other threads:[~2020-01-20  9:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 12:48 [bug#39142] Update USB_ModeSwitch pelzflorian (Florian Pelz)
2020-01-15 12:50 ` [bug#39142] [PATCH 1/2] gnu: USB_ModeSwitch: Update to 2.6.0 Florian Pelz
2020-01-15 12:50 ` [bug#39142] [PATCH 2/2] gnu: USB_ModeSwitch data: Update to 20191128 Florian Pelz
2020-01-18 11:29 ` [bug#39142] Update USB_ModeSwitch Christopher Baines
2020-01-18 11:52   ` Danny Milosavljevic
2020-01-18 12:02     ` Christopher Baines
2020-01-19 10:11       ` Danny Milosavljevic
2020-01-20  9:03   ` pelzflorian (Florian Pelz) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200120090338.5otoyrppuhsp4p23@pelzflorian.localdomain \
    --to=pelzflorian@pelzflorian.de \
    --cc=39142-done@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).