From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:47201)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ir2Pj-0006Ns-E8
 for guix-patches@gnu.org; Mon, 13 Jan 2020 11:18:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ir2Pi-0008Eh-BB
 for guix-patches@gnu.org; Mon, 13 Jan 2020 11:18:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:53952)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ir2Pi-0008EN-7V
 for guix-patches@gnu.org; Mon, 13 Jan 2020 11:18:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ir2Pi-0000XH-1v
 for guix-patches@gnu.org; Mon, 13 Jan 2020 11:18:02 -0500
Subject: bug#38951: gnu: Add libgovirt.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.38951.D38951.15789322762040.done@debbugs.gnu.org>
Date: Mon, 13 Jan 2020 17:17:51 +0100
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20200113171751.388c4559@scratchpost.org>
In-Reply-To: <af9777e2d962b1e6d120c436ddf229b6@disroot.org>
References: <af9777e2d962b1e6d120c436ddf229b6@disroot.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/caDp0mC7M5WFbaArBoD2IKe";
 protocol="application/pgp-signature"; micalg=pgp-sha256
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 38951-done@debbugs.gnu.org

--Sig_/caDp0mC7M5WFbaArBoD2IKe
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Raghav,

I've found the reason for the test failure by using this patch:

--- libgovirt-0.3.6/tests/mock-httpd.c.orig	2020-01-13 16:54:08.578009738 +=
0100
+++ libgovirt-0.3.6/tests/mock-httpd.c	2020-01-13 16:54:58.442238829 +0100
@@ -114,6 +114,9 @@
 		cert =3D g_tls_certificate_new_from_files (abs_srcdir "/https-cert/serve=
r-cert.pem",
 							 abs_srcdir "/https-cert/server-key.pem",
 							 &error);
+		if (error !=3D NULL) {
+			fprintf(stderr, "ERROR: %s\n", error->message);
+		}
 		g_assert (error =3D=3D NULL);
 		server =3D soup_server_new (SOUP_SERVER_SERVER_HEADER, "simple-soup-http=
d ",
 					  SOUP_SERVER_TLS_CERTIFICATE, cert,

Then I fixed the test failure by adding glib-networking (which is a GIO plu=
gin).

I suspect that the tests won't work reliably because of the networking
involved (even when local)--but let's cross that bridge when we come to it.

Committed to guix master as commit 3f1ed953e8a596dc3a4924758a931b8a774bde5f.

--Sig_/caDp0mC7M5WFbaArBoD2IKe
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4cmC8ACgkQ5xo1VCww
uqWykwf8DW3gxOu3o38u3GnHZYcrUsLXYgD+GhlWo6PWmWp3No5JjfOaKiIJ+PBJ
PL+F+y07rNewtLTjEDNUSUkyfAMlfBUMCri5ekljGHg4+VtiJA9CkMXM9mwL37sv
Pr/Lteh8mKDN4FA1ScqPFVTux3EOrCSCQXnmrQGUI7w0Fhc62PkOIDNt8wa75NPX
VleHvz8RBl3EPMoHHSfT0HaDKF33+5LKROVpsCe0G+GaT0zq7gLTfD2VpQ9ItpiG
j+/wuImVa4teB8u/7v8hI/QCzFBzkWqS3ORWulhi0ud36EVP1ml8PkRCLPirKmxA
WmLvzhF1stmq4+L0xbS7bfoifT4L4w==
=7ABX
-----END PGP SIGNATURE-----

--Sig_/caDp0mC7M5WFbaArBoD2IKe--