unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 38905@debbugs.gnu.org
Subject: [bug#38905] gnu: Add gnome-initial-setup.
Date: Wed, 8 Jan 2020 00:31:14 +0100	[thread overview]
Message-ID: <20200108003114.25d65184@tachikoma.lepiller.eu> (raw)
In-Reply-To: <a31b185c581b45da91a8c6cc0943bcb039cf63e1.camel@disroot.org>

Le Fri, 03 Jan 2020 15:51:58 -0500,
Raghav Gururajan <raghavgururajan@disroot.org> a écrit :

> Hello Guix!
> 
> Please find the attached patch to add gnome-initial-setup.
> 
> Regards,
> RG.

Thanks for the patch!

I have a few questions about it, even though I didn't try to build it
yet. What is optional in configure-flags? You should probably remove
the comment in the inputs (the package doesn't exist, right?).

I'm a bit puzzled by how this package works. Should some of these
inputs be propagated or hard-coded in the code of the package?
Shouldn't they be available at runtime? What does ibus, upower and the
like do for the build itself?

I think pkg-config should be a native-input.

The description is a bit vague. What does it do exactly? Maybe there's
some things that guix cannot setup and that's what it's used for? I'm
not sure what the policy for "aims to" is, but I think I would remove
it.

  reply	other threads:[~2020-01-07 23:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03 20:51 [bug#38905] gnu: Add gnome-initial-setup Raghav Gururajan
2020-01-07 23:31 ` Julien Lepiller [this message]
2020-01-09 14:00   ` [bug#38905] gnu: Add gnome-initial-setup. (v2) Raghav Gururajan
2020-01-12 21:39     ` bug#38905: " Danny Milosavljevic
2020-01-12 21:43     ` [bug#38905] " Raghav Gururajan
2020-01-13  7:36       ` Danny Milosavljevic
2020-01-14  0:03       ` Raghav Gururajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200108003114.25d65184@tachikoma.lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=38905@debbugs.gnu.org \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).