From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54308) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io4wv-0001db-Jp for guix-patches@gnu.org; Sun, 05 Jan 2020 07:24:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1io4wu-0003iL-F6 for guix-patches@gnu.org; Sun, 05 Jan 2020 07:24:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37783) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1io4ws-0003gG-Ey for guix-patches@gnu.org; Sun, 05 Jan 2020 07:24:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1io4ws-0001Nm-B4 for guix-patches@gnu.org; Sun, 05 Jan 2020 07:24:02 -0500 Subject: [bug#38941] [PATCH 0/5] Support fluidsynth and opus in sdl(2)-mixer, and other tweaks Resent-Message-ID: Date: Sun, 5 Jan 2020 13:23:44 +0100 From: Danny Milosavljevic Message-ID: <20200105132306.32d6f294@scratchpost.org> In-Reply-To: <87v9pqdwb1.fsf@araneo.si> References: <87v9pqdwb1.fsf@araneo.si> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/TBesG/S8cWn._JJ8LTIJG12"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Timotej Lazar Cc: 38941@debbugs.gnu.org, Ricardo Wurmus --Sig_/TBesG/S8cWn._JJ8LTIJG12 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, thanks for the patches! On Sun, 05 Jan 2020 11:36:34 +0100 Timotej Lazar wrote: > The MIDI backends need additional runtime configuration. Fluidsynth > requires a soundfont to be installed and specified when running a > program that uses sdl-mixer, e.g.: >=20 > SDL_SOUNDFONTS=3D/gnu/store/=E2=80=A6-fluid-3-2.1/share/soundfonts/Fl= uidR3Mono_GM.sf3 >=20 > If this is not set, the bundled timidity backend is used, which can use > the freepats samples. Configuration must be specified since only files > under /etc are checked by default, e.g.: >=20 > TIMIDITY_CFG=3D/gnu/store/=E2=80=A6-freepats-20060219/share/freepats/= freepats.cfg > I=E2=80=99m not sure if and how default values for these vars can be spec= ified > for all programs using sdl-mixer, and I would prefer to leave the choice > of backend to the user anyway. > However, we should probably document them somewhere. Would a comment be e= nough? Let's put it in the description of the sdl-mixer package. After all, it would document the usage of an interface that sdl-mixer provi= des. > Dependent packages can then wrap > binaries to set required paths if needed. >=20 > Alternatively we can add freepats and/or fluid as inputs to sdl(2)-mixer > and patch the source to look for them in the store. How often is it that a user switches MIDI soundfonts? Does a user expect a default soundfont? That would tell us whether we should provide such a default (and increase the closure size of sdl2-mixer considerably, maybe?). There's also a procedure "sdl-union" which already does sdl magic. We could also add some stuff for MIDI there, maybe. In the mean time, I've applied your patchset to master since it only adds functionality and only has few dependents. Could you provide an update to the description or similar as a patch? --Sig_/TBesG/S8cWn._JJ8LTIJG12 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4R1VAACgkQ5xo1VCww uqUkzQf6Ayxl8b9l7o05e21UyDRzs++8WVScRrm4NMqO2EAwVpeu9QiWP+ySywVk 3IM4U/4b0RWu2CqwHIkiRBix8+HJpdL9aJrxIkNY20hE9WSegGY2loifvjmwBMy9 RRsmNrEq/xoXRSZxnO/+YUO+sF0imGEOq1OnHQgABiQWR+vQ2A5N3aS6hUGqJ+0/ /GUseXNzbtOald5y/leUWjbvVZ2k7E0xwxDN7hUpE5qZN/GyDodEmQ3hIZvIAMoJ ddQdhnjCkez0jqFSZXDTryD0LRYUmlFC5YEkTTgxT437qE9RUvPs9J03qXfbGt+5 DsjVY3tcwyJVdqWAHxLgUKe1krs/yA== =ZgLJ -----END PGP SIGNATURE----- --Sig_/TBesG/S8cWn._JJ8LTIJG12--